[ticket/11008] Change onunload_functions to not use eval()

PHPBB3-11008
This commit is contained in:
Igor Wiedler 2012-07-20 23:59:04 +02:00
parent ca43a8947a
commit 61f7f1b8ed
6 changed files with 12 additions and 8 deletions

View file

@ -2,7 +2,9 @@
<script type="text/javascript">
// <![CDATA[
onload_functions.push('document.getElementById("<!-- IF S_ADMIN_AUTH -->{PASSWORD_CREDENTIAL}<!-- ELSE -->{USERNAME_CREDENTIAL}<!-- ENDIF -->").focus();');
onload_functions.push(function () {
document.getElementById("<!-- IF S_ADMIN_AUTH -->{PASSWORD_CREDENTIAL}<!-- ELSE -->{USERNAME_CREDENTIAL}<!-- ENDIF -->").focus();
});
// ]]>
</script>

View file

@ -56,7 +56,7 @@
{
for (var i = 0; i < onload_functions.length; i++)
{
eval(onload_functions[i]);
onload_functions[i]();
}
};
@ -64,7 +64,7 @@
{
for (var i = 0; i < onunload_functions.length; i++)
{
eval(onunload_functions[i]);
onunload_functions[i]();
}
};

View file

@ -1,6 +1,6 @@
<script type="text/javascript">
// <![CDATA[
onload_functions.push('apply_onkeypress_event()');
onload_functions.push(apply_onkeypress_event);
// ]]>
</script>

View file

@ -2,7 +2,9 @@
<script type="text/javascript">
// <![CDATA[
onload_functions.push('document.getElementById("keywords").focus();');
onload_functions.push(function () {
document.getElementById("keywords").focus();
});
// ]]>
</script>

View file

@ -26,7 +26,7 @@
{
for (var i = 0; i < onload_functions.length; i++)
{
eval(onload_functions[i]);
onload_functions[i]();
}
}
@ -34,7 +34,7 @@
{
for (var i = 0; i < onunload_functions.length; i++)
{
eval(onunload_functions[i]);
onunload_functions[i]();
}
}

View file

@ -12,7 +12,7 @@
}
<!-- IF CAPTCHA_TEMPLATE and S_CONFIRM_REFRESH -->
onload_functions.push('apply_onkeypress_event()');
onload_functions.push(apply_onkeypress_event);
<!-- ENDIF -->
// ]]>