From 62f59fa59d08fe91c3e94aa12e6ccbea1ae27111 Mon Sep 17 00:00:00 2001
From: v12mike <v12mike.git@ingenious.co.nz>
Date: Sun, 12 Jan 2020 22:02:08 -0500
Subject: [PATCH] [ticket/16138] Eliminate redundant parameters from board URLs

Minor fixes after review

PHPBB3-16138
---
 phpBB/posting.php | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/phpBB/posting.php b/phpBB/posting.php
index f036971a0a..a5240094fc 100644
--- a/phpBB/posting.php
+++ b/phpBB/posting.php
@@ -42,25 +42,24 @@ $submit = $request->is_set_post('post') && !$refresh && !$preview;
 $mode		= $request->variable('mode', '');
 
 // We need to choose which of the url parameters we must trust and ignore the others
-	$forum_id = 0;
-	$topic_id = 0;
-	$post_id = 0;
+$forum_id = 0;
+$topic_id = 0;
+$post_id = 0;
 
 switch ($mode)
 {
 	case 'popup':
 	case 'smilies':
 		$forum_id = $request->variable('f', 0);
-		break;
+	break;
 
 	case 'post':
 		$forum_id = $request->variable('f', 0);
 		if (!$forum_id)
 		{
-			$user->setup('posting');
 			trigger_error('NO_FORUM');
 		}
-		break;
+	break;
 
 	case 'bump':
 	case 'reply':
@@ -76,10 +75,9 @@ switch ($mode)
 		}
 		if (!$topic_id || !$forum_id)
 		{
-			$user->setup('posting');
 			trigger_error('NO_TOPIC');
 		}
-		break;
+	break;
 
 	case 'edit':
 	case 'delete':
@@ -106,7 +104,7 @@ switch ($mode)
 			$user->setup('posting');
 			trigger_error('NO_POST');
 		}
-		break;
+	break;
 }