diff --git a/phpBB/admin/admin_board.php b/phpBB/admin/admin_board.php index bba31e9751..8753218998 100644 --- a/phpBB/admin/admin_board.php +++ b/phpBB/admin/admin_board.php @@ -46,7 +46,7 @@ else if( isset($HTTP_POST_VARS['submit']) ) { $sql = "UPDATE " . CONFIG_TABLE . " SET - config_value = '" . $new[$config_name] . "' + config_value = '" . str_replace("\'", "''", $new[$config_name]) . "' WHERE config_name = '$config_name'"; if( !$db->sql_query($sql) ) { diff --git a/phpBB/admin/admin_disallow.php b/phpBB/admin/admin_disallow.php index 61da110417..e980e3feca 100644 --- a/phpBB/admin/admin_disallow.php +++ b/phpBB/admin/admin_disallow.php @@ -46,7 +46,7 @@ if( isset($HTTP_POST_VARS['add_name']) ) else { $sql = "INSERT INTO " . DISALLOW_TABLE . " (disallow_username) - VALUES('" . $disallowed_user . "')"; + VALUES('" . str_replace("\'", "''", $disallowed_user) . "')"; $result = $db->sql_query( $sql ); if ( !$result ) { diff --git a/phpBB/admin/admin_forums.php b/phpBB/admin/admin_forums.php index faae94b16f..749b5481af 100644 --- a/phpBB/admin/admin_forums.php +++ b/phpBB/admin/admin_forums.php @@ -253,7 +253,7 @@ if( !empty($mode) ) $newmode = 'modforum'; $buttonvalue = $lang['Update']; - $forum_id = intval($HTTP_GET_VARS['forum_id']); + $forum_id = intval($HTTP_GET_VARS[POST_FORUM_URL]); $row = get_info('forum', $forum_id); @@ -305,7 +305,7 @@ if( !empty($mode) ) "body" => "admin/forum_edit_body.tpl") ); - $s_hidden_fields = ''; + $s_hidden_fields = ''; $template->assign_vars(array( 'S_FORUM_ACTION' => append_sid("admin_forums.$phpEx"), @@ -347,7 +347,7 @@ if( !empty($mode) ) $sql = "SELECT MAX(forum_order) AS max_order FROM " . FORUMS_TABLE . " - WHERE cat_id = " . intval($HTTP_POST_VARS['cat_id']); + WHERE cat_id = " . intval($HTTP_POST_VARS[POST_CAT_URL]); if( !$result = $db->sql_query($sql) ) { message_die(GENERAL_ERROR, "Couldn't get order number from forums table", "", __LINE__, __FILE__, $sql); @@ -382,7 +382,7 @@ if( !empty($mode) ) // There is no problem having duplicate forum names so we won't check for it. $sql = "INSERT INTO " . FORUMS_TABLE . " (forum_id, forum_name, cat_id, forum_desc, forum_order, forum_status, prune_enable" . $field_sql . ") - VALUES ('" . $next_id . "', '" . $HTTP_POST_VARS['forumname'] . "', " . intval($HTTP_POST_VARS['cat_id']) . ", '" . $HTTP_POST_VARS['forumdesc'] . "', $next_order, " . intval($HTTP_POST_VARS['forumstatus']) . ", " . intval($HTTP_POST_VARS['prune_enable']) . $value_sql . ")"; + VALUES ('" . $next_id . "', '" . str_replace("\'", "''", $HTTP_POST_VARS['forumname']) . "', " . intval($HTTP_POST_VARS[POST_CAT_URL]) . ", '" . str_replace("\'", "''", $HTTP_POST_VARS['forumdesc']) . "', $next_order, " . intval($HTTP_POST_VARS['forumstatus']) . ", " . intval($HTTP_POST_VARS['prune_enable']) . $value_sql . ")"; if( !$result = $db->sql_query($sql) ) { message_die(GENERAL_ERROR, "Couldn't insert row in forums table", "", __LINE__, __FILE__, $sql); @@ -392,7 +392,7 @@ if( !empty($mode) ) { $new_forum_id = $db->sql_nextid(); - if($HTTP_POST_VARS['prune_days'] == "" || $HTTP_POST_VARS['prune_freq'] == "") + if( $HTTP_POST_VARS['prune_days'] == "" || $HTTP_POST_VARS['prune_freq'] == "") { message_die(GENERAL_MESSAGE, $lang['Set_prune_data']); } @@ -422,23 +422,23 @@ if( !empty($mode) ) } $sql = "UPDATE " . FORUMS_TABLE . " - SET forum_name = '" . $HTTP_POST_VARS['forumname'] . "', cat_id = " . intval($HTTP_POST_VARS['cat_id']) . ", forum_desc = '" . $HTTP_POST_VARS['forumdesc'] . "', forum_status = " . intval($HTTP_POST_VARS['forumstatus']) . ", prune_enable = " . intval($HTTP_POST_VARS['prune_enable']) . " - WHERE forum_id = " . intval($HTTP_POST_VARS['forum_id']); + SET forum_name = '" . str_replace("\'", "''", $HTTP_POST_VARS['forumname']) . "', cat_id = " . intval($HTTP_POST_VARS[POST_CAT_URL]) . ", forum_desc = '" . str_replace("\'", "''", $HTTP_POST_VARS['forumdesc']) . "', forum_status = " . intval($HTTP_POST_VARS['forumstatus']) . ", prune_enable = " . intval($HTTP_POST_VARS['prune_enable']) . " + WHERE forum_id = " . intval($HTTP_POST_VARS[POST_FORUM_URL]); if( !$result = $db->sql_query($sql) ) { message_die(GENERAL_ERROR, "Couldn't update forum information", "", __LINE__, __FILE__, $sql); } - if($HTTP_POST_VARS['prune_enable'] == 1) + if( $HTTP_POST_VARS['prune_enable'] == 1 ) { - if($HTTP_POST_VARS['prune_days'] == "" || $HTTP_POST_VARS['prune_freq'] == "") + if( $HTTP_POST_VARS['prune_days'] == "" || $HTTP_POST_VARS['prune_freq'] == "" ) { message_die(GENERAL_MESSAGE, $lang['Set_prune_data']); } $sql = "SELECT * FROM " . PRUNE_TABLE . " - WHERE forum_id = " . intval($HTTP_POST_VARS['forum_id']); + WHERE forum_id = " . intval($HTTP_POST_VARS[POST_FORUM_URL]); if( !$result = $db->sql_query($sql) ) { message_die(GENERAL_ERROR, "Couldn't get forum Prune Information","",__LINE__, __FILE__, $sql); @@ -448,12 +448,12 @@ if( !empty($mode) ) { $sql = "UPDATE " . PRUNE_TABLE . " SET prune_days = " . intval($HTTP_POST_VARS['prune_days']) . ", prune_freq = " . intval($HTTP_POST_VARS['prune_freq']) . " - WHERE forum_id = " . intval($HTTP_POST_VARS['forum_id']); + WHERE forum_id = " . intval($HTTP_POST_VARS[POST_FORUM_URL]); } else { $sql = "INSERT INTO " . PRUNE_TABLE . " (forum_id, prune_days, prune_freq) - VALUES(" . intval($HTTP_POST_VARS['forum_id']) . ", " . intval($HTTP_POST_VARS['prune_days']) . ", " . intval($HTTP_POST_VARS['prune_freq']) . ")"; + VALUES(" . intval($HTTP_POST_VARS[POST_FORUM_URL]) . ", " . intval($HTTP_POST_VARS['prune_days']) . ", " . intval($HTTP_POST_VARS['prune_freq']) . ")"; } if( !$result = $db->sql_query($sql) ) @@ -509,7 +509,7 @@ if( !empty($mode) ) $newmode = 'modcat'; $buttonvalue = $lang['Update']; - $cat_id = intval($HTTP_GET_VARS['cat_id']); + $cat_id = intval($HTTP_GET_VARS[POST_CAT_URL]); $row = get_info('category', $cat_id); $cat_title = $row['cat_title']; @@ -518,7 +518,7 @@ if( !empty($mode) ) "body" => "admin/category_edit_body.tpl") ); - $s_hidden_fields = ''; + $s_hidden_fields = ''; $template->assign_vars(array( 'CAT_TITLE' => $cat_title, @@ -538,8 +538,8 @@ if( !empty($mode) ) case 'modcat': // Modify a category in the DB $sql = "UPDATE " . CATEGORIES_TABLE . " - SET cat_title = '" . $HTTP_POST_VARS['cat_title'] . "' - WHERE cat_id = " . intval($HTTP_POST_VARS['cat_id']); + SET cat_title = '" . str_replace("\'", "''", $HTTP_POST_VARS['cat_title']) . "' + WHERE cat_id = " . intval($HTTP_POST_VARS[POST_CAT_URL]); if( !$result = $db->sql_query($sql) ) { message_die(GENERAL_ERROR, "Couldn't update forum information", "", __LINE__, __FILE__, $sql); @@ -553,7 +553,7 @@ if( !empty($mode) ) case 'deleteforum': // Show form to delete a forum - $forum_id = intval($HTTP_GET_VARS['forum_id']); + $forum_id = intval($HTTP_GET_VARS[POST_FORUM_URL]); $select_to = '