makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-10 13:28:55 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/16686] Simplify get_database_size() SQL query for PostgreSQL

Browse source 
Reduce number of queries to get database size and add it to the cache
for 2 hours, like it is being done for other RDBMS.

PHPBB3-16686
This commit is contained in:
Alfredo Ramos 2021-01-15 13:48:59 -06:00
parent 57e2a32d4c
commit 63b7da3b60
1 changed files with 9 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
phpBB/includes/functions_admin.php
View file

@ -2900,37 +2900,18 @@ function get_database_size()
break;
case 'postgres':
$sql = "SELECT proname
FROM pg_proc
WHERE proname = 'pg_database_size'";
$result = $db->sql_query($sql);
$row = $db->sql_fetchrow($result);
$db->sql_freeresult($result);
$database = $db->get_db_name();
if ($row['proname'] == 'pg_database_size')
if (strpos($database, '.') !== false)
{
$database = $db->get_db_name();
if (strpos($database, '.') !== false)
{
list($database, ) = explode('.', $database);
}
$sql = "SELECT oid
FROM pg_database
WHERE datname = '$database'";
$result = $db->sql_query($sql);
$row = $db->sql_fetchrow($result);
$db->sql_freeresult($result);
$oid = $row['oid'];
$sql = 'SELECT pg_database_size(' . $oid . ') as size';
$result = $db->sql_query($sql);
$row = $db->sql_fetchrow($result);
$db->sql_freeresult($result);
$database_size = $row['size'];
$database = explode('.', $database)[0];
}
$sql = "SELECT pg_database_size('" . $database . "') AS dbsize";
$result = $db->sql_query($sql, 7200);
$row = $db->sql_fetchrow($result);
$database_size = !empty($row['dbsize']) ? $row['dbsize'] : false;
$db->sql_freeresult($result);
break;
case 'oracle':