- bug fixes for #5618, #5588 and #5584

- remove messenger->reset() calls (they are already performed on sending)


git-svn-id: file:///svn/phpbb/trunk@6660 89ea8834-ac86-4346-8a33-228a782c2dd0

phpBB/includes/acp/acp_groups.php

@@ -450,6 +450,8 @@ class acp_groups
 
 				if (isset($group_row['group_avatar']) && $group_row['group_avatar'])
 				{
+					$avatar_img = '';
+
 					switch ($group_row['group_avatar_type'])
 					{
 						case AVATAR_UPLOAD:
@@ -460,8 +462,8 @@ class acp_groups
 							$avatar_img = $phpbb_root_path . $config['avatar_gallery_path'] . '/';
 						break;
 					}
-					$avatar_img .= $group_row['group_avatar'];
 
+					$avatar_img .= $group_row['group_avatar'];
 					$avatar_img = '<img src="' . $avatar_img . '" width="' . $group_row['group_avatar_width'] . '" height="' . $group_row['group_avatar_height'] . '" alt="" />';
 				}
 				else

phpBB/includes/functions.php

@@ -2433,8 +2433,8 @@ function parse_inline_attachments(&$text, &$attachments, &$update_count, $forum_
 		include("{$phpbb_root_path}includes/functions_display.$phpEx");
 	}
 
-	$attachment_tpl = display_attachments($forum_id, NULL, $attachments, $update_count, false, true);
+	$attachments = display_attachments($forum_id, NULL, $attachments, $update_count, false, true);
-	$tpl_size = sizeof($attachment_tpl);
+	$tpl_size = sizeof($attachments);
 
 	$unset_tpl = array();
 
@@ -2447,7 +2447,7 @@ function parse_inline_attachments(&$text, &$attachments, &$update_count, $forum_
 		$index = ($config['display_order']) ? ($tpl_size-($matches[1][$num] + 1)) : $matches[1][$num];
 
 		$replace['from'][] = $matches[0][$num];
-		$replace['to'][] = (isset($attachment_tpl[$index])) ? $attachment_tpl[$index] : sprintf($user->lang['MISSING_INLINE_ATTACHMENT'], $matches[2][array_search($index, $matches[1])]);
+		$replace['to'][] = (isset($attachments[$index])) ? $attachments[$index] : sprintf($user->lang['MISSING_INLINE_ATTACHMENT'], $matches[2][array_search($index, $matches[1])]);
 
 		$unset_tpl[] = $index;
 	}

phpBB/includes/functions_posting.php

@@ -1124,7 +1124,6 @@ function user_notification($mode, $subject, $topic_title, $forum_name, $forum_id
 				));
 
 				$messenger->send($addr['method']);
-				$messenger->reset();
 			}
 		}
 		unset($msg_list_ary);

phpBB/includes/functions_privmsgs.php

@@ -1623,7 +1623,6 @@ function pm_notification($mode, $author, $recipients, $subject, $message)
 		);
 
 		$messenger->send($addr['method']);
-		$messenger->reset();
 	}
 	unset($msg_list_ary);
 

phpBB/includes/functions_user.php

@@ -2018,7 +2018,6 @@ function group_user_attributes($action, $group_id, $user_id_ary = false, $userna
 				);
 
 				$messenger->send($row['user_notify_type']);
-				$messenger->reset();
 			}
 
 			$messenger->save_queue();

phpBB/includes/mcp/mcp_notes.php

@@ -142,6 +142,7 @@ class mcp_notes
 //		get_user_rank($userrow['user_rank'], $userrow['user_posts'], $rank_title, $rank_img);
 
 		$avatar_img = '';
+
 		if (!empty($userrow['user_avatar']))
 		{
 			switch ($userrow['user_avatar_type'])
@@ -154,8 +155,8 @@ class mcp_notes
 					$avatar_img = $config['avatar_gallery_path'] . '/';
 				break;
 			}
-			$avatar_img .= $userrow['user_avatar'];
 
+			$avatar_img .= $userrow['user_avatar'];
 			$avatar_img = '<img src="' . $avatar_img . '" width="' . $userrow['user_avatar_width'] . '" height="' . $userrow['user_avatar_height'] . '" alt="" />';
 		}
 

phpBB/includes/mcp/mcp_queue.php

@@ -558,11 +558,10 @@ function approve_post($post_id_list, $mode)
 				);
 
 				$messenger->send($post_data['user_notify_type']);
-				$messenger->reset();
+			}
 		}
 
 		$messenger->save_queue();
-		}
 
 		// Send out normal user notifications
 		$email_sig = str_replace('<br />', "\n", "-- \n" . $config['board_email_sig']);
@@ -780,13 +779,12 @@ function disapprove_post($post_id_list, $mode)
 				);
 
 				$messenger->send($post_data['user_notify_type']);
-				$messenger->reset();
 			}
-
-			$messenger->save_queue();
 		}
 		unset($post_info, $disapprove_reason);
 
+		$messenger->save_queue();
+
 		if (sizeof($forum_topics_real))
 		{
 			$success_msg = ($num_disapproved == 1) ? 'TOPIC_DISAPPROVED_SUCCESS' : 'TOPICS_DISAPPROVED_SUCCESS';

phpBB/includes/mcp/mcp_reports.php

@@ -494,13 +494,12 @@ function close_report($post_id_list, $mode, $action)
 				);
 
 				$messenger->send($reporter['user_notify_type']);
-				$messenger->reset();
 			}
-
-			$messenger->save_queue();
 		}
 		unset($notify_reporters, $post_info);
 
+		$messenger->save_queue();
+
 		$success_msg = (sizeof($post_id_list) == 1) ? 'REPORT_' . strtoupper($action) . 'D_SUCCESS' : 'REPORTS_' . strtoupper($action) . 'D_SUCCESS';
 	}
 	else

phpBB/includes/mcp/mcp_warn.php

@@ -275,6 +275,7 @@ function mcp_warn_post_view($id, $mode, $action)
 //	get_user_rank($userrow['user_rank'], $userrow['user_posts'], $rank_title, $rank_img);
 
 	$avatar_img = '';
+
 	if (!empty($userrow['user_avatar']))
 	{
 		switch ($userrow['user_avatar_type'])
@@ -287,8 +288,8 @@ function mcp_warn_post_view($id, $mode, $action)
 				$avatar_img = $config['avatar_gallery_path'] . '/';
 			break;
 		}
-		$avatar_img .= $userrow['user_avatar'];
 
+		$avatar_img .= $userrow['user_avatar'];
 		$avatar_img = '<img src="' . $avatar_img . '" width="' . $userrow['user_avatar_width'] . '" height="' . $userrow['user_avatar_height'] . '" alt="" />';
 	}
 
@@ -359,6 +360,7 @@ function mcp_warn_user_view($id, $mode, $action)
 //	get_user_rank($userrow['user_rank'], $userrow['user_posts'], $rank_title, $rank_img);
 
 	$avatar_img = '';
+
 	if (!empty($userrow['user_avatar']))
 	{
 		switch ($userrow['user_avatar_type'])
@@ -371,8 +373,8 @@ function mcp_warn_user_view($id, $mode, $action)
 				$avatar_img = $config['avatar_gallery_path'] . '/';
 			break;
 		}
-		$avatar_img .= $userrow['user_avatar'];
 
+		$avatar_img .= $userrow['user_avatar'];
 		$avatar_img = '<img src="' . $avatar_img . '" width="' . $userrow['user_avatar_width'] . '" height="' . $userrow['user_avatar_height'] . '" alt="" />';
 	}
 

phpBB/includes/ucp/ucp_groups.php

@@ -196,7 +196,6 @@ class ucp_groups
 									);
 
 									$messenger->send($row['user_notify_type']);
-									$messenger->reset();
 								}
 								$db->sql_freeresult($result);
 
@@ -575,6 +574,8 @@ class ucp_groups
 
 						if (isset($group_row['group_avatar']) && $group_row['group_avatar'])
 						{
+							$avatar_img = '';
+
 							switch ($group_row['group_avatar_type'])
 							{
 								case AVATAR_UPLOAD:
@@ -585,8 +586,8 @@ class ucp_groups
 									$avatar_img = $phpbb_root_path . $config['avatar_gallery_path'] . '/';
 								break;
 							}
-							$avatar_img .= $group_row['group_avatar'];
 
+							$avatar_img .= $group_row['group_avatar'];
 							$avatar_img = '<img src="' . $avatar_img . '" width="' . $group_row['group_avatar_width'] . '" height="' . $group_row['group_avatar_height'] . '" alt="" />';
 						}
 						else

phpBB/includes/ucp/ucp_pm_viewmessage.php

@@ -426,6 +426,7 @@ function get_user_information($user_id, $user_row)
 	if ($user_row['user_avatar'] && $user->optionget('viewavatars'))
 	{
 		$avatar_img = '';
+
 		switch ($user_row['user_avatar_type'])
 		{
 			case AVATAR_UPLOAD:
@@ -436,8 +437,8 @@ function get_user_information($user_id, $user_row)
 				$avatar_img = $config['avatar_gallery_path'] . '/';
 			break;
 		}
-		$avatar_img .= $user_row['user_avatar'];
 
+		$avatar_img .= $user_row['user_avatar'];
 		$user_row['avatar'] = '<img src="' . $avatar_img . '" width="' . $user_row['user_avatar_width'] . '" height="' . $user_row['user_avatar_height'] . '" alt="' . $user->lang['USER_AVATAR'] . '" />';
 	}
 

phpBB/includes/ucp/ucp_profile.php

@@ -125,7 +125,7 @@ class ucp_profile
 							$key_len = ($key_len > 6) ? $key_len : 6;
 							$user_actkey = substr($user_actkey, 0, $key_len);
 
-							$messenger = new messenger();
+							$messenger = new messenger(false);
 
 							$template_file = ($config['require_activation'] == USER_ACTIVATION_ADMIN) ? 'user_activate_inactive' : 'user_activate';
 							$messenger->template($template_file, $user->data['user_lang']);
@@ -182,8 +182,6 @@ class ucp_profile
 								$db->sql_freeresult($result);
 							}
 
-							$messenger->save_queue();
-
 							user_active_flip('deactivate', $user->data['user_id'], INACTIVE_PROFILE);
 
 							$sql_ary += array(
@@ -605,8 +603,8 @@ class ucp_profile
 							$avatar_img = $phpbb_root_path . $config['avatar_gallery_path'] . '/';
 						break;
 					}
-					$avatar_img .= $user->data['user_avatar'];
 
+					$avatar_img .= $user->data['user_avatar'];
 					$avatar_img = '<img src="' . $avatar_img . '" width="' . $user->data['user_avatar_width'] . '" height="' . $user->data['user_avatar_height'] . '" alt="" />';
 				}
 

phpBB/memberlist.php

@@ -1058,6 +1058,7 @@ switch ($mode)
 			}
 
 			$avatar_img = '';
+
 			if ($group_row['group_avatar'])
 			{
 				switch ($group_row['group_avatar_type'])
@@ -1070,8 +1071,8 @@ switch ($mode)
 						$avatar_img = $phpbb_root_path . $config['avatar_gallery_path'] . '/';
 					break;
 				}
-				$avatar_img .= $group_row['group_avatar'];
 
+				$avatar_img .= $group_row['group_avatar'];
 				$avatar_img = '<img src="' . $avatar_img . '" width="' . $group_row['group_avatar_width'] . '" height="' . $group_row['group_avatar_height'] . '" alt="" />';
 			}
 

phpBB/viewforum.php

@@ -469,7 +469,7 @@ if (sizeof($topic_list))
 		$topic_forum_list = array();
 		foreach ($rowset as $t_id => $row)
 		{
-			$topic_forum_list[$row['forum_id']]['forum_mark_time'] = ($config['load_db_lastread'] && $user->data['is_registered']) ? $row['forum_mark_time'] : 0;
+			$topic_forum_list[$row['forum_id']]['forum_mark_time'] = ($config['load_db_lastread'] && $user->data['is_registered'] && isset($row['forum_mark_time'])) ? $row['forum_mark_time'] : 0;
 			$topic_forum_list[$row['forum_id']]['topics'][] = $t_id;
 		}
 

phpBB/viewtopic.php

@@ -1032,6 +1032,7 @@ while ($row = $db->sql_fetchrow($result))
 			if ($row['user_avatar'] && $user->optionget('viewavatars'))
 			{
 				$avatar_img = '';
+
 				switch ($row['user_avatar_type'])
 				{
 					case AVATAR_UPLOAD:
@@ -1042,8 +1043,8 @@ while ($row = $db->sql_fetchrow($result))
 						$avatar_img = $config['avatar_gallery_path'] . '/';
 					break;
 				}
-				$avatar_img .= $row['user_avatar'];
 
+				$avatar_img .= $row['user_avatar'];
 				$user_cache[$poster_id]['avatar'] = '<img src="' . $avatar_img . '" width="' . $row['user_avatar_width'] . '" height="' . $row['user_avatar_height'] . '" alt="" />';
 			}