makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 06:08:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge remote-tracking branch 'varunagw/ticket/12355' into develop-ascraeus

Browse source 
* varunagw/ticket/12355:
  [ticket/12355] Topic Tools not fully updated when subscribing/bookmarking
This commit is contained in:
Joas Schilling 2014-04-11 09:13:45 +02:00
commit 6664dbb586
2 changed files with 41 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
phpBB/assets/javascript/core.js
View file

@ -549,13 +549,23 @@ phpbb.addAjaxCallback = function(id, callback) {
* current text so that the process can be repeated.
*/
phpbb.addAjaxCallback('alt_text', function() {
var el = $(this),
var el,
updateAll = $(this).data('update-all'),
altText;
if (updateAll !== undefined && updateAll.length) {
el = $(updateAll);
} else {
el = $(this);
}
el.each(function() {
var el = $(this);
altText = el.attr('data-alt-text');
el.attr('data-alt-text', el.text());
el.attr('title', altText);
el.attr('title', $.trim(altText));
el.text(altText);
});
});
/**
@ -568,16 +578,25 @@ phpbb.addAjaxCallback('alt_text', function() {
* and changes the link itself.
*/
phpbb.addAjaxCallback('toggle_link', function() {
var el = $(this),
var el,
updateAll = $(this).data('update-all') ,
toggleText,
toggleUrl,
toggleClass;
// Toggle link text
if (updateAll !== undefined && updateAll.length) {
el = $(updateAll);
} else {
el = $(this);
}
el.each(function() {
var el = $(this);
// Toggle link text
toggleText = el.attr('data-toggle-text');
el.attr('data-toggle-text', el.text());
el.attr('title', toggleText);
el.attr('title', $.trim(toggleText));
el.text(toggleText);
// Toggle link url
@ -589,6 +608,7 @@ phpbb.addAjaxCallback('toggle_link', function() {
toggleClass = el.attr('data-toggle-class');
el.attr('data-toggle-class', el.parent().attr('class'));
el.parent().attr('class', toggleClass);
});
});
/**

4
phpBB/styles/prosilver/template/viewtopic_topic_tools.html
View file

@ -7,14 +7,14 @@
<!-- EVENT viewtopic_topic_tools_before -->
<!-- IF U_WATCH_TOPIC -->
<li class="small-icon icon-<!-- IF S_WATCHING_TOPIC -->unsubscribe<!-- ELSE -->subscribe<!-- ENDIF -->">
<a href="{U_WATCH_TOPIC}" title="{S_WATCH_TOPIC_TITLE}" data-ajax="toggle_link" data-toggle-class="small-icon icon-<!-- IF not S_WATCHING_TOPIC -->unsubscribe<!-- ELSE -->subscribe<!-- ENDIF -->" data-toggle-text="{S_WATCH_TOPIC_TOGGLE}" data-toggle-url="{U_WATCH_TOPIC_TOGGLE}">
<a href="{U_WATCH_TOPIC}" class="watch-topic-link" title="{S_WATCH_TOPIC_TITLE}" data-ajax="toggle_link" data-toggle-class="small-icon icon-<!-- IF not S_WATCHING_TOPIC -->unsubscribe<!-- ELSE -->subscribe<!-- ENDIF -->" data-toggle-text="{S_WATCH_TOPIC_TOGGLE}" data-toggle-url="{U_WATCH_TOPIC_TOGGLE}" data-update-all=".watch-topic-link">
{S_WATCH_TOPIC_TITLE}
</a>
</li>
<!-- ENDIF -->
<!-- IF U_BOOKMARK_TOPIC -->
<li class="small-icon icon-bookmark">
<a href="{U_BOOKMARK_TOPIC}" title="{L_BOOKMARK_TOPIC}" data-ajax="alt_text" data-alt-text="{S_BOOKMARK_TOGGLE}">
<a href="{U_BOOKMARK_TOPIC}" class="bookmark-link" title="{L_BOOKMARK_TOPIC}" data-ajax="alt_text" data-alt-text="{S_BOOKMARK_TOGGLE}" data-update-all=".bookmark-link">
{S_BOOKMARK_TOPIC}
</a>
</li>