From 687448be49a6d3a7d0ede2aeb42ab2d4b639999e Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Thu, 17 Oct 2024 19:57:31 +0200 Subject: [PATCH] [ticket/17414] Clean up small code issues noticed by sniffer PHPBB-17414 --- phpBB/phpbb/captcha/plugins/base.php | 11 +++++++++++ phpBB/phpbb/captcha/plugins/legacy_wrapper.php | 2 +- phpBB/phpbb/captcha/plugins/turnstile.php | 2 +- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/phpBB/phpbb/captcha/plugins/base.php b/phpBB/phpbb/captcha/plugins/base.php index 43d24f7c8d..1b02d63166 100644 --- a/phpBB/phpbb/captcha/plugins/base.php +++ b/phpBB/phpbb/captcha/plugins/base.php @@ -1,4 +1,15 @@ + * @license GNU General Public License, version 2 (GPL-2.0) + * + * For full copyright and license information, please see + * the docs/CREDITS.txt file. + * + */ namespace phpbb\captcha\plugins; diff --git a/phpBB/phpbb/captcha/plugins/legacy_wrapper.php b/phpBB/phpbb/captcha/plugins/legacy_wrapper.php index d728a05aba..abb26b34ba 100644 --- a/phpBB/phpbb/captcha/plugins/legacy_wrapper.php +++ b/phpBB/phpbb/captcha/plugins/legacy_wrapper.php @@ -65,7 +65,7 @@ class legacy_wrapper implements plugin_interface return $this->legacy_captcha->has_config(); } - return false; + return ''; } /** diff --git a/phpBB/phpbb/captcha/plugins/turnstile.php b/phpBB/phpbb/captcha/plugins/turnstile.php index bf9ada4831..edd6832159 100644 --- a/phpBB/phpbb/captcha/plugins/turnstile.php +++ b/phpBB/phpbb/captcha/plugins/turnstile.php @@ -272,7 +272,7 @@ class turnstile extends base { foreach ($captcha_vars as $captcha_var => $template_var) { - $var = $this->request->is_set($captcha_var) ? $this->request->variable($captcha_var, '') : $this->config->offsetGet($captcha_var);; + $var = $this->request->is_set($captcha_var) ? $this->request->variable($captcha_var, '') : $this->config->offsetGet($captcha_var); $this->template->assign_var($template_var, $var); }