makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-11 22:08:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

Reduced query number, changed parameter names

Browse source 
git-svn-id: file:///svn/phpbb/trunk@87 89ea8834-ac86-4346-8a33-228a782c2dd0
This commit is contained in:
Paul S. Owen 2001-03-09 14:04:48 +00:00
parent a5173dd59b
commit 68dd148f6c
1 changed files with 174 additions and 175 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

71
phpBB/viewtopic.php
View file

@ -20,36 +20,37 @@
*
*
***************************************************************************/
include('extension.inc');
include('extension.inc');
include('common.'.$phpEx);
$topic_id = $HTTP_GET_VARS[POST_TOPIC_URL];
$is_moderator = 0;
if(!isset($forum_id) || !isset($topic_id))
if(!isset($topic_id))
{
error_die($db, GENERAL_ERROR, "You have reached this page in error, please go back and try again");
}
$sql = "SELECT f.forum_type, f.forum_name, u.username, u.user_id
FROM ".FORUMS_TABLE." f, ".FORUM_MODS_TABLE." fm, ".USERS_TABLE." u
WHERE f.forum_id = '$forum_id'
AND fm.forum_id = '$forum_id'
$sql = "SELECT t.topic_title, t.topic_status, t.topic_replies,
f.forum_type, f.forum_name, f.forum_id, u.username, u.user_id
FROM ".TOPICS_TABLE." t, ".FORUMS_TABLE." f, ".FORUM_MODS_TABLE." fm, ".USERS_TABLE." u
WHERE t.topic_id = '$topic_id'
AND f.forum_id = t.forum_id
AND fm.forum_id = t.forum_id
AND u.user_id = fm.user_id";
if(!$result = $db->sql_query($sql))
{
error_die($db, QUERY_ERROR);
}
//
// Add checking for private forums here
//
if(!$total_rows = $db->sql_numrows($result))
{
error_die($db, GENERAL_ERROR, "The forum you selected does not exist. Please go back and try again.");
}
$forum_row = $db->sql_fetchrowset($result);
$forum_id = $forum_row[0]["forum_id"];
$forum_name = stripslashes($forum_row[0]["forum_name"]);
for($x = 0; $x < $total_rows; $x++)
{
@ -61,38 +62,30 @@ for($x = 0; $x < $total_rows; $x++)
}
}
//
// Add checking for private forums here
//
$page_title = "View Topic - $topic_title";
$topic_title = stripslashes($topic_info[0]["topic_title"]);
$total_replies = $topic_info[0]["topic_replies"] + 1;
$pagetype = "viewtopic";
include('page_header.'.$phpEx);
if(!isset($start))
{
$start = 0;
}
$sql = "SELECT topic_title, topic_status, topic_replies
FROM ".TOPICS_TABLE."
WHERE topic_id = '$topic_id'";
if(!$result = $db->sql_query($sql))
{
error_die($db, QUERY_ERROR);
}
if(!$topic_info = $db->sql_fetchrowset($result))
{
error_die($db, GENERAL_ERROR, "Could not get topic data<br>$sql");
}
$topic_title = stripslashes($topic_info[0]["topic_title"]);
$total_replies = $topic_info[0]["topic_replies"] + 1;
$pagetype = "viewtopic";
$page_title = "View Topic - $topic_title";
include('page_header.'.$phpEx);
$sql = "SELECT u.username, u.user_id, u.user_posts, u.user_from, u.user_website, u.user_icq, u.user_aim, u.user_yim,
u.user_regdate, u.user_msnm, u.user_viewemail, r.rank_title, r.rank_image,
p.post_time, p.post_id, pt.post_text
$sql = "SELECT u.username, u.user_id, u.user_posts, u.user_from, u.user_website, u.user_icq, u.user_aim, u.user_yim, u.user_regdate, u.user_msnm, u.user_viewemail, r.rank_title, r.rank_image, p.post_time, p.post_id, pt.post_text
FROM ".POSTS_TABLE." p
LEFT JOIN ".USERS_TABLE." u ON p.poster_id = u.user_id
LEFT JOIN ".RANKS_TABLE." r ON (u.user_rank = r.rank_id) AND NOT (u.user_posts > r.rank_min AND u.user_posts < r.rank_max)
LEFT JOIN ".RANKS_TABLE." r ON (u.user_rank = r.rank_id)
AND NOT (u.user_posts > r.rank_min AND u.user_posts < r.rank_max)
LEFT JOIN ".POSTS_TEXT_TABLE." pt ON p.post_id = pt.post_id
WHERE p.topic_id = '$topic_id'
ORDER BY p.post_time ASC LIMIT $start, $posts_per_page";
ORDER BY p.post_time ASC
LIMIT $start, $posts_per_page";
if(!$result = $db->sql_query($sql))
{
@ -121,9 +114,9 @@ for($x = 0; $x < $total_posts; $x++)
$profile_img = "<a href=\"profile.$phpEx?mode=viewprofile&user_id=$poster_id\"><img src=\"$image_profile\" alt=\"$l_profileof $poster\" border=\"0\"></a>";
$email_img = ($postrow[$x]["user_viewemail"] == 1) ? "<a href=\"mailto:".$postrow[$x]["user_email"]."\"><img src=\"$image_email\" alt=\"$l_email $poster\" border=\"0\"></a>" : "";
$www_img = ($postrow[$x]["user_website"]) ? "<a href=\"".$postrow[$x]["user_website"]."\"><img src=\"$image_www\" alt=\"$l_viewsite\" border=\"0\"></a>" : "";
if($postrow[$x]["user_icq"])
{
$icq_status_img = "<a href=\"http://wwp.icq.com/".$postrow[$x]["user_icq"]."#pager\"><img src=\"http://online.mirabilis.com/scripts/online.dll?icq=".$postrow[$x]["user_icq"]."&img=5\" alt=\"$l_icqstatus\" border=\"0\"></a>";
$icq_add_img = "<a href=\"http://wwp.icq.com/scripts/search.dll?to=".$postrow[$x]["user_icq"]."\"><img src=\"$image_icq\" alt=\"$l_icq\" border=\"0\"></a>";
}
@ -132,6 +125,7 @@ for($x = 0; $x < $total_posts; $x++)
$icq_status_img = "";
$icq_add_img = "";
}
$aim_img = ($postrow[$x]["user_aim"]) ? "<a href=\"aim:goim?screenname=".$postrow[$x]["user_aim"]."&message=Hello+Are+you+there?\"><img src=\"$image_aim\" border=\"0\"></a>" : "";
$msn_img = ($postrow[$x]["user_msnm"]) ? "<a href=\"profile.$phpEx?mode=viewprofile&user_id=$poster_id\"><img src=\"$image_msn\" border=\"0\"></a>" : "";
$yim_img = ($postrow[$x]["user_yim"]) ? "<a href=\"http://edit.yahoo.com/config/send_webmesg?.target=".$postrow[$x]["user_yim"]."&.src=pg\"><img src=\"$image_yim\" border=\"0\"></a>" : "";
@ -139,6 +133,7 @@ for($x = 0; $x < $total_posts; $x++)
$edit_img = "<a href=\"posting.$phpEx?mode=editpost&post_id=".$postrow[$x]["post_id"]."&topic_id=$topic_id&forum_id=$forum_id\"><img src=\"$image_edit\" alt=\"$l_editdelete\" border=\"0\"></a>";
$quote_img = "<a href=\"posting.$phpEx?mode=reply&quote=true&post_id=".$postrow[$x]["post_id"]."&topic_id=$topic_id&forum_id=$forum_id\"><img src=\"$image_quote\" alt=\"$l_replyquote\" border=\"0\"></a>";
$pmsg_img = "<a href=\"priv_msgs.$phpEx?mode=send\"><img src=\"$image_pmsg\" alt=\"$l_sendpmsg\" border=\"0\"></a>";
if($is_moderator)
{
$ip_img = "<a href=\"topicadmin.$phpEx?mode=viewip&user_id=".$poster_id."\"><img src=\"$image_ip\" alt=\"$l_viewip\" border=\"0\"></a>";
@ -146,6 +141,7 @@ for($x = 0; $x < $total_posts; $x++)
}
$message = stripslashes($postrow[$x]["post_text"]);
if(!$allow_html)
{
$message = strip_tags($message);
@ -211,6 +207,7 @@ if($total_replies > $posts_per_page)
{
$pagination .= "<a href=\"$PHP_SELF?topic_id=$topic_id&forum_id=$forum_id&start=$last_page\">$l_prevpage</a> ";
}
for($x = 0; $x < $total_replies; $x += $posts_per_page)
{
if($times != 1)
@ -231,6 +228,7 @@ if($total_replies > $posts_per_page)
}
$times++;
}
if(($start + $posts_per_page) < $total_replies)
{
$next_page = $start + $posts_per_page;
@ -244,6 +242,7 @@ else
}
$template->set_var(array("PAGES" => $pages,
"PAGINATION" => $pagination));
$template->pparse("output", array("posts", "body"));
include('page_tail.'.$phpEx);