[ticket/11150] Implement install extension link in ACP

PHPBB3-11150

phpBB/adm/style/acp_ext_gallery.html

@@ -45,7 +45,7 @@
 		<tr>
 			<td>
 				<strong>{{ extension.name }}</strong><br />
-				<span><a href="{{ extension.url }}">{{ lang('DETAILS') }}</a> &bull; <a href="">{{ lang('INSTALL') }}</a></span>
+				<span><a href="{{ extension.url }}">{{ lang('DETAILS') }}</a> &bull; <a href="{{ U_ACTION }}&amp;action=install&amp;extension={{ extension.composer_name|url_encode }}">{{ lang('INSTALL') }}</a></span>
 			</td>
 			<td>{{ extension.version }}</td>
 			<td>{{ extension.description }}</td>

phpBB/includes/acp/acp_extensions.php

@@ -405,14 +405,56 @@ class acp_extensions
 	{
 		global $phpbb_container;
 
-		/** @var \phpbb\composer\extension_manager $manager */
+		$action = $this->request->variable('action', 'list');
-		$manager = $phpbb_container->get('ext.composer.manager');
-		$this->page_title = 'ACP_EXTENSIONS_GALLERY';
-		$this->tpl_name = 'acp_ext_gallery';
 
-		$this->request->enable_super_globals();
+		/** @var \phpbb\language\language $language */
-		$this->template->assign_var('extensions', $manager->get_available_packages());
+		$language = $phpbb_container->get('language');
-		$this->request->disable_super_globals();
+
+		/** @var \phpbb\composer\manager $composer_manager */
+		$composer_manager = $phpbb_container->get('ext.composer.manager');
+
+		switch ($action)
+		{
+			case 'install':
+				$extension = $this->request->variable('extension', '');
+
+				if (empty($extension))
+				{
+					redirect($this->u_action);
+				}
+
+				$formatter = new \Composer\Console\HtmlOutputFormatter([
+					'warning' => new \Symfony\Component\Console\Formatter\OutputFormatterStyle('black', 'yellow')
+				]);
+
+				$composer_io = new \phpbb\composer\io\web_io($language, '', \Symfony\Component\Console\Output\OutputInterface::VERBOSITY_NORMAL, $formatter);
+
+				try
+				{
+					$composer_manager->install((array) $extension, $composer_io);
+				}
+				catch (\phpbb\exception\runtime_exception $e)
+				{
+					trigger_error($language->lang_array($e->getMessage(), $e->get_parameters()) . '<br /><br />' . $composer_io->getOutput() . adm_back_link($this->u_action), E_USER_WARNING);
+				}
+
+				trigger_error($language->lang('EXTENSIONS_INSTALLED') . '<br /><br />' . $composer_io->getOutput() . adm_back_link($this->u_action));
+
+				break;
+			case 'remove':
+				break;
+			case 'list':
+			default:
+				/** @var \phpbb\composer\extension_manager $manager */
+				$manager = $phpbb_container->get('ext.composer.manager');
+				$this->page_title = 'ACP_EXTENSIONS_GALLERY';
+				$this->tpl_name = 'acp_ext_gallery';
+
+				$this->request->enable_super_globals();
+				$this->template->assign_var('extensions', $manager->get_available_packages());
+				$this->request->disable_super_globals();
+				break;
+		}
 	}
 
 	/**

phpBB/phpbb/composer/installer.php

@@ -119,7 +119,7 @@ class installer
 			->setDumpAutoloader(false)
 			->setPreferStable(true)
 			->setRunScripts(false)
-			->setDryRun(false);
+			->setDryRun(true);
 
 		try
 		{
@@ -282,6 +282,7 @@ class installer
 				// Generates the entry
 				$available[$name] = [];
 				$available[$name]['name'] = $highest_version->getPrettyName();
+				$available[$name]['composer_name'] = $highest_version->getName();
 				$available[$name]['version'] = $highest_version->getPrettyVersion();
 
 				if ($version instanceof CompletePackage)

phpBB/phpbb/composer/io/console_io.php

@@ -29,6 +29,7 @@ class console_io extends ConsoleIO
 	 * @param InputInterface	$input		The input instance
 	 * @param OutputInterface	$output		The output instance
 	 * @param HelperSet			$helperSet	The helperSet instance
+	 * @param language			$language	Language object
 	 */
 	public function __construct(InputInterface $input, OutputInterface $output, HelperSet $helperSet, language $language)
 	{

phpBB/phpbb/composer/io/web_io.php

@@ -15,25 +15,23 @@ namespace phpbb\composer\io;
 
 use Composer\IO\BufferIO;
 use phpbb\language\language;
-use Symfony\Component\Console\Helper\HelperSet;
+use Symfony\Component\Console\Formatter\OutputFormatterInterface;
-use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\StreamOutput;
-use Symfony\Component\Console\Output\OutputInterface;
 
 class web_io extends BufferIO
 {
 	use translate_composer_trait;
 
 	/**
-	 * Constructor.
+	 * @param language					$language	Language object
-	 *
+	 * @param string					$input		Input string
-	 * @param InputInterface	$input		The input instance
+	 * @param int						$verbosity	Verbosity level
-	 * @param OutputInterface	$output		The output instance
+	 * @param OutputFormatterInterface	$formatter	Output formatter
-	 * @param HelperSet			$helperSet	The helperSet instance
 	 */
-	public function __construct(InputInterface $input, OutputInterface $output, HelperSet $helperSet, language $language)
+	public function __construct(language $language, $input = '', $verbosity = StreamOutput::VERBOSITY_NORMAL, OutputFormatterInterface $formatter = null)
 	{
 		$this->language = $language;
 
-		parent::__construct($input, $output, $helperSet);
+		parent::__construct($input, $verbosity, $formatter);
 	}
 }