makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 22:28:51 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge branch '3.2.x'

Browse source 
* 3.2.x:
  [ticket/14132] Use transaction for adding notifications to type table
  [ticket/14519] Skip query if all unread notifications are retrieved
  [ticket/14483] Do not send headers by default on access via controller
This commit is contained in:
Máté Bartus 2016-03-08 22:19:54 +01:00
commit 6c814ef641
3 changed files with 26 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
phpBB/includes/functions.php
View file

@ -4071,7 +4071,7 @@ function phpbb_get_avatar($row, $alt, $ignore_config = false, $lazy = false)
/** /**
* Generate page header * Generate page header
*/ */
function page_header($page_title = '', $display_online_list = false, $item_id = 0, $item = 'forum') function page_header($page_title = '', $display_online_list = false, $item_id = 0, $item = 'forum', $send_headers = true)
{ {
global $db, $config, $template, $SID, $_SID, $_EXTRA_URL, $user, $auth, $phpEx, $phpbb_root_path; global $db, $config, $template, $SID, $_SID, $_EXTRA_URL, $user, $auth, $phpEx, $phpbb_root_path;
global $phpbb_dispatcher, $request, $phpbb_container, $phpbb_admin_path; global $phpbb_dispatcher, $request, $phpbb_container, $phpbb_admin_path;
@ -4416,17 +4416,22 @@ function page_header($page_title = '', $display_online_list = false, $item_id =
'SITE_LOGO_IMG' => $user->img('site_logo'), 'SITE_LOGO_IMG' => $user->img('site_logo'),
)); ));
// An array of http headers that phpbb will set. The following event may override these. $http_headers = array();
$http_headers = array(
// application/xhtml+xml not used because of IE if ($send_headers)
'Content-type' => 'text/html; charset=UTF-8',
'Cache-Control' => 'private, no-cache="set-cookie"',
'Expires' => gmdate('D, d M Y H:i:s', time()) . ' GMT',
);
if (!empty($user->data['is_bot']))
{ {
// Let reverse proxies know we detected a bot. // An array of http headers that phpbb will set. The following event may override these.
$http_headers['X-PHPBB-IS-BOT'] = 'yes'; $http_headers += array(
// application/xhtml+xml not used because of IE
'Content-type' => 'text/html; charset=UTF-8',
'Cache-Control' => 'private, no-cache="set-cookie"',
'Expires' => gmdate('D, d M Y H:i:s', time()) . ' GMT',
);
if (!empty($user->data['is_bot']))
{
// Let reverse proxies know we detected a bot.
$http_headers['X-PHPBB-IS-BOT'] = 'yes';
}
} }
/** /**

9
phpBB/phpbb/controller/helper.php
View file

@ -80,12 +80,13 @@ class helper
* @param bool $display_online_list Do we display online users list * @param bool $display_online_list Do we display online users list
* @param int $item_id Restrict online users to item id * @param int $item_id Restrict online users to item id
* @param string $item Restrict online users to a certain session item, e.g. forum for session_forum_id * @param string $item Restrict online users to a certain session item, e.g. forum for session_forum_id
* @param bool $send_headers Whether headers should be sent by page_header(). Defaults to false for controllers.
* *
* @return Response object containing rendered page * @return Response object containing rendered page
*/ */
public function render($template_file, $page_title = '', $status_code = 200, $display_online_list = false, $item_id = 0, $item = 'forum') public function render($template_file, $page_title = '', $status_code = 200, $display_online_list = false, $item_id = 0, $item = 'forum', $send_headers = false)
{ {
page_header($page_title, $display_online_list, $item_id, $item); page_header($page_title, $display_online_list, $item_id, $item, $send_headers);
$this->template->set_filenames(array( $this->template->set_filenames(array(
'body' => $template_file, 'body' => $template_file,
@ -93,7 +94,9 @@ class helper
page_footer(true, false, false); page_footer(true, false, false);
return new Response($this->template->assign_display('body'), $status_code); $headers = !empty($this->user->data['is_bot']) ? array('X-PHPBB-IS-BOT' => 'yes') : array();
return new Response($this->template->assign_display('body'), $status_code, $headers);
} }
/** /**

4
phpBB/phpbb/notification/manager.php
View file

@ -899,6 +899,8 @@ class manager
{ {
$notification_type_ids = $this->cache->get('notification_type_ids'); $notification_type_ids = $this->cache->get('notification_type_ids');
$this->db->sql_transaction('begin');
if ($notification_type_ids === false) if ($notification_type_ids === false)
{ {
$notification_type_ids = array(); $notification_type_ids = array();
@ -933,6 +935,8 @@ class manager
$this->cache->put('notification_type_ids', $notification_type_ids); $this->cache->put('notification_type_ids', $notification_type_ids);
} }
$this->db->sql_transaction('commit');
return $notification_type_ids[$notification_type_name]; return $notification_type_ids[$notification_type_name];
} }