Merge pull request #1367 from EXreaction/ticket/11454

Ticket/11454 - Jabber notifications are not working at all

phpBB/includes/acp/acp_inactive.php

@@ -115,7 +115,7 @@ class acp_inactive
 							{
 								$messenger->template('admin_welcome_activated', $row['user_lang']);
 
-								$messenger->to($row['user_email'], $row['username']);
+								$messenger->set_addresses($row);
 
 								$messenger->anti_abuse_headers($config, $user);
 
@@ -203,8 +203,7 @@ class acp_inactive
 						{
 							$messenger->template('user_remind_inactive', $row['user_lang']);
 
-							$messenger->to($row['user_email'], $row['username']);
+							$messenger->set_addresses($row);
-							$messenger->im($row['user_jabber'], $row['username']);
 
 							$messenger->anti_abuse_headers($config, $user);
 

phpBB/includes/acp/acp_users.php

@@ -347,7 +347,7 @@ class acp_users
 
 								$messenger->template($email_template, $user_row['user_lang']);
 
-								$messenger->to($user_row['user_email'], $user_row['username']);
+								$messenger->set_addresses($user_row);
 
 								$messenger->anti_abuse_headers($config, $user);
 
@@ -402,7 +402,7 @@ class acp_users
 
 									$messenger->template('admin_welcome_activated', $user_row['user_lang']);
 
-									$messenger->to($user_row['user_email'], $user_row['username']);
+									$messenger->set_addresses($user_row);
 
 									$messenger->anti_abuse_headers($config, $user);
 

phpBB/includes/functions_messenger.php

@@ -56,6 +56,24 @@ class messenger
 		$this->mail_priority = MAIL_NORMAL_PRIORITY;
 	}
 	
+	/**
+	* Set addresses for to/im as available
+	* 
+	* @param array $user User row
+	*/
+	function set_addresses($user)
+	{
+		if (isset($user['user_email']) && $user['user_email'])
+		{
+			$this->to($user['user_email'], (isset($user['username']) ? $user['username'] : ''));
+		}
+
+		if (isset($user['user_jabber']) && $user['user_jabber'])
+		{
+			$this->im($user['user_jabber'], (isset($user['username']) ? $user['username'] : ''));
+		}
+	}
+
 	/**
 	* Sets an email address to send to
 	*/

phpBB/includes/functions_user.php

@@ -2924,8 +2924,7 @@ function group_user_attributes($action, $group_id, $user_id_ary = false, $userna
 			{
 				$messenger->template('group_approved', $row['user_lang']);
 
-				$messenger->to($row['user_email'], $row['username']);
+				$messenger->set_addresses($row);
-				$messenger->im($row['user_jabber'], $row['username']);
 
 				$messenger->assign_vars(array(
 					'USERNAME'		=> htmlspecialchars_decode($row['username']),

phpBB/includes/notification/method/jabber.php

@@ -48,7 +48,13 @@ class phpbb_notification_method_jabber extends phpbb_notification_method_messeng
 	*/
 	public function global_available()
 	{
-		return ($this->config['jab_enable'] && @extension_loaded('xml'));
+		return !(
+			empty($this->config['jab_enable']) ||
+			empty($this->config['jab_host']) ||
+			empty($this->config['jab_username']) ||
+			empty($this->config['jab_password']) ||
+			!@extension_loaded('xml')
+		);
 	}
 
 	public function notify()

phpBB/includes/notification/method/messenger_base.php

@@ -80,7 +80,7 @@ abstract class phpbb_notification_method_messenger_base extends phpbb_notificati
 
 			$messenger->template($template_dir_prefix . $notification->get_email_template(), $user['user_lang']);
 
-			$messenger->to($user['user_email'], $user['username']);
+			$messenger->set_addresses($user);
 
 			$messenger->assign_vars(array_merge(array(
 				'USERNAME'						=> $user['username'],

phpBB/includes/ucp/ucp_activate.php

@@ -114,7 +114,7 @@ class ucp_activate
 
 			$messenger->template('admin_welcome_activated', $user_row['user_lang']);
 
-			$messenger->to($user_row['user_email'], $user_row['username']);
+			$messenger->set_addresses($user_row);
 
 			$messenger->anti_abuse_headers($config, $user);
 

phpBB/includes/ucp/ucp_groups.php

@@ -212,8 +212,7 @@ class ucp_groups
 									{
 										$messenger->template('group_request', $row['user_lang']);
 
-										$messenger->to($row['user_email'], $row['username']);
+										$messenger->set_addresses($row);
-										$messenger->im($row['user_jabber'], $row['username']);
 
 										$messenger->assign_vars(array(
 											'USERNAME'			=> htmlspecialchars_decode($row['username']),

phpBB/includes/ucp/ucp_profile.php

@@ -175,8 +175,7 @@ class ucp_profile
 								while ($row = $db->sql_fetchrow($result))
 								{
 									$messenger->template('admin_activate', $row['user_lang']);
-									$messenger->to($row['user_email'], $row['username']);
+									$messenger->set_addresses($row);
-									$messenger->im($row['user_jabber'], $row['username']);
 
 									$messenger->assign_vars(array(
 										'USERNAME'			=> htmlspecialchars_decode($data['username']),

phpBB/includes/ucp/ucp_register.php

@@ -384,8 +384,7 @@ class ucp_register
 						while ($row = $db->sql_fetchrow($result))
 						{
 							$messenger->template('admin_activate', $row['user_lang']);
-							$messenger->to($row['user_email'], $row['username']);
+							$messenger->set_addresses($row);
-							$messenger->im($row['user_jabber'], $row['username']);
 
 							$messenger->assign_vars(array(
 								'USERNAME'			=> htmlspecialchars_decode($data['username']),

phpBB/includes/ucp/ucp_remind.php

@@ -94,8 +94,7 @@ class ucp_remind
 
 			$messenger->template('user_activate_passwd', $user_row['user_lang']);
 
-			$messenger->to($user_row['user_email'], $user_row['username']);
+			$messenger->set_addresses($user_row);
-			$messenger->im($user_row['user_jabber'], $user_row['username']);
 
 			$messenger->assign_vars(array(
 				'USERNAME'		=> htmlspecialchars_decode($user_row['username']),

phpBB/includes/ucp/ucp_resend.php

@@ -91,7 +91,7 @@ class ucp_resend
 			if ($config['require_activation'] == USER_ACTIVATION_SELF || $coppa)
 			{
 				$messenger->template(($coppa) ? 'coppa_resend_inactive' : 'user_resend_inactive', $user_row['user_lang']);
-				$messenger->to($user_row['user_email'], $user_row['username']);
+				$messenger->set_addresses($user_row);
 
 				$messenger->anti_abuse_headers($config, $user);
 
@@ -126,8 +126,7 @@ class ucp_resend
 				while ($row = $db->sql_fetchrow($result))
 				{
 					$messenger->template('admin_activate', $row['user_lang']);
-					$messenger->to($row['user_email'], $row['username']);
+					$messenger->set_addresses($row);
-					$messenger->im($row['user_jabber'], $row['username']);
 
 					$messenger->anti_abuse_headers($config, $user);
 

phpBB/memberlist.php

@@ -376,7 +376,7 @@ switch ($mode)
 						$messenger->subject(htmlspecialchars_decode($subject));
 
 						$messenger->replyto($user->data['user_email']);
-						$messenger->im($row['user_jabber'], $row['username']);
+						$messenger->set_addresses($row);
 
 						$messenger->assign_vars(array(
 							'BOARD_CONTACT'	=> $config['board_contact'],