From 57146ccdd124073d70002b25d8e02868b8201b0a Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Mon, 14 Oct 2013 20:10:00 +0200 Subject: [PATCH 1/2] [ticket/11917] Hide OAuth UCP Module when OAuth is not the selected backend PHPBB3-11917 --- phpBB/includes/functions_module.php | 1 + phpBB/includes/ucp/info/ucp_auth_link.php | 2 +- .../data/v310/auth_provider_oauth2.php | 40 +++++++++++++++++++ 3 files changed, 42 insertions(+), 1 deletion(-) create mode 100644 phpBB/phpbb/db/migration/data/v310/auth_provider_oauth2.php diff --git a/phpBB/includes/functions_module.php b/phpBB/includes/functions_module.php index be066de0f0..98b2848c19 100644 --- a/phpBB/includes/functions_module.php +++ b/phpBB/includes/functions_module.php @@ -398,6 +398,7 @@ class p_master 'cfg_([a-z0-9_]+)' => '(int) $config[\'\\1\']', 'request_([a-zA-Z0-9_]+)' => '$request->variable(\'\\1\', false)', 'ext_([a-zA-Z0-9_/]+)' => 'array_key_exists(\'\\1\', $phpbb_extension_manager->all_enabled())', + 'authmethod_([a-z0-9_\\\\]+)' => '($config[\'auth_method\'] === \'\\1\')', ); /** diff --git a/phpBB/includes/ucp/info/ucp_auth_link.php b/phpBB/includes/ucp/info/ucp_auth_link.php index ee88b15ea8..3a34232d28 100644 --- a/phpBB/includes/ucp/info/ucp_auth_link.php +++ b/phpBB/includes/ucp/info/ucp_auth_link.php @@ -19,7 +19,7 @@ class ucp_auth_link_info 'title' => 'UCP_AUTH_LINK', 'version' => '1.0.0', 'modes' => array( - 'auth_link' => array('title' => 'UCP_AUTH_LINK_MANAGE', 'auth' => '', 'cat' => array('UCP_PROFILE')), + 'auth_link' => array('title' => 'UCP_AUTH_LINK_MANAGE', 'auth' => 'authmethod_oauth', 'cat' => array('UCP_PROFILE')), ), ); } diff --git a/phpBB/phpbb/db/migration/data/v310/auth_provider_oauth2.php b/phpBB/phpbb/db/migration/data/v310/auth_provider_oauth2.php new file mode 100644 index 0000000000..692647dcde --- /dev/null +++ b/phpBB/phpbb/db/migration/data/v310/auth_provider_oauth2.php @@ -0,0 +1,40 @@ +db->sql_query($sql); + } +} From 3d9b5aed46ac1c3aec4b3a068b837169748a429c Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Mon, 14 Oct 2013 20:10:36 +0200 Subject: [PATCH 2/2] [ticket/11917] Move OAuth Module to the bottom while installing PHPBB3-11917 --- phpBB/install/install_install.php | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/phpBB/install/install_install.php b/phpBB/install/install_install.php index c749b54f40..977ce8562c 100644 --- a/phpBB/install/install_install.php +++ b/phpBB/install/install_install.php @@ -1662,6 +1662,18 @@ class install_install extends module $db->sql_freeresult($result); $_module->move_module_by($row, 'move_down', 4); + + // Move OAuth module 5 down... + $sql = 'SELECT * + FROM ' . MODULES_TABLE . " + WHERE module_basename = 'ucp_auth_link' + AND module_class = 'ucp' + AND module_mode = 'auth_link'"; + $result = $db->sql_query($sql); + $row = $db->sql_fetchrow($result); + $db->sql_freeresult($result); + + $_module->move_module_by($row, 'move_down', 5); } // And now for the special ones