makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-10 05:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/11469] Refactor get_three_rows() into get_rows($n).

Browse source 
PHPBB3-11469
This commit is contained in:
Andreas Fischer 2013-03-27 23:53:03 +01:00
parent eacd0f3e7d
commit 6f946e2188
1 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
tests/dbal/sql_insert_buffer_test.php
View file

@ -90,7 +90,7 @@ class phpbb_dbal_sql_insert_buffer_test extends phpbb_database_test_case
{ {
$this->db->multi_insert = false; $this->db->multi_insert = false;
$this->assertTrue($this->buffer->insert_all($this->get_three_rows())); $this->assertTrue($this->buffer->insert_all($this->get_rows(3)));
$this->assert_config_count(5); $this->assert_config_count(5);
} }
@ -102,7 +102,7 @@ class phpbb_dbal_sql_insert_buffer_test extends phpbb_database_test_case
$this->markTestSkipped('Database does not support multi_insert'); $this->markTestSkipped('Database does not support multi_insert');
} }
$this->assertTrue($this->buffer->insert_all($this->get_three_rows())); $this->assertTrue($this->buffer->insert_all($this->get_rows(3)));
$this->assert_config_count(4); $this->assert_config_count(4);
@ -130,12 +130,13 @@ class phpbb_dbal_sql_insert_buffer_test extends phpbb_database_test_case
); );
} }
protected function get_three_rows() protected function get_rows($n)
{ {
return array( $result = array();
$this->get_row(1), for ($i = 0; $i < $n; ++$i)
$this->get_row(2), {
$this->get_row(3), $result[] = $this->get_row($i);
); }
return $result;
} }
} }