From 511f2e04350e08ba1412a92e86427ed97775e1f4 Mon Sep 17 00:00:00 2001 From: Oleg Pudeyev Date: Mon, 5 Sep 2011 02:07:44 -0400 Subject: [PATCH] [ticket/10355] Correctly end output buffering in template tests. This code was copied verbatim from develop-olympus. PHPBB3-10355 --- tests/template/template_test_case.php | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/tests/template/template_test_case.php b/tests/template/template_test_case.php index e475e4012f..7cf995f194 100644 --- a/tests/template/template_test_case.php +++ b/tests/template/template_test_case.php @@ -21,8 +21,22 @@ class phpbb_template_template_test_case extends phpbb_test_case protected function display($handle) { ob_start(); - $this->assertTrue($this->template->display($handle)); - return self::trim_template_result(ob_get_clean()); + + try + { + $this->assertTrue($this->template->display($handle, false)); + } + catch (Exception $exception) + { + // reset output buffering even when an error occured + // PHPUnit turns trigger_error into exceptions as well + ob_end_clean(); + throw $exception; + } + + $result = self::trim_template_result(ob_get_clean()); + + return $result; } protected static function trim_template_result($result)