[ticket/17092] Clean up docblock and remove redundant check

PHPBB3-17092
This commit is contained in:
Marc Alexander 2023-01-17 20:44:05 +01:00
parent 17f2d6e03a
commit 738dd786ba
No known key found for this signature in database
GPG key ID: 50E0D2423696F995

View file

@ -1355,7 +1355,7 @@ class session
* @param string $dnsbl the blacklist to check against * @param string $dnsbl the blacklist to check against
* @param string|false $ip the IPv4 address to check * @param string|false $ip the IPv4 address to check
* *
* @return true if listed in spamhaus database * @return bool true if listed in spamhaus database, false if not
*/ */
function check_dnsbl_spamhaus($dnsbl, $ip = false) function check_dnsbl_spamhaus($dnsbl, $ip = false)
{ {
@ -1378,7 +1378,7 @@ class session
$reverse_ip = $quads[3] . '.' . $quads[2] . '.' . $quads[1] . '.' . $quads[0]; $reverse_ip = $quads[3] . '.' . $quads[2] . '.' . $quads[1] . '.' . $quads[0];
$records = dns_get_record($reverse_ip . '.' . $dnsbl . '.', DNS_A); $records = dns_get_record($reverse_ip . '.' . $dnsbl . '.', DNS_A);
if ($records === false || empty($records)) if (empty($records))
{ {
return false; return false;
} }
@ -1423,7 +1423,7 @@ class session
* @param string $dnsbl the blacklist to check against * @param string $dnsbl the blacklist to check against
* @param string|false $ip the IPv4 address to check * @param string|false $ip the IPv4 address to check
* *
* @return true if record is returned * @return bool true if record is returned, false if not
*/ */
function check_dnsbl_ipv4_generic($dnsbl, $ip = false) function check_dnsbl_ipv4_generic($dnsbl, $ip = false)
{ {