From 471a773bcf73d95c8c875070de459397292113bd Mon Sep 17 00:00:00 2001 From: lavigor Date: Sun, 26 Jun 2016 14:29:45 +0300 Subject: [PATCH 1/2] [ticket/14696] Fix email template test for '0' username PHPBB3-14696 --- tests/email/email_parsing_test.php | 39 ++++++++++++++++++++---------- 1 file changed, 26 insertions(+), 13 deletions(-) diff --git a/tests/email/email_parsing_test.php b/tests/email/email_parsing_test.php index 8def27c945..4f962c9c29 100644 --- a/tests/email/email_parsing_test.php +++ b/tests/email/email_parsing_test.php @@ -19,7 +19,7 @@ class phpbb_email_parsing_test extends phpbb_test_case public function setUp() { - global $phpbb_container, $config, $phpbb_root_path, $phpEx, $request, $user; + global $phpbb_container, $config, $phpbb_root_path, $phpEx, $request, $user; $phpbb_container = new phpbb_mock_container_builder; @@ -73,7 +73,8 @@ class phpbb_email_parsing_test extends phpbb_test_case $phpbb_container->set('ext.manager', $extension_manager, phpbb_mock_container_builder::SCOPE_PROTOTYPE); $context = new \phpbb\template\context(); - $phpbb_container->set('template.twig.extensions.collection', array(new \phpbb\template\twig\extension($context, $user)), phpbb_mock_container_builder::SCOPE_PROTOTYPE); + $twig_extension = new \phpbb\template\twig\extension($context, $user); + $phpbb_container->set('template.twig.extensions.collection', array($twig_extension), phpbb_mock_container_builder::SCOPE_PROTOTYPE); $twig = new \phpbb\template\twig\environment( $config, @@ -89,13 +90,14 @@ class phpbb_email_parsing_test extends phpbb_test_case 'autoescape' => false, ) ); + $twig->addExtension($twig_extension); $phpbb_container->set('template.twig.lexer', new \phpbb\template\twig\lexer($twig), phpbb_mock_container_builder::SCOPE_PROTOTYPE); if (!class_exists('messenger')) { include($phpbb_root_path . 'includes/functions_messenger.' . $phpEx); } - + $this->messenger = new \messenger(); $reflection = new ReflectionObject($this->messenger); @@ -103,9 +105,20 @@ class phpbb_email_parsing_test extends phpbb_test_case $this->reflection_template_property->setAccessible(true); } - public function test_email_parsing() + public function email_parsing_data() { - global $phpbb_container, $config, $phpbb_root_path, $phpEx, $user, $request; + return array( + array('Author username', 'Any forum', 'The topic title', 'Dear user'), + array('0', 'Any forum', 'The topic title', 'Dear user'), + ); + } + + /** + * @dataProvider email_parsing_data + */ + public function test_email_parsing($author_name, $forum_name, $topic_title, $username) + { + global $config, $phpEx, $user; $this->messenger->set_addresses($user->data); @@ -113,10 +126,10 @@ class phpbb_email_parsing_test extends phpbb_test_case 'EMAIL_SIG' => str_replace('
', "\n", "-- \n" . htmlspecialchars_decode($config['board_email_sig'])), 'SITENAME' => htmlspecialchars_decode($config['sitename']), - 'AUTHOR_NAME' => 'Author username', - 'FORUM_NAME' => 'Any forum', - 'TOPIC_TITLE' => 'The topic title', - 'USERNAME' => 'Dear user', + 'AUTHOR_NAME' => $author_name, + 'FORUM_NAME' => $forum_name, + 'TOPIC_TITLE' => $topic_title, + 'USERNAME' => $username, 'U_FORUM' => generate_board_url() . "/viewforum.{$phpEx}?f=1", 'U_STOP_WATCHING_FORUM' => generate_board_url() . "/viewforum.{$phpEx}?uid=2&f=1&unwatch=forum", @@ -126,10 +139,10 @@ class phpbb_email_parsing_test extends phpbb_test_case $reflection_template = $this->reflection_template_property->getValue($this->messenger); $msg = trim($reflection_template->assign_display('body')); - $this->assertContains('Author username', $msg); - $this->assertContains('Any forum', $msg); - $this->assertContains('The topic title', $msg); - $this->assertContains('Dear user', $msg); + $this->assertContains($author_name, $msg); + $this->assertContains($forum_name, $msg); + $this->assertContains($topic_title, $msg); + $this->assertContains($username, $msg); $this->assertContains(htmlspecialchars_decode($config['sitename']), $msg); $this->assertContains(str_replace('
', "\n", "-- \n" . htmlspecialchars_decode($config['board_email_sig'])), $msg); $this->assertNotContains('EMAIL_SIG', $msg); From 27f16a195ec1c83860cbf0b8c9fa1e6f9f3d3f5e Mon Sep 17 00:00:00 2001 From: lavigor Date: Sun, 26 Jun 2016 16:05:08 +0300 Subject: [PATCH 2/2] [ticket/14696] Be perfect PHPBB3-14696 --- tests/email/email_parsing_test.php | 40 ++++++++++++++---------------- 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/tests/email/email_parsing_test.php b/tests/email/email_parsing_test.php index 4f962c9c29..351a38514f 100644 --- a/tests/email/email_parsing_test.php +++ b/tests/email/email_parsing_test.php @@ -13,8 +13,10 @@ class phpbb_email_parsing_test extends phpbb_test_case { - static protected $reflection; + /** @var \messenger */ protected $messenger; + + /** @var \ReflectionProperty */ protected $reflection_template_property; public function setUp() @@ -23,20 +25,12 @@ class phpbb_email_parsing_test extends phpbb_test_case $phpbb_container = new phpbb_mock_container_builder; - $config = new \phpbb\config\config(array()); - $default_config = array( + $config = new \phpbb\config\config(array( 'board_email_sig' => '-- Thanks, The Management', 'sitename' => 'yourdomain.com', 'default_lang' => 'en', - ); - foreach ($default_config as $config_name => $config_value) - { - if (!isset($config[$config_name])) - { - $config[$config_name] = $config_value; - } - } - $phpbb_container->set('config', $config, phpbb_mock_container_builder::SCOPE_PROTOTYPE); + )); + $phpbb_container->set('config', $config); $request = new phpbb_mock_request; $symfony_request = new \phpbb\symfony_request( @@ -50,16 +44,16 @@ class phpbb_email_parsing_test extends phpbb_test_case $phpbb_root_path, $phpEx ); - $phpbb_container->set('path_helper', $phpbb_path_helper, phpbb_mock_container_builder::SCOPE_PROTOTYPE); - $phpbb_container->set('filesystem', $filesystem, phpbb_mock_container_builder::SCOPE_PROTOTYPE); + $phpbb_container->set('path_helper', $phpbb_path_helper); + $phpbb_container->set('filesystem', $filesystem); - $cache_path = 'cache/' . PHPBB_ENVIRONMENT . '/twig'; - $phpbb_container->setParameter('core.template.cache_path', $cache_path, phpbb_mock_container_builder::SCOPE_PROTOTYPE); + $cache_path = $phpbb_root_path . 'cache/' . PHPBB_ENVIRONMENT . '/twig'; + $phpbb_container->setParameter('core.template.cache_path', $cache_path); $lang_loader = new \phpbb\language\language_file_loader($phpbb_root_path, $phpEx); $lang = new \phpbb\language\language($lang_loader); $user = new \phpbb\user($lang, '\phpbb\datetime'); - $phpbb_container->set('user', $user, phpbb_mock_container_builder::SCOPE_PROTOTYPE); + $phpbb_container->set('user', $user); $extension_manager = new phpbb_mock_extension_manager( dirname(__FILE__) . '/', array( @@ -70,11 +64,15 @@ class phpbb_email_parsing_test extends phpbb_test_case ), ) ); - $phpbb_container->set('ext.manager', $extension_manager, phpbb_mock_container_builder::SCOPE_PROTOTYPE); + $phpbb_container->set('ext.manager', $extension_manager); $context = new \phpbb\template\context(); - $twig_extension = new \phpbb\template\twig\extension($context, $user); - $phpbb_container->set('template.twig.extensions.collection', array($twig_extension), phpbb_mock_container_builder::SCOPE_PROTOTYPE); + $twig_extension = new \phpbb\template\twig\extension($context, $lang); + $phpbb_container->set('template.twig.extensions.phpbb', $twig_extension); + + $twig_extensions_collection = new \phpbb\di\service_collection($phpbb_container); + $twig_extensions_collection->add('template.twig.extensions.phpbb'); + $phpbb_container->set('template.twig.extensions.collection', $twig_extensions_collection); $twig = new \phpbb\template\twig\environment( $config, @@ -91,7 +89,7 @@ class phpbb_email_parsing_test extends phpbb_test_case ) ); $twig->addExtension($twig_extension); - $phpbb_container->set('template.twig.lexer', new \phpbb\template\twig\lexer($twig), phpbb_mock_container_builder::SCOPE_PROTOTYPE); + $phpbb_container->set('template.twig.lexer', new \phpbb\template\twig\lexer($twig)); if (!class_exists('messenger')) {