[ticket/10729] Add tests for user posts, reports and attachments

PHPBB3-10729
This commit is contained in:
Joas Schilling 2014-09-22 00:55:34 +02:00
parent d48e4b680e
commit 74854ac65d
2 changed files with 645 additions and 0 deletions

View file

@ -0,0 +1,401 @@
<?php
/**
*
* @package testing
* @copyright (c) 2014 phpBB Group
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
*
*/
require_once dirname(__FILE__) . '/../../phpBB/includes/functions.php';
require_once dirname(__FILE__) . '/../../phpBB/includes/functions_user.php';
require_once dirname(__FILE__) . '/../../phpBB/includes/utf/utf_tools.php';
class phpbb_functions_user_delete_user_test extends phpbb_database_test_case
{
/** @var \dbal */
protected $db;
public function getDataSet()
{
return $this->createXMLDataSet(dirname(__FILE__).'/fixtures/delete_user.xml');
}
protected function setUp()
{
parent::setUp();
global $cache, $config, $db;
$db = $this->db = $this->new_dbal();
$config = array(
'load_online_time' => 5,
'search_type' => 'fulltext_mysql',
);
$cache = $this->getMock('cache');
}
public function first_last_post_data()
{
return array(
array(
'retain',
2,
false,
false,
array(
array('post_id' => 1, 'poster_id' => ANONYMOUS, 'post_username' => ''),
array('post_id' => 2, 'poster_id' => ANONYMOUS, 'post_username' => 'Other'),
array('post_id' => 3, 'poster_id' => ANONYMOUS, 'post_username' => ''),
array('post_id' => 4, 'poster_id' => ANONYMOUS, 'post_username' => 'Other'),
),
array(
array(
'topic_id' => 1,
'topic_poster' => ANONYMOUS, 'topic_first_poster_name' => '', 'topic_first_poster_colour' => '',
'topic_last_poster_id' => ANONYMOUS, 'topic_last_poster_name' => '', 'topic_last_poster_colour' => '',
),
array(
'topic_id' => 2,
'topic_poster' => ANONYMOUS, 'topic_first_poster_name' => 'Other', 'topic_first_poster_colour' => '',
'topic_last_poster_id' => ANONYMOUS, 'topic_last_poster_name' => 'Other', 'topic_last_poster_colour' => '',
),
array(
'topic_id' => 3,
'topic_poster' => ANONYMOUS, 'topic_first_poster_name' => '', 'topic_first_poster_colour' => '',
'topic_last_poster_id' => ANONYMOUS, 'topic_last_poster_name' => '', 'topic_last_poster_colour' => '',
),
array(
'topic_id' => 4,
'topic_poster' => ANONYMOUS, 'topic_first_poster_name' => 'Other', 'topic_first_poster_colour' => '',
'topic_last_poster_id' => ANONYMOUS, 'topic_last_poster_name' => 'Other', 'topic_last_poster_colour' => '',
),
),
array(
array('forum_id' => 1, 'forum_last_poster_id' => ANONYMOUS, 'forum_last_poster_name' => '', 'forum_last_poster_colour' => ''),
array('forum_id' => 2, 'forum_last_poster_id' => ANONYMOUS, 'forum_last_poster_name' => 'Other', 'forum_last_poster_colour' => ''),
array('forum_id' => 3, 'forum_last_poster_id' => ANONYMOUS, 'forum_last_poster_name' => '', 'forum_last_poster_colour' => ''),
array('forum_id' => 4, 'forum_last_poster_id' => ANONYMOUS, 'forum_last_poster_name' => 'Other', 'forum_last_poster_colour' => ''),
),
),
array(
'remove',
2,
false,
false,
array(
array('post_id' => 2, 'poster_id' => ANONYMOUS, 'post_username' => 'Other'),
array('post_id' => 4, 'poster_id' => ANONYMOUS, 'post_username' => 'Other'),
),
array(
array(
'topic_id' => 2,
'topic_poster' => ANONYMOUS, 'topic_first_poster_name' => 'Other', 'topic_first_poster_colour' => '',
'topic_last_poster_id' => ANONYMOUS, 'topic_last_poster_name' => 'Other', 'topic_last_poster_colour' => '',
),
array(
'topic_id' => 4,
'topic_poster' => ANONYMOUS, 'topic_first_poster_name' => 'Other', 'topic_first_poster_colour' => '',
'topic_last_poster_id' => ANONYMOUS, 'topic_last_poster_name' => 'Other', 'topic_last_poster_colour' => '',
),
),
array(
array('forum_id' => 1, 'forum_last_poster_id' => 0, 'forum_last_poster_name' => '', 'forum_last_poster_colour' => ''),
array('forum_id' => 2, 'forum_last_poster_id' => ANONYMOUS, 'forum_last_poster_name' => 'Other', 'forum_last_poster_colour' => ''),
array('forum_id' => 3, 'forum_last_poster_id' => 0, 'forum_last_poster_name' => '', 'forum_last_poster_colour' => ''),
array('forum_id' => 4, 'forum_last_poster_id' => ANONYMOUS, 'forum_last_poster_name' => 'Other', 'forum_last_poster_colour' => ''),
),
),
array(
'retain',
2,
'Bertie',
false,
array(
array('post_id' => 1, 'poster_id' => ANONYMOUS, 'post_username' => 'Bertie'),
array('post_id' => 2, 'poster_id' => ANONYMOUS, 'post_username' => 'Other'),
array('post_id' => 3, 'poster_id' => ANONYMOUS, 'post_username' => 'Bertie'),
array('post_id' => 4, 'poster_id' => ANONYMOUS, 'post_username' => 'Other'),
),
array(
array(
'topic_id' => 1,
'topic_poster' => ANONYMOUS, 'topic_first_poster_name' => 'Bertie', 'topic_first_poster_colour' => '',
'topic_last_poster_id' => ANONYMOUS, 'topic_last_poster_name' => 'Bertie', 'topic_last_poster_colour' => '',
),
array(
'topic_id' => 2,
'topic_poster' => ANONYMOUS, 'topic_first_poster_name' => 'Other', 'topic_first_poster_colour' => '',
'topic_last_poster_id' => ANONYMOUS, 'topic_last_poster_name' => 'Other', 'topic_last_poster_colour' => '',
),
array(
'topic_id' => 3,
'topic_poster' => ANONYMOUS, 'topic_first_poster_name' => 'Bertie', 'topic_first_poster_colour' => '',
'topic_last_poster_id' => ANONYMOUS, 'topic_last_poster_name' => 'Bertie', 'topic_last_poster_colour' => '',
),
array(
'topic_id' => 4,
'topic_poster' => ANONYMOUS, 'topic_first_poster_name' => 'Other', 'topic_first_poster_colour' => '',
'topic_last_poster_id' => ANONYMOUS, 'topic_last_poster_name' => 'Other', 'topic_last_poster_colour' => '',
),
),
array(
array('forum_id' => 1, 'forum_last_poster_id' => ANONYMOUS, 'forum_last_poster_name' => 'Bertie', 'forum_last_poster_colour' => ''),
array('forum_id' => 2, 'forum_last_poster_id' => ANONYMOUS, 'forum_last_poster_name' => 'Other', 'forum_last_poster_colour' => ''),
array('forum_id' => 3, 'forum_last_poster_id' => ANONYMOUS, 'forum_last_poster_name' => 'Bertie', 'forum_last_poster_colour' => ''),
array('forum_id' => 4, 'forum_last_poster_id' => ANONYMOUS, 'forum_last_poster_name' => 'Other', 'forum_last_poster_colour' => ''),
),
),
array(
'remove',
2,
'Bertie',
false,
array(
array('post_id' => 2, 'poster_id' => ANONYMOUS, 'post_username' => 'Other'),
array('post_id' => 4, 'poster_id' => ANONYMOUS, 'post_username' => 'Other'),
),
array(
array(
'topic_id' => 2,
'topic_poster' => ANONYMOUS, 'topic_first_poster_name' => 'Other', 'topic_first_poster_colour' => '',
'topic_last_poster_id' => ANONYMOUS, 'topic_last_poster_name' => 'Other', 'topic_last_poster_colour' => '',
),
array(
'topic_id' => 4,
'topic_poster' => ANONYMOUS, 'topic_first_poster_name' => 'Other', 'topic_first_poster_colour' => '',
'topic_last_poster_id' => ANONYMOUS, 'topic_last_poster_name' => 'Other', 'topic_last_poster_colour' => '',
),
),
array(
array('forum_id' => 1, 'forum_last_poster_id' => 0, 'forum_last_poster_name' => '', 'forum_last_poster_colour' => ''),
array('forum_id' => 2, 'forum_last_poster_id' => ANONYMOUS, 'forum_last_poster_name' => 'Other', 'forum_last_poster_colour' => ''),
array('forum_id' => 3, 'forum_last_poster_id' => 0, 'forum_last_poster_name' => '', 'forum_last_poster_colour' => ''),
array('forum_id' => 4, 'forum_last_poster_id' => ANONYMOUS, 'forum_last_poster_name' => 'Other', 'forum_last_poster_colour' => ''),
),
),
);
}
/**
* @dataProvider first_last_post_data
*/
public function test_first_last_post_info($mode, $user_id, $post_username, $expected, $expected_posts, $expected_topics, $expected_forums)
{
$this->assertEquals($expected, user_delete($mode, $user_id, $post_username));
$sql = 'SELECT post_id, poster_id, post_username
FROM ' . POSTS_TABLE . '
ORDER BY post_id ASC';
$result = $this->db->sql_query($sql);
$this->assertEquals($expected_posts, $this->db->sql_fetchrowset($result));
$this->db->sql_freeresult($result);
$sql = 'SELECT topic_id, topic_poster, topic_first_poster_name, topic_first_poster_colour, topic_last_poster_id, topic_last_poster_name, topic_last_poster_colour
FROM ' . TOPICS_TABLE . '
ORDER BY topic_id ASC';
$result = $this->db->sql_query($sql);
$this->assertEquals($expected_topics, $this->db->sql_fetchrowset($result));
$this->db->sql_freeresult($result);
$sql = 'SELECT forum_id, forum_last_poster_id, forum_last_poster_name, forum_last_poster_colour
FROM ' . FORUMS_TABLE . '
ORDER BY forum_id ASC';
$result = $this->db->sql_query($sql);
$this->assertEquals($expected_forums, $this->db->sql_fetchrowset($result));
$this->db->sql_freeresult($result);
}
public function report_attachment_data()
{
return array(
array(
'retain',
2,
false,
false,
array(
array('post_id' => 1, 'post_reported' => 1, 'post_edit_user' => 1),
array('post_id' => 2, 'post_reported' => 1, 'post_edit_user' => 1),
array('post_id' => 3, 'post_reported' => 0, 'post_edit_user' => 1),
array('post_id' => 4, 'post_reported' => 0, 'post_edit_user' => 1),
),
array(
array('report_id' => 1, 'post_id' => 1, 'user_id' => 1),
array('report_id' => 3, 'post_id' => 2, 'user_id' => 1),
),
array(
array('topic_id' => 1, 'topic_reported' => 1),
array('topic_id' => 2, 'topic_reported' => 1),
array('topic_id' => 3, 'topic_reported' => 0),
array('topic_id' => 4, 'topic_reported' => 0),
),
array(
array('attach_id' => 1, 'post_msg_id' => 1, 'poster_id' => 1),
array('attach_id' => 2, 'post_msg_id' => 2, 'poster_id' => 1),
),
),
array(
'remove',
2,
false,
false,
array(
array('post_id' => 2, 'post_reported' => 1, 'post_edit_user' => 1),
array('post_id' => 4, 'post_reported' => 0, 'post_edit_user' => 1),
),
array(
array('report_id' => 3, 'post_id' => 2, 'user_id' => 1),
),
array(
array('topic_id' => 2, 'topic_reported' => 1),
array('topic_id' => 4, 'topic_reported' => 0),
),
array(
array('attach_id' => 1, 'post_msg_id' => 1, 'poster_id' => 2), // TODO should be deleted: PHPBB3-13089
array('attach_id' => 2, 'post_msg_id' => 2, 'poster_id' => 1),
),
),
array(
'retain',
2,
'Bertie',
false,
array(
array('post_id' => 1, 'post_reported' => 1, 'post_edit_user' => 1),
array('post_id' => 2, 'post_reported' => 1, 'post_edit_user' => 1),
array('post_id' => 3, 'post_reported' => 0, 'post_edit_user' => 1),
array('post_id' => 4, 'post_reported' => 0, 'post_edit_user' => 1),
),
array(
array('report_id' => 1, 'post_id' => 1, 'user_id' => 1),
array('report_id' => 3, 'post_id' => 2, 'user_id' => 1),
),
array(
array('topic_id' => 1, 'topic_reported' => 1),
array('topic_id' => 2, 'topic_reported' => 1),
array('topic_id' => 3, 'topic_reported' => 0),
array('topic_id' => 4, 'topic_reported' => 0),
),
array(
array('attach_id' => 1, 'post_msg_id' => 1, 'poster_id' => 1),
array('attach_id' => 2, 'post_msg_id' => 2, 'poster_id' => 1),
),
),
array(
'remove',
2,
'Bertie',
false,
array(
array('post_id' => 2, 'post_reported' => 1, 'post_edit_user' => 1),
array('post_id' => 4, 'post_reported' => 0, 'post_edit_user' => 1),
),
array(
array('report_id' => 3, 'post_id' => 2, 'user_id' => 1),
),
array(
array('topic_id' => 2, 'topic_reported' => 1),
array('topic_id' => 4, 'topic_reported' => 0),
),
array(
array('attach_id' => 1, 'post_msg_id' => 1, 'poster_id' => 2), // TODO should be deleted: PHPBB3-13089
array('attach_id' => 2, 'post_msg_id' => 2, 'poster_id' => 1),
),
),
);
}
/**
* @dataProvider report_attachment_data
*/
public function test_report_attachment_info($mode, $user_id, $post_username, $expected, $expected_posts, $expected_reports, $expected_topics, $expected_attach)
{
$this->assertEquals($expected, user_delete($mode, $user_id, $post_username));
$sql = 'SELECT post_id, post_reported, post_edit_user
FROM ' . POSTS_TABLE . '
ORDER BY post_id ASC';
$result = $this->db->sql_query($sql);
$this->assertEquals($expected_posts, $this->db->sql_fetchrowset($result));
$this->db->sql_freeresult($result);
$sql = 'SELECT report_id, post_id, user_id
FROM ' . REPORTS_TABLE . '
ORDER BY report_id ASC';
$result = $this->db->sql_query($sql);
$this->assertEquals($expected_reports, $this->db->sql_fetchrowset($result));
$this->db->sql_freeresult($result);
$sql = 'SELECT topic_id, topic_reported
FROM ' . TOPICS_TABLE . '
ORDER BY topic_id ASC';
$result = $this->db->sql_query($sql);
$this->assertEquals($expected_topics, $this->db->sql_fetchrowset($result));
$this->db->sql_freeresult($result);
$sql = 'SELECT attach_id, post_msg_id, poster_id
FROM ' . ATTACHMENTS_TABLE . '
ORDER BY attach_id ASC';
$result = $this->db->sql_query($sql);
$this->assertEquals($expected_attach, $this->db->sql_fetchrowset($result));
$this->db->sql_freeresult($result);
}
public function delete_data()
{
return array(
array(
'retain',
2,
false,
false,
array(
array('user_id' => 1, 'user_posts' => 4),
),
),
array(
'remove',
2,
false,
false,
array(
array('user_id' => 1, 'user_posts' => 2),
),
),
array(
'retain',
2,
'Bertie',
false,
array(
array('user_id' => 1, 'user_posts' => 4),
),
),
array(
'remove',
2,
'Bertie',
false,
array(
array('user_id' => 1, 'user_posts' => 2),
),
),
);
}
/**
* @dataProvider delete_data
*/
public function test_delete_data($mode, $user_id, $post_username, $expected, $expected_users)
{
$this->assertEquals($expected, user_delete($mode, $user_id, $post_username));
$sql = 'SELECT user_id, user_posts
FROM ' . USERS_TABLE . '
ORDER BY user_id ASC';
$result = $this->db->sql_query($sql);
$this->assertEquals($expected_users, $this->db->sql_fetchrowset($result));
$this->db->sql_freeresult($result);
}
}

View file

@ -0,0 +1,244 @@
<?xml version="1.0" encoding="UTF-8" ?>
<dataset>
<table name="phpbb_attachments">
<column>attach_id</column>
<column>post_msg_id</column>
<column>topic_id</column>
<column>in_message</column>
<column>poster_id</column>
<column>attach_comment</column>
<row>
<value>1</value>
<value>1</value>
<value>1</value>
<value>1</value>
<value>2</value>
<value></value>
</row>
<row>
<value>2</value>
<value>2</value>
<value>2</value>
<value>1</value>
<value>1</value>
<value></value>
</row>
</table>
<table name="phpbb_forums">
<column>forum_id</column>
<column>forum_last_poster_id</column>
<column>forum_last_poster_name</column>
<column>forum_last_poster_colour</column>
<column>forum_parents</column>
<column>forum_desc</column>
<column>forum_rules</column>
<row>
<value>1</value>
<value>2</value>
<value></value>
<value>00AA00</value>
<value></value>
<value></value>
<value></value>
</row>
<row>
<value>2</value>
<value>1</value>
<value>Other</value>
<value></value>
<value></value>
<value></value>
<value></value>
</row>
<row>
<value>3</value>
<value>2</value>
<value></value>
<value>00AA00</value>
<value></value>
<value></value>
<value></value>
</row>
<row>
<value>4</value>
<value>1</value>
<value>Other</value>
<value></value>
<value></value>
<value></value>
<value></value>
</row>
</table>
<table name="phpbb_posts">
<column>post_id</column>
<column>poster_id</column>
<column>post_edit_user</column>
<column>post_username</column>
<column>topic_id</column>
<column>forum_id</column>
<column>post_approved</column>
<column>post_time</column>
<column>post_text</column>
<column>post_reported</column>
<row>
<value>1</value>
<value>2</value>
<value>2</value>
<value></value>
<value>1</value>
<value>1</value>
<value>1</value>
<value>1</value>
<value></value>
<value>1</value>
</row>
<row>
<value>2</value>
<value>1</value>
<value>1</value>
<value>Other</value>
<value>2</value>
<value>2</value>
<value>1</value>
<value>1</value>
<value></value>
<value>1</value>
</row>
<row>
<value>3</value>
<value>2</value>
<value>2</value>
<value></value>
<value>3</value>
<value>3</value>
<value>1</value>
<value>1</value>
<value></value>
<value>1</value>
</row>
<row>
<value>4</value>
<value>1</value>
<value>1</value>
<value>Other</value>
<value>4</value>
<value>4</value>
<value>1</value>
<value>1</value>
<value></value>
<value>1</value>
</row>
</table>
<table name="phpbb_reports">
<column>report_id</column>
<column>post_id</column>
<column>user_id</column>
<column>report_text</column>
<row>
<value>1</value>
<value>1</value>
<value>1</value>
<value>Post Removed?</value>
</row>
<row>
<value>2</value>
<value>3</value>
<value>2</value>
<value>Post Removed?</value>
</row>
<row>
<value>3</value>
<value>2</value>
<value>1</value>
<value>Keep</value>
</row>
<row>
<value>4</value>
<value>4</value>
<value>2</value>
<value>Remove Report</value>
</row>
</table>
<table name="phpbb_topics">
<column>topic_id</column>
<column>forum_id</column>
<column>topic_reported</column>
<column>topic_poster</column>
<column>topic_first_poster_name</column>
<column>topic_first_poster_colour</column>
<column>topic_last_poster_id</column>
<column>topic_last_poster_name</column>
<column>topic_last_poster_colour</column>
<row>
<value>1</value>
<value>1</value>
<value>1</value>
<value>2</value>
<value></value>
<value>00AA00</value>
<value>2</value>
<value></value>
<value>00AA00</value>
</row>
<row>
<value>2</value>
<value>2</value>
<value>1</value>
<value>1</value>
<value>Other</value>
<value></value>
<value>1</value>
<value>Other</value>
<value></value>
</row>
<row>
<value>3</value>
<value>3</value>
<value>1</value>
<value>2</value>
<value></value>
<value>00AA00</value>
<value>2</value>
<value></value>
<value>00AA00</value>
</row>
<row>
<value>4</value>
<value>4</value>
<value>1</value>
<value>1</value>
<value>Other</value>
<value></value>
<value>1</value>
<value>Other</value>
<value></value>
</row>
</table>
<table name="phpbb_users">
<column>user_id</column>
<column>username_clean</column>
<column>user_permissions</column>
<column>user_sig</column>
<column>user_occ</column>
<column>user_interests</column>
<column>user_posts</column>
<row>
<value>1</value>
<value>Anonymous</value>
<value></value>
<value></value>
<value></value>
<value></value>
<value>2</value>
</row>
<row>
<value>2</value>
<value>Foobar</value>
<value></value>
<value></value>
<value></value>
<value></value>
<value>2</value>
</row>
</table>
</dataset>