makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-09 11:38:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/17525] Add index names test for generated database schema

Browse source 
PHPBB-17525
This commit is contained in:
rxu 2025-06-25 22:24:50 +07:00
parent a229797cd7
commit 75c5fe9459
No known key found for this signature in database
GPG key ID: 955F0567380E586A
2 changed files with 56 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
phpBB/phpbb/db/doctrine/table_helper.php
View file

@ -127,7 +127,7 @@ class table_helper
* Maps short table names for the purpose of prefixing tables' index names. * Maps short table names for the purpose of prefixing tables' index names.
* *
* @param array $additional_tables Additional table names without prefix to add to the map. * @param array $additional_tables Additional table names without prefix to add to the map.
* @param array $table_prefix Tables prefix. * @param string $table_prefix Tables prefix.
* *
* @return array<string, string> Pairs of table names and their short name representations. * @return array<string, string> Pairs of table names and their short name representations.
* @psalm-return array{string, string} * @psalm-return array{string, string}

55
tests/dbal/migrator_test.php
View file

@ -440,4 +440,59 @@ class phpbb_dbal_migrator_test extends phpbb_database_test_case
$this->assertFalse($this->db_tools->sql_table_exists('phpbb_foobar1')); $this->assertFalse($this->db_tools->sql_table_exists('phpbb_foobar1'));
$this->assertFalse($this->db_tools->sql_table_exists('phpbb_foobar2')); $this->assertFalse($this->db_tools->sql_table_exists('phpbb_foobar2'));
} }
public function test_schema_generator(): array
{
global $phpbb_root_path, $phpEx;
$finder_factory = new \phpbb\finder\factory(null, false, $phpbb_root_path, $phpEx);
$finder = $finder_factory->get();
$migrator_classes = $finder->core_path('phpbb/db/migration/data/')->get_classes();
$schema_generator = new \phpbb\db\migration\schema_generator(
$migrator_classes,
$this->config,
$this->db,
$this->db_tools,
$phpbb_root_path,
$phpEx,
'phpbb_',
self::get_core_tables()
);
$db_table_schema = $schema_generator->get_schema();
$this->assertNotEmpty($db_table_schema);
return $db_table_schema;
}
/**
* @depends test_schema_generator
*/
public function test_table_indexes(array $db_table_schema)
{
$table_keys = [];
foreach ($db_table_schema as $table_name => $table_data)
{
if (isset($table_data['KEYS']))
{
foreach ($table_data['KEYS'] as $key_name => $key_data)
{
$table_keys[$table_name][] = $key_name;
}
}
}
$this->assertNotEmpty($table_keys);
$short_table_names = \phpbb\db\doctrine\table_helper::map_short_table_names([], 'phpbb_');
foreach ($table_keys as $table_name => $key_names)
{
$index_prefix = $short_table_names[$table_name] . '_';
foreach ($key_names as $key_name)
{
$this->assertFalse(strpos($key_name, $index_prefix), "$key_name does not contain $index_prefix");
}
}
}
} }