makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 06:08:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/11918] Make sql_freeresult() consistent across all DB drivers

Browse source 
PHPBB3-11918
This commit is contained in:
Patrick Webster 2013-10-14 16:37:23 -05:00
parent 40932c26ea
commit 76ddf1ca41
8 changed files with 11 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
phpBB/phpbb/db/driver/firebird.php
View file

@ -398,7 +398,7 @@ class firebird extends \phpbb\db\driver\driver
$query_id = $this->query_result; $query_id = $this->query_result;
} }
if ($cache && $cache->sql_exists($query_id)) if ($cache && !is_object($query_id) && $cache->sql_exists($query_id))
{ {
return $cache->sql_freeresult($query_id); return $cache->sql_freeresult($query_id);
} }

6
phpBB/phpbb/db/driver/mssql.php
View file

@ -318,14 +318,14 @@ class mssql extends \phpbb\db\driver\driver
$query_id = $this->query_result; $query_id = $this->query_result;
} }
if ($cache && $cache->sql_exists($query_id)) if ($cache && !is_object($query_id) && $cache->sql_exists($query_id))
{ {
return $cache->sql_freeresult($query_id); return $cache->sql_freeresult($query_id);
} }
if (isset($this->open_queries[$query_id])) if (isset($this->open_queries[(int) $query_id]))
{ {
unset($this->open_queries[$query_id]); unset($this->open_queries[(int) $query_id]);
return @mssql_free_result($query_id); return @mssql_free_result($query_id);
} }

2
phpBB/phpbb/db/driver/mssql_odbc.php
View file

@ -305,7 +305,7 @@ class mssql_odbc extends \phpbb\db\driver\mssql_base
$query_id = $this->query_result; $query_id = $this->query_result;
} }
if ($cache && $cache->sql_exists($query_id)) if ($cache && !is_object($query_id) && $cache->sql_exists($query_id))
{ {
return $cache->sql_freeresult($query_id); return $cache->sql_freeresult($query_id);
} }

3
phpBB/phpbb/db/driver/mssqlnative.php
View file

@ -471,7 +471,7 @@ class mssqlnative extends \phpbb\db\driver\mssql_base
$query_id = $this->query_result; $query_id = $this->query_result;
} }
if ($cache->sql_exists($query_id)) if ($cache && !is_object($query_id) && $cache->sql_exists($query_id))
{ {
return $cache->sql_freeresult($query_id); return $cache->sql_freeresult($query_id);
} }
@ -481,6 +481,7 @@ class mssqlnative extends \phpbb\db\driver\mssql_base
unset($this->open_queries[(int) $query_id]); unset($this->open_queries[(int) $query_id]);
return @sqlsrv_free_stmt($query_id); return @sqlsrv_free_stmt($query_id);
} }
return false; return false;
} }

2
phpBB/phpbb/db/driver/mysql.php
View file

@ -289,7 +289,7 @@ class mysql extends \phpbb\db\driver\mysql_base
$query_id = $this->query_result; $query_id = $this->query_result;
} }
if ($cache && $cache->sql_exists($query_id)) if ($cache && !is_object($query_id) && $cache->sql_exists($query_id))
{ {
return $cache->sql_freeresult($query_id); return $cache->sql_freeresult($query_id);
} }

2
phpBB/phpbb/db/driver/oracle.php
View file

@ -621,7 +621,7 @@ class oracle extends \phpbb\db\driver\driver
$query_id = $this->query_result; $query_id = $this->query_result;
} }
if ($cache && $cache->sql_exists($query_id)) if ($cache && !is_object($query_id) && $cache->sql_exists($query_id))
{ {
return $cache->sql_freeresult($query_id); return $cache->sql_freeresult($query_id);
} }

2
phpBB/phpbb/db/driver/postgres.php
View file

@ -350,7 +350,7 @@ class postgres extends \phpbb\db\driver\driver
$query_id = $this->query_result; $query_id = $this->query_result;
} }
if ($cache && $cache->sql_exists($query_id)) if ($cache && !is_object($query_id) && $cache->sql_exists($query_id))
{ {
return $cache->sql_freeresult($query_id); return $cache->sql_freeresult($query_id);
} }

2
phpBB/phpbb/db/driver/sqlite.php
View file

@ -261,7 +261,7 @@ class sqlite extends \phpbb\db\driver\driver
$query_id = $this->query_result; $query_id = $this->query_result;
} }
if ($cache && $cache->sql_exists($query_id)) if ($cache && !is_object($query_id) && $cache->sql_exists($query_id))
{ {
return $cache->sql_freeresult($query_id); return $cache->sql_freeresult($query_id);
} }