[ticket/13740] Fix database test

PHPBB3-13740
This commit is contained in:
Mate Bartus 2015-07-08 18:08:50 +02:00
parent 1c01252b5d
commit 794726a464

View file

@ -18,11 +18,6 @@ class phpbb_installer_database_helper_test extends phpbb_test_case
*/ */
private $database_helper; private $database_helper;
/**
* @var phpbb\db\driver\driver_interface
*/
private $dbms_mock;
public function setUp() public function setUp()
{ {
$filesystem = new \phpbb\filesystem\filesystem(); $filesystem = new \phpbb\filesystem\filesystem();
@ -61,7 +56,7 @@ class phpbb_installer_database_helper_test extends phpbb_test_case
*/ */
public function test_validate_table_prefix($expected, $test_string) public function test_validate_table_prefix($expected, $test_string)
{ {
$this->assertEquals($expected, $this->database_helper->validate_table_prefix('oracle', $test_string)); $this->assertEquals($expected, $this->database_helper->validate_table_prefix('sqlite3', $test_string));
} }
// Data provider for the remove comments function // Data provider for the remove comments function
@ -97,7 +92,7 @@ class phpbb_installer_database_helper_test extends phpbb_test_case
'SELECT * FROM table', 'SELECT * FROM table',
), ),
'abcd "efgh"' . "\n" . 'abcd "efgh"' . "\n" .
'qwerty' . "\n" . 'qwerty;' . "\n" .
'SELECT * FROM table', 'SELECT * FROM table',
';', ';',
), ),
@ -130,9 +125,16 @@ class phpbb_installer_database_helper_test extends phpbb_test_case
), ),
array( array(
array( array(
array('title' => 'INST_ERR_PREFIX_TOO_LONG'), array('title' => array('INST_ERR_PREFIX_TOO_LONG', 200)),
), ),
'php_bb_', 'AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA',
),
array(
array(
array('title' => 'INST_ERR_DB_INVALID_PREFIX'),
array('title' => array('INST_ERR_PREFIX_TOO_LONG', 200)),
),
'_AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA',
), ),
); );
} }