diff --git a/tests/attachment/upload_test.php b/tests/attachment/upload_test.php index c26efd5094..f99d759ba9 100644 --- a/tests/attachment/upload_test.php +++ b/tests/attachment/upload_test.php @@ -81,7 +81,8 @@ class phpbb_attachment_upload_test extends \phpbb_database_test_case $config = $this->config; $this->phpbb_root_path = $phpbb_root_path; $this->db = $this->new_dbal(); - $this->cache = new \phpbb\cache\service(new \phpbb\cache\driver\dummy(), $this->config, $this->db, $phpbb_root_path, $phpEx); + $this->phpbb_dispatcher = new phpbb_mock_event_dispatcher(); + $this->cache = new \phpbb\cache\service(new \phpbb\cache\driver\dummy(), $this->config, $this->db, $this->phpbb_dispatcher, $phpbb_root_path, $phpEx); $this->request = $this->createMock('\phpbb\request\request'); $this->filesystem = new \phpbb\filesystem\filesystem(); @@ -136,7 +137,6 @@ class phpbb_attachment_upload_test extends \phpbb_database_test_case )); $this->factory = new \phpbb\files\factory($this->container); $this->files_upload = new \phpbb\files\upload($this->filesystem, $this->factory, $this->language, $this->php_ini, $this->request, $this->phpbb_root_path); - $this->phpbb_dispatcher = new phpbb_mock_event_dispatcher(); $this->user = new \phpbb\user($this->language, '\phpbb\datetime'); $this->user->data['user_id'] = ANONYMOUS; diff --git a/tests/cache/common_test_case.php b/tests/cache/common_test_case.php index 64273c250a..0fb39d455d 100644 --- a/tests/cache/common_test_case.php +++ b/tests/cache/common_test_case.php @@ -74,7 +74,8 @@ abstract class phpbb_cache_common_test_case extends phpbb_database_test_case global $db, $cache, $phpbb_root_path, $phpEx; $config = new phpbb\config\config(array()); $db = $this->new_dbal(); - $cache = new \phpbb\cache\service($this->driver, $config, $db, $phpbb_root_path, $phpEx); + $phpbb_dispatcher = new phpbb_mock_event_dispatcher(); + $cache = new \phpbb\cache\service($this->driver, $config, $db, $phpbb_dispatcher, $phpbb_root_path, $phpEx); $sql = "SELECT * FROM phpbb_config WHERE config_name = 'foo'"; diff --git a/tests/cache/dummy_driver_test.php b/tests/cache/dummy_driver_test.php index 09d33b0475..101eb3af41 100644 --- a/tests/cache/dummy_driver_test.php +++ b/tests/cache/dummy_driver_test.php @@ -50,7 +50,8 @@ class phpbb_cache_dummy_driver_test extends phpbb_database_test_case global $db, $cache, $phpbb_root_path, $phpEx; $config = new phpbb\config\config(array()); $db = $this->new_dbal(); - $cache = new \phpbb\cache\service($this->driver, $config, $db, $phpbb_root_path, $phpEx); + $phpbb_dispatcher = new phpbb_mock_event_dispatcher(); + $cache = new \phpbb\cache\service($this->driver, $config, $db, $phpbb_dispatcher, $phpbb_root_path, $phpEx); $sql = "SELECT * FROM phpbb_config WHERE config_name = 'foo'"; diff --git a/tests/dbal/migrator_tool_module_test.php b/tests/dbal/migrator_tool_module_test.php index 7d192dfecf..e1d1971658 100644 --- a/tests/dbal/migrator_tool_module_test.php +++ b/tests/dbal/migrator_tool_module_test.php @@ -32,13 +32,13 @@ class phpbb_dbal_migrator_tool_module_test extends phpbb_database_test_case $skip_add_log = true; $db = $this->db = $this->new_dbal(); - $this->cache = new \phpbb\cache\service(new \phpbb\cache\driver\dummy(), new \phpbb\config\config(array()), $this->db, $phpbb_root_path, $phpEx); + $phpbb_dispatcher = new phpbb_mock_event_dispatcher(); + $this->cache = new \phpbb\cache\service(new \phpbb\cache\driver\dummy(), new \phpbb\config\config(array()), $this->db, $phpbb_dispatcher, $phpbb_root_path, $phpEx); $lang_loader = new \phpbb\language\language_file_loader($phpbb_root_path, $phpEx); $lang = new \phpbb\language\language($lang_loader); $user = $this->user = new \phpbb\user($lang, '\phpbb\datetime'); $cache = new phpbb_mock_cache; - $phpbb_dispatcher = new phpbb_mock_event_dispatcher(); $auth = $this->createMock('\phpbb\auth\auth'); $phpbb_log = new \phpbb\log\log($db, $user, $auth, $phpbb_dispatcher, $phpbb_root_path, 'adm/', $phpEx, LOG_TABLE); diff --git a/tests/dbal/migrator_tool_permission_role_test.php b/tests/dbal/migrator_tool_permission_role_test.php index 48e45bf2d5..55bda8c0ce 100644 --- a/tests/dbal/migrator_tool_permission_role_test.php +++ b/tests/dbal/migrator_tool_permission_role_test.php @@ -64,7 +64,8 @@ class phpbb_dbal_migrator_tool_permission_role_test extends phpbb_database_test_ parent::setup(); $db = $this->db = $this->new_dbal(); - $cache = $this->cache = new \phpbb\cache\service(new \phpbb\cache\driver\dummy(), new \phpbb\config\config(array()), $this->db, $phpbb_root_path, $phpEx); + $phpbb_dispatcher = new phpbb_mock_event_dispatcher(); + $cache = $this->cache = new \phpbb\cache\service(new \phpbb\cache\driver\dummy(), new \phpbb\config\config(array()), $this->db, $phpbb_dispatcher, $phpbb_root_path, $phpEx); $this->auth = new \phpbb\auth\auth(); // Initialize this auth_admin instance later after adding new auth options via this->tool->add() diff --git a/tests/dbal/migrator_tool_permission_test.php b/tests/dbal/migrator_tool_permission_test.php index 723eef2f0a..750fbcaa51 100644 --- a/tests/dbal/migrator_tool_permission_test.php +++ b/tests/dbal/migrator_tool_permission_test.php @@ -38,7 +38,8 @@ class phpbb_dbal_migrator_tool_permission_test extends phpbb_database_test_case parent::setup(); $db = $this->db = $this->new_dbal(); - $cache = $this->cache = new \phpbb\cache\service(new \phpbb\cache\driver\dummy(), new \phpbb\config\config(array()), $this->db, $phpbb_root_path, $phpEx); + $phpbb_dispatcher = new phpbb_mock_event_dispatcher(); + $cache = $this->cache = new \phpbb\cache\service(new \phpbb\cache\driver\dummy(), new \phpbb\config\config(array()), $this->db, $phpbb_dispatcher, $phpbb_root_path, $phpEx); $this->auth = new \phpbb\auth\auth(); $this->tool = new \phpbb\db\migration\tool\permission($this->db, $this->cache, $this->auth, $phpbb_root_path, $phpEx); diff --git a/tests/extension/manager_test.php b/tests/extension/manager_test.php index 86e42b1794..41cfe8d366 100644 --- a/tests/extension/manager_test.php +++ b/tests/extension/manager_test.php @@ -155,6 +155,7 @@ class phpbb_extension_manager_test extends phpbb_database_test_case { $config = new \phpbb\config\config(array('version' => PHPBB_VERSION)); $db = $this->new_dbal(); + $phpbb_dispatcher = new phpbb_mock_event_dispatcher(); $factory = new \phpbb\db\tools\factory(); $db_tools = $factory->get($db); $phpbb_root_path = __DIR__ . './../../phpBB/'; @@ -185,7 +186,7 @@ class phpbb_extension_manager_test extends phpbb_database_test_case 'phpbb_ext', __DIR__ . '/', $php_ext, - ($with_cache) ? new \phpbb\cache\service(new phpbb_mock_cache(), $config, $db, $phpbb_root_path, $php_ext) : null + ($with_cache) ? new \phpbb\cache\service(new phpbb_mock_cache(), $config, $db, $phpbb_dispatcher, $phpbb_root_path, $php_ext) : null ); } } diff --git a/tests/extension/metadata_manager_test.php b/tests/extension/metadata_manager_test.php index 682882c3fc..2357d593b5 100644 --- a/tests/extension/metadata_manager_test.php +++ b/tests/extension/metadata_manager_test.php @@ -40,12 +40,13 @@ class phpbb_extension_metadata_manager_test extends phpbb_database_test_case 'version' => '3.1.0', )); $this->db = $this->new_dbal(); + $phpbb_dispatcher = new phpbb_mock_event_dispatcher(); $factory = new \phpbb\db\tools\factory(); $this->db_tools = $factory->get($this->db); $this->phpbb_root_path = __DIR__ . '/'; $this->phpEx = 'php'; - $this->cache = new \phpbb\cache\service(new phpbb_mock_cache(), $this->config, $this->db, $this->phpbb_root_path, $this->phpEx); + $this->cache = new \phpbb\cache\service(new phpbb_mock_cache(), $this->config, $this->db, $phpbb_dispatcher, $this->phpbb_root_path, $this->phpEx); $this->table_prefix = 'phpbb_'; @@ -70,7 +71,7 @@ class phpbb_extension_metadata_manager_test extends phpbb_database_test_case $cache_path, null, $loader, - new \phpbb\event\dispatcher($container), + $phpbb_dispatcher, array( 'cache' => false, 'debug' => false, diff --git a/tests/notification/base.php b/tests/notification/base.php index 980e43ce1e..26e2163e3b 100644 --- a/tests/notification/base.php +++ b/tests/notification/base.php @@ -79,17 +79,17 @@ abstract class phpbb_tests_notification_base extends phpbb_database_test_case $this->user = $user; $this->user_loader = new \phpbb\user_loader($this->db, $phpbb_root_path, $phpEx, 'phpbb_users'); $auth = $this->auth = new phpbb_mock_notifications_auth(); + $this->phpbb_dispatcher = new phpbb_mock_event_dispatcher(); $cache_driver = new \phpbb\cache\driver\dummy(); $cache = $this->cache = new \phpbb\cache\service( $cache_driver, $this->config, $this->db, + $this->phpbb_dispatcher, $phpbb_root_path, $phpEx ); - $this->phpbb_dispatcher = new phpbb_mock_event_dispatcher(); - $phpbb_container = $this->container = new ContainerBuilder(); $loader = new YamlFileLoader($phpbb_container, new FileLocator(__DIR__ . '/fixtures')); $loader->load('services_notification.yml'); diff --git a/tests/notification/notification_method_email_test.php b/tests/notification/notification_method_email_test.php index 63e2dfb343..d778f2159d 100644 --- a/tests/notification/notification_method_email_test.php +++ b/tests/notification/notification_method_email_test.php @@ -58,17 +58,17 @@ class notification_method_email_test extends phpbb_tests_notification_base $this->user = $user; $this->user_loader = new \phpbb\user_loader($this->db, $phpbb_root_path, $phpEx, 'phpbb_users'); $auth = $this->auth = new phpbb_mock_notifications_auth(); + $this->phpbb_dispatcher = new phpbb_mock_event_dispatcher(); $cache_driver = new \phpbb\cache\driver\dummy(); $cache = $this->cache = new \phpbb\cache\service( $cache_driver, $this->config, $this->db, + $this->phpbb_dispatcher, $phpbb_root_path, $phpEx ); - $this->phpbb_dispatcher = new phpbb_mock_event_dispatcher(); - $phpbb_container = $this->container = new ContainerBuilder(); $loader = new YamlFileLoader($phpbb_container, new FileLocator(__DIR__ . '/fixtures')); $loader->load('services_notification.yml'); diff --git a/tests/notification/submit_post_base.php b/tests/notification/submit_post_base.php index 1deef67d8f..80863eab8b 100644 --- a/tests/notification/submit_post_base.php +++ b/tests/notification/submit_post_base.php @@ -79,18 +79,19 @@ abstract class phpbb_notification_submit_post_base extends phpbb_database_test_c 'allow_board_notifications' => true, )); + // Event dispatcher + $phpbb_dispatcher = new phpbb_mock_event_dispatcher(); + $cache_driver = new \phpbb\cache\driver\dummy(); $cache = new \phpbb\cache\service( $cache_driver, $config, $db, + $phpbb_dispatcher, $phpbb_root_path, $phpEx ); - // Event dispatcher - $phpbb_dispatcher = new phpbb_mock_event_dispatcher(); - // Language $lang = new \phpbb\language\language(new \phpbb\language\language_file_loader($phpbb_root_path, $phpEx)); diff --git a/tests/notification/user_list_trim_test.php b/tests/notification/user_list_trim_test.php index 4ddfcb82cd..82f1429624 100644 --- a/tests/notification/user_list_trim_test.php +++ b/tests/notification/user_list_trim_test.php @@ -35,6 +35,7 @@ class phpbb_notification_user_list_trim_test extends phpbb_database_test_case new \phpbb\cache\driver\dummy(), $config, $db, + $phpbb_dispatcher, $phpbb_root_path, $phpEx ); diff --git a/tests/session/check_ban_test.php b/tests/session/check_ban_test.php index 147274398d..7b0aac060c 100644 --- a/tests/session/check_ban_test.php +++ b/tests/session/check_ban_test.php @@ -58,6 +58,10 @@ class phpbb_session_check_ban_test extends phpbb_session_test_case $phpbb_filesystem = new \phpbb\filesystem\filesystem(); $this->backup_cache = $cache; + + // Event dispatcher + $phpbb_dispatcher = new phpbb_mock_event_dispatcher(); + // Change the global cache object for this test because // the mock cache object does not hit the database as is needed // for this test. @@ -65,6 +69,7 @@ class phpbb_session_check_ban_test extends phpbb_session_test_case new \phpbb\cache\driver\file(), $config, $this->db, + $phpbb_dispatcher, $phpbb_root_path, $phpEx ); diff --git a/tests/test_framework/phpbb_functional_test_case.php b/tests/test_framework/phpbb_functional_test_case.php index 7af65b5d5b..815312e236 100644 --- a/tests/test_framework/phpbb_functional_test_case.php +++ b/tests/test_framework/phpbb_functional_test_case.php @@ -253,8 +253,9 @@ class phpbb_functional_test_case extends phpbb_test_case array(), new \phpbb\db\migration\helper() ); + $phpbb_dispatcher = new phpbb_mock_event_dispatcher(); $container->set('migrator', $migrator); - $container->set('dispatcher', new phpbb_mock_event_dispatcher()); + $container->set('dispatcher', $phpbb_dispatcher); $extension_manager = new \phpbb\extension\manager( $container, @@ -264,7 +265,7 @@ class phpbb_functional_test_case extends phpbb_test_case self::$config['table_prefix'] . 'ext', __DIR__ . '/', $phpEx, - new \phpbb\cache\service($this->get_cache_driver(), $config, $this->db, $phpbb_root_path, $phpEx) + new \phpbb\cache\service($this->get_cache_driver(), $config, $this->db, $phpbb_dispatcher, $phpbb_root_path, $phpEx) ); return $extension_manager; diff --git a/tests/version/version_helper_remote_test.php b/tests/version/version_helper_remote_test.php index 959fc5625c..762493986a 100644 --- a/tests/version/version_helper_remote_test.php +++ b/tests/version/version_helper_remote_test.php @@ -29,10 +29,11 @@ class version_helper_remote_test extends \phpbb_test_case 'version' => '3.1.0', )); $container = new \phpbb_mock_container_builder(); + $phpbb_dispatcher = new phpbb_mock_event_dispatcher(); $db = new \phpbb\db\driver\factory($container); $this->cache = $this->getMockBuilder('\phpbb\cache\service') ->setMethods(array('get')) - ->setConstructorArgs(array(new \phpbb\cache\driver\dummy(), $config, $db, '../../', 'php')) + ->setConstructorArgs(array(new \phpbb\cache\driver\dummy(), $config, $db, $phpbb_dispatcher, '../../', 'php')) ->getMock(); $this->cache->expects($this->any())