makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 14:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

Improve news feed. It basically only runs two queries now for the main content.

Browse source 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10352 89ea8834-ac86-4346-8a33-228a782c2dd0
This commit is contained in:
Andreas Fischer 2009-12-20 13:52:56 +00:00
parent 28c33de6d9
commit 7ac774432e
1 changed files with 41 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

55
phpBB/feed.php
View file

@ -1041,41 +1041,68 @@ class phpbb_feed_news extends phpbb_feed_base
$this->num_items = (int) $config['feed_limit']; $this->num_items = (int) $config['feed_limit'];
} }
function get_news_forums()
{
global $db, $cache;
static $forum_ids;
$cache_name = 'feed_news_forum_ids';
$cache_ttl = 300;
if (!isset($forum_ids) && ($forum_ids = $cache->get('_' . $cache_name)) === false)
{
$sql = 'SELECT forum_id
FROM ' . FORUMS_TABLE . '
WHERE ' . $db->sql_bit_and('forum_options', FORUM_OPTION_FEED_NEWS, '<> 0');
$result = $db->sql_query($sql);
$forum_ids = array();
while ($forum_id = (int) $db->sql_fetchfield('forum_id'))
{
$forum_ids[$forum_id] = $forum_id;
}
$db->sql_freeresult($result);
$cache->put('_' . $cache_name, $forum_ids, $cache_ttl);
}
return $forum_ids;
}
function get_sql() function get_sql()
{ {
global $auth, $config, $db; global $auth, $config, $db;
// Determine forum ids
$forum_ids_news = $this->get_news_forums();
// Very very unlikely, check anyway
if (empty($forum_ids_news))
{
return false;
}
// Get passworded forums // Get passworded forums
$forum_ids_passworded = $this->get_passworded_forums(); $forum_ids_passworded = $this->get_passworded_forums();
// Get news forums... // Check forum_ids
$sql = 'SELECT forum_id
FROM ' . FORUMS_TABLE . '
WHERE ' . $db->sql_bit_and('forum_options', FORUM_OPTION_FEED_NEWS, '<> 0');
$result = $db->sql_query($sql);
$in_fid_ary = array(); $in_fid_ary = array();
while ($row = $db->sql_fetchrow($result)) foreach ($forum_ids_news as $forum_id)
{ {
$forum_id = (int) $row['forum_id'];
// Passworded forum
if (isset($forum_ids_passworded[$forum_id])) if (isset($forum_ids_passworded[$forum_id]))
{ {
continue; continue;
} }
// Make sure we can read this forum
if (!$auth->acl_get('f_read', $forum_id)) if (!$auth->acl_get('f_read', $forum_id))
{ {
continue; continue;
} }
$in_fid_ary[] = (int) $row['forum_id']; $in_fid_ary[] = $forum_id;
} }
$db->sql_freeresult($result);
if (!sizeof($in_fid_ary)) if (empty($in_fid_ary))
{ {
return false; return false;
} }