makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 14:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

Stupid horrible group by clauses

Browse source 
git-svn-id: file:///svn/phpbb/trunk@1618 89ea8834-ac86-4346-8a33-228a782c2dd0
This commit is contained in:
Paul S. Owen 2001-12-17 02:02:55 +00:00
parent 4201b9af2a
commit 7ad2cf2c97
2 changed files with 80 additions and 32 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

52
phpBB/posting.php
View file

@ -593,36 +593,60 @@ function generate_smilies($mode)
); );
} }
$sql = "SELECT * $sql = "SELECT emoticon, code, smile_url
FROM " . SMILIES_TABLE . " FROM " . SMILIES_TABLE . "
GROUP BY emoticon
ORDER BY smilies_id"; ORDER BY smilies_id";
if( $result = $db->sql_query($sql) ) if( $result = $db->sql_query($sql) )
{ {
if( $num_smilies = $db->sql_numrows($result) ) if( $db->sql_numrows($result) )
{ {
$rowset = $db->sql_fetchrowset($result); $rowset = array();
while( $row = $db->sql_fetchrow($result) )
{
if( empty($rowset[$row['smile_url']]) )
{
$rowset[$row['smile_url']]['code'] = $row['code'];
$rowset[$row['smile_url']]['emoticon'] = $row['emoticon'];
}
}
$j = 0; $num_smilies = count($rowset);
$s_colspan = 0;
$smilies_count = ( $mode == 'inline' ) ? min(20, $num_smilies) : $num_smilies; $smilies_count = ( $mode == 'inline' ) ? min(19, $num_smilies) : $num_smilies;
$smilies_split_row = ( $mode == 'inline' ) ? 3 : 7; $smilies_split_row = ( $mode == 'inline' ) ? 3 : 7;
for($i = 0; $i < $smilies_count; $i++)
$s_colspan = 0;
$row = 0;
$col = 0;
while( list($smile_url, $data) = @each($rowset) )
{ {
if( !$j ) if( !$col )
{ {
$template->assign_block_vars("smilies_row", array()); $template->assign_block_vars("smilies_row", array());
} }
$template->assign_block_vars("smilies_row.smilies_col", array( $template->assign_block_vars("smilies_row.smilies_col", array(
"SMILEY_CODE" => $rowset[$i]['code'], "SMILEY_CODE" => $data['code'],
"SMILEY_IMG" => "images/smiles/" . $rowset[$i]['smile_url'], "SMILEY_IMG" => "images/smiles/" . $smile_url,
"SMILEY_DESC" => $rowset[$i]['emoticon']) "SMILEY_DESC" => $data['emoticon'])
); );
$s_colspan = max($s_colspan, $j + 1); $s_colspan = max($s_colspan, $col + 1);
$j = ( $j == $smilies_split_row ) ? 0 : $j + 1; if( $col == $smilies_split_row )
{
if( $mode == 'inline' && $row == 4 )
{
break;
}
$col = 0;
$row++;
}
else
{
$col++;
}
} }
if( $mode == 'inline' && $num_smilies > 20) if( $mode == 'inline' && $num_smilies > 20)

52
phpBB/privmsg.php
View file

@ -63,36 +63,60 @@ function generate_smilies($mode)
); );
} }
$sql = "SELECT * $sql = "SELECT emoticon, code, smile_url
FROM " . SMILIES_TABLE . " FROM " . SMILIES_TABLE . "
GROUP BY emoticon
ORDER BY smilies_id"; ORDER BY smilies_id";
if( $result = $db->sql_query($sql) ) if( $result = $db->sql_query($sql) )
{ {
if( $num_smilies = $db->sql_numrows($result) ) if( $db->sql_numrows($result) )
{ {
$rowset = $db->sql_fetchrowset($result); $rowset = array();
while( $row = $db->sql_fetchrow($result) )
{
if( empty($rowset[$row['smile_url']]) )
{
$rowset[$row['smile_url']]['code'] = $row['code'];
$rowset[$row['smile_url']]['emoticon'] = $row['emoticon'];
}
}
$j = 0; $num_smilies = count($rowset);
$s_colspan = 0;
$smilies_count = ( $mode == 'inline' ) ? min(20, $num_smilies) : $num_smilies; $smilies_count = ( $mode == 'inline' ) ? min(19, $num_smilies) : $num_smilies;
$smilies_split_row = ( $mode == 'inline' ) ? 3 : 7; $smilies_split_row = ( $mode == 'inline' ) ? 3 : 7;
for($i = 0; $i < $smilies_count; $i++)
$s_colspan = 0;
$row = 0;
$col = 0;
while( list($smile_url, $data) = @each($rowset) )
{ {
if( !$j ) if( !$col )
{ {
$template->assign_block_vars("smilies_row", array()); $template->assign_block_vars("smilies_row", array());
} }
$template->assign_block_vars("smilies_row.smilies_col", array( $template->assign_block_vars("smilies_row.smilies_col", array(
"SMILEY_CODE" => $rowset[$i]['code'], "SMILEY_CODE" => $data['code'],
"SMILEY_IMG" => "images/smiles/" . $rowset[$i]['smile_url'], "SMILEY_IMG" => "images/smiles/" . $smile_url,
"SMILEY_DESC" => $rowset[$i]['emoticon']) "SMILEY_DESC" => $data['emoticon'])
); );
$s_colspan = max($s_colspan, $j + 1); $s_colspan = max($s_colspan, $col + 1);
$j = ( $j == $smilies_split_row ) ? 0 : $j + 1; if( $col == $smilies_split_row )
{
if( $mode == 'inline' && $row == 4 )
{
break;
}
$col = 0;
$row++;
}
else
{
$col++;
}
} }
if( $mode == 'inline' && $num_smilies > 20) if( $mode == 'inline' && $num_smilies > 20)