makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 06:08:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[feature/prune-users] Use a map instead of performing array scans.

Browse source 
PHPBB3-9622
This commit is contained in:
Oleg Pudeyev 2012-03-25 21:08:06 -04:00
parent 138d2e2a4c
commit 7c752aa3de
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
phpBB/includes/functions_user.php
View file

@ -614,9 +614,11 @@ function user_delete($mode, $user_ids, $retain_username = true)
WHERE ' . $author_id_sql; WHERE ' . $author_id_sql;
$db->sql_query($sql); $db->sql_query($sql);
$user_ids_map = array_flip($user_ids);
foreach ($undelivered_user as $_user_id => $ary) foreach ($undelivered_user as $_user_id => $ary)
{ {
if (in_array($_user_id, $user_ids)) if (isset($user_ids_map[$_user_id]))
{ {
continue; continue;
} }
@ -631,7 +633,7 @@ function user_delete($mode, $user_ids, $retain_username = true)
$db->sql_transaction('commit'); $db->sql_transaction('commit');
// Reset newest user info if appropriate // Reset newest user info if appropriate
if (in_array($config['newest_user_id'], $user_ids)) if (isset($user_ids_map[$config['newest_user_id']]))
{ {
update_last_username(); update_last_username();
} }