makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 06:08:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/14315] Use proper ID selectors in ui test

Browse source 
PHPBB3-14315
This commit is contained in:
Marc Alexander 2016-02-17 13:47:51 +01:00
parent a75885bd85
commit 7c96d0abcd
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tests/ui/permission_roles_test.php
View file

@ -26,18 +26,18 @@ class ui_permission_roles_test extends phpbb_ui_test_case
$this->visit('adm/index.php?i=acp_permissions&mode=setting_forum_local&sid=' . $this->sid); $this->visit('adm/index.php?i=acp_permissions&mode=setting_forum_local&sid=' . $this->sid);
// Select forums // Select forums
$elements = self::find_element('cssSelector', 'select[id=forum]') $elements = self::find_element('cssSelector', 'select#forum')
->findElements(\Facebook\WebDriver\WebDriverBy::tagName('option')); ->findElements(\Facebook\WebDriver\WebDriverBy::tagName('option'));
foreach ($elements as $element) foreach ($elements as $element)
{ {
$element->click(); $element->click();
} }
self::find_element('cssSelector', 'form[id=select_victim]') self::find_element('cssSelector', 'form#select_victim')
->findElement(\Facebook\WebDriver\WebDriverBy::cssSelector('input[type=submit]')) ->findElement(\Facebook\WebDriver\WebDriverBy::cssSelector('input[type=submit]'))
->click(); ->click();
// Select administrators and guests // Select administrators and guests
$groups_form = self::find_element('cssSelector', 'form[id=groups]'); $groups_form = self::find_element('cssSelector', 'form#groups');
$elements = $groups_form $elements = $groups_form
->findElement(\Facebook\WebDriver\WebDriverBy::cssSelector('select')) ->findElement(\Facebook\WebDriver\WebDriverBy::cssSelector('select'))
->findElements(\Facebook\WebDriver\WebDriverBy::tagName('option')); ->findElements(\Facebook\WebDriver\WebDriverBy::tagName('option'));