makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-08 04:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/13534] Set imagick path to empty string to prevent failing path check

Browse source 
The imagick path defaults to /usr/bin. If it doesn't exist for some reason,
for example on travis, the form won't be submitted and the settings won't be
changed.

PHPBB3-13534
This commit is contained in:
Marc Alexander 2015-01-21 15:18:25 +01:00
parent ddeb696b25
commit 7d6fdcfaa5
1 changed files with 16 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
tests/functional/fileupload_form_test.php
View file

@ -93,23 +93,32 @@ class phpbb_functional_fileupload_form_test extends phpbb_functional_test_case
$this->login();
$this->admin_login();
$this->add_lang('ucp');
// Make sure check_attachment_content is set to false
$crawler = self::request('GET', 'adm/index.php?sid=' . $this->sid . '&i=acp_attachments&mode=attach');
$form = $crawler->selectButton('Submit')->form();
$values = $form->getValues();
$values["config[check_attachment_content]"] = 0;
$form->setValues($values);
$crawler = self::submit($form);
$form = $crawler->selectButton('Submit')->form(array(
'config[check_attachment_content]' => 0,
'config[img_imagick]' => '',
));
self::submit($form);
// Request index for correct URL
$crawler = self::request('GET', 'index.php?sid=' . $this->sid);
self::request('GET', 'index.php?sid=' . $this->sid);
$crawler = $this->upload_file('disallowed.jpg', 'image/jpeg');
// Hitting the UNABLE_GET_IMAGE_SIZE error means we passed the
// DISALLOWED_CONTENT check
$this->assertContainsLang('UNABLE_GET_IMAGE_SIZE', $crawler->text());
// Reset check_attachment_content to default (enabled)
$crawler = self::request('GET', 'adm/index.php?sid=' . $this->sid . '&i=acp_attachments&mode=attach');
$form = $crawler->selectButton('Submit')->form(array(
'config[check_attachment_content]' => 1,
));
self::submit($form);
}
public function test_too_large()