diff --git a/phpBB/docs/CHANGELOG.html b/phpBB/docs/CHANGELOG.html
index e49e0f30f2..3134dc76ff 100644
--- a/phpBB/docs/CHANGELOG.html
+++ b/phpBB/docs/CHANGELOG.html
@@ -109,6 +109,7 @@
[Feature] Added completely new hook system to allow better application/mod integration - see docs/hook_system.html
[Fix] Correctly delete excess poll options (Bug #14566)
[Fix] Allow names evaluating to false for poll options
+ [Change] use in-build functions for user online list (#14596) - provided by rxu
diff --git a/phpBB/includes/acp/info/acp_attachments.php b/phpBB/includes/acp/info/acp_attachments.php
index 9ca76e284d..b77785801f 100644
--- a/phpBB/includes/acp/info/acp_attachments.php
+++ b/phpBB/includes/acp/info/acp_attachments.php
@@ -1,10 +1,10 @@
' . $row['username'] . '';
- }
- else
- {
- $user_colour = '';
- }
-
if ($row['session_viewonline'])
{
- $user_online_link = $row['username'];
$logged_visible_online++;
}
else
{
- $user_online_link = '' . $row['username'] . '';
+ $row['username'] = '' . $row['username'] . '';
$logged_hidden_online++;
}
if (($row['session_viewonline']) || $auth->acl_get('u_viewonline'))
{
- if ($row['user_type'] <> USER_IGNORE)
- {
- $user_online_link = '' . $user_online_link . '';
- }
- else
- {
- $user_online_link = ($user_colour) ? '' . $user_online_link . '' : $user_online_link;
- }
-
+ $user_online_link = get_username_string(($row['user_type'] <> USER_IGNORE) ? 'full' : 'no_profile', $row['user_id'], $row['username'], $row['user_colour']);
$online_userlist .= ($online_userlist != '') ? ', ' . $user_online_link : $user_online_link;
}
}
diff --git a/phpBB/includes/mcp/info/mcp_ban.php b/phpBB/includes/mcp/info/mcp_ban.php
index 75b30174df..383df30498 100644
--- a/phpBB/includes/mcp/info/mcp_ban.php
+++ b/phpBB/includes/mcp/info/mcp_ban.php
@@ -1,10 +1,10 @@
'Successfully changed default group.',
- 'GROUP_AVATAR' => 'Group avatar',
+ 'GROUP_AVATAR' => 'Group avatar',
'GROUP_CHANGE_DEFAULT' => 'Are you sure you want to change your default membership to the group ā%sā?',
'GROUP_CLOSED' => 'Closed',
'GROUP_DESC' => 'Group description',
'GROUP_HIDDEN' => 'Hidden',
- 'GROUP_INFORMATION' => 'Usergroup information',
+ 'GROUP_INFORMATION' => 'Usergroup information',
'GROUP_IS_CLOSED' => 'This is a closed group, new members can only join upon invitation of a group leader.',
- 'GROUP_IS_FREE' => 'This is a freely open group, all new members are welcome.',
+ 'GROUP_IS_FREE' => 'This is a freely open group, all new members are welcome.',
'GROUP_IS_HIDDEN' => 'This is a hidden group, only members of this group can view its membership.',
'GROUP_IS_OPEN' => 'This is an open group, members can apply to join.',
- 'GROUP_IS_SPECIAL' => 'This is a special group, special groups are managed by the board administrators.',
+ 'GROUP_IS_SPECIAL' => 'This is a special group, special groups are managed by the board administrators.',
'GROUP_JOIN' => 'Join group',
'GROUP_JOIN_CONFIRM' => 'Are you sure you want to join the selected group?',
'GROUP_JOIN_PENDING' => 'Request to join group',
@@ -58,7 +63,7 @@ $lang = array_merge($lang, array(
'GROUP_MEMBERS' => 'Group members',
'GROUP_NAME' => 'Group name',
'GROUP_OPEN' => 'Open',
- 'GROUP_RANK' => 'Group rank',
+ 'GROUP_RANK' => 'Group rank',
'GROUP_RESIGN_MEMBERSHIP' => 'Resign group membership',
'GROUP_RESIGN_MEMBERSHIP_CONFIRM' => 'Are you sure you want to resign your membership from the selected group?',
'GROUP_RESIGN_PENDING' => 'Resign a pending group membership',
diff --git a/phpBB/language/en/help_bbcode.php b/phpBB/language/en/help_bbcode.php
index 5ffe3ac742..00b00c9e19 100644
--- a/phpBB/language/en/help_bbcode.php
+++ b/phpBB/language/en/help_bbcode.php
@@ -1,17 +1,21 @@
'absence',
'abridgement' => 'abridgment',
diff --git a/phpBB/language/en/ucp.php b/phpBB/language/en/ucp.php
index 7c397535ca..c573480863 100644
--- a/phpBB/language/en/ucp.php
+++ b/phpBB/language/en/ucp.php
@@ -13,6 +13,11 @@
/**
* DO NOT CHANGE
*/
+if (!defined('IN_PHPBB'))
+{
+ exit;
+}
+
if (empty($lang) || !is_array($lang))
{
$lang = array();
diff --git a/phpBB/language/en/viewforum.php b/phpBB/language/en/viewforum.php
index c981c24eb1..546f91587d 100644
--- a/phpBB/language/en/viewforum.php
+++ b/phpBB/language/en/viewforum.php
@@ -1,18 +1,23 @@
{L_INDEX}
- class="icon-unsubscribe"class="icon-subscribe" title="{S_WATCH_FORUM_TITLE}">{S_WATCH_FORUM_TITLE}
- class="icon-unsubscribe"class="icon-subscribe">{L_WATCH_TOPIC}
- {L_BOOKMARK_TOPIC}
- {L_BUMP_TOPIC}
+ class="icon-unsubscribe"class="icon-subscribe">{S_WATCH_FORUM_TITLE}
+ class="icon-unsubscribe"class="icon-subscribe">{L_WATCH_TOPIC}
+ {L_BOOKMARK_TOPIC}
+ {L_BUMP_TOPIC}
{L_THE_TEAM} • {L_DELETE_COOKIES} • {S_TIMEZONE}