diff --git a/phpBB/config/default/container/services_content.yml b/phpBB/config/default/container/services_content.yml index 3cdd0cfe6f..f26c970021 100644 --- a/phpBB/config/default/container/services_content.yml +++ b/phpBB/config/default/container/services_content.yml @@ -67,3 +67,5 @@ services: viewonline_helper: class: phpbb\viewonline_helper + arguments: + - '@dbal.conn' diff --git a/phpBB/phpbb/viewonline_helper.php b/phpBB/phpbb/viewonline_helper.php index 8df1f484d8..647d3dbf19 100644 --- a/phpBB/phpbb/viewonline_helper.php +++ b/phpBB/phpbb/viewonline_helper.php @@ -16,23 +16,69 @@ namespace phpbb; use phpbb\filesystem\helper as filesystem_helper; /** -* Class to handle viewonline related tasks -*/ + * Class to handle viewonline related tasks + */ class viewonline_helper { + /** @var \phpbb\db\driver\driver_interface */ + protected $db; + /** - * - */ - public function __construct() + * @param \phpbb\db\driver\driver_interface $db + */ + public function __construct(\phpbb\db\driver\driver_interface $db) { + $this->db = $db; } /** - * Get user page - * - * @param string $session_page User's session page - * @return array Match array filled by preg_match() - */ + * Get forum IDs for topics + * + * Retrieve forum IDs and add the data into the session data array + * Array structure matches sql_fethrowset() result array + * + * @param array $session_data_rowset Users' session data array + * @return void + */ + public function get_forum_ids(array &$session_data_rowset): void + { + $topic_ids = $match = []; + foreach ($session_data_rowset as $number => $row) + { + if ($row['session_forum_id'] == 0 && preg_match('#t=([0-9]+)#', $row['session_page'], $match)) + { + $topic_ids[$number] = (int) $match[1]; + } + } + + if (count($topic_ids = array_unique($topic_ids))) + { + $sql_ary = [ + 'SELECT' => 't.topic_id, t.forum_id', + 'FROM' => [ + TOPICS_TABLE => 't', + ], + 'WHERE' => $this->db->sql_in_set('t.topic_id', $topic_ids), + 'ORDER_BY' => 't.topic_id', + ]; + $result = $this->db->sql_query($this->db->sql_build_query('SELECT', $sql_ary)); + $forum_ids_rowset = $this->db->sql_fetchrowset($result); + $this->db->sql_freeresult($result); + + foreach ($forum_ids_rowset as $forum_ids_row) + { + $session_data_row_number = array_search((int) $forum_ids_row['topic_id'], $topic_ids); + $session_data_rowset[$session_data_row_number]['session_forum_id'] = (int) $forum_ids_row['forum_id']; + } + } + } + + /** + * Get user page + * + * @param string $session_page User's session page + * @return array Match array filled by preg_match() + */ public function get_user_page($session_page) { $session_page = filesystem_helper::clean_path($session_page); diff --git a/phpBB/viewonline.php b/phpBB/viewonline.php index 343a0052a6..12ccd03526 100644 --- a/phpBB/viewonline.php +++ b/phpBB/viewonline.php @@ -180,6 +180,8 @@ $vars = array('sql_ary', 'show_guests', 'guest_counter', 'forum_data'); extract($phpbb_dispatcher->trigger_event('core.viewonline_modify_sql', compact($vars))); $result = $db->sql_query($db->sql_build_query('SELECT', $sql_ary)); +$session_data_rowset = $db->sql_fetchrowset($result); +$db->sql_freeresult($result); $prev_id = $prev_ip = $user_list = array(); $logged_visible_online = $logged_hidden_online = $counter = 0; @@ -190,7 +192,10 @@ $controller_helper = $phpbb_container->get('controller.helper'); /** @var \phpbb\group\helper $group_helper */ $group_helper = $phpbb_container->get('group_helper'); -while ($row = $db->sql_fetchrow($result)) +// Get forum IDs for session pages which have only 't' parameter +$viewonline_helper->get_forum_ids($session_data_rowset); + +foreach ($session_data_rowset as $row) { if ($row['user_id'] != ANONYMOUS && !isset($prev_id[$row['user_id']])) { @@ -438,7 +443,6 @@ while ($row = $db->sql_fetchrow($result)) $template->assign_block_vars('user_row', $template_row); } -$db->sql_freeresult($result); unset($prev_id, $prev_ip); $group_helper->display_legend($db, $template); diff --git a/tests/functional/viewonline_test.php b/tests/functional/viewonline_test.php new file mode 100644 index 0000000000..871d43792d --- /dev/null +++ b/tests/functional/viewonline_test.php @@ -0,0 +1,112 @@ + +* @license GNU General Public License, version 2 (GPL-2.0) +* +* For full copyright and license information, please see +* the docs/CREDITS.txt file. +* +*/ + +/** +* @group functional +*/ +class phpbb_functional_viewonline_test extends phpbb_functional_test_case +{ + protected function get_forum_name_by_topic_id($topic_id) + { + $db = $this->get_db(); + + // Forum info + $sql = 'SELECT f.forum_name + FROM ' . FORUMS_TABLE . ' f,' . TOPICS_TABLE . ' t + WHERE t.forum_id = f.forum_id + AND t.topic_id = ' . (int) $topic_id; + $result = $db->sql_query($sql); + $forum_name = $db->sql_fetchfield('forum_name'); + $db->sql_freeresult($result, 1800); // cache for 30 minutes + + return $forum_name; + } + + protected function get_forum_name_by_forum_id($forum_id) + { + $db = $this->get_db(); + + // Forum info + $sql = 'SELECT forum_name + FROM ' . FORUMS_TABLE . ' + WHERE forum_id = ' . (int) $forum_id; + $result = $db->sql_query($sql); + $forum_name = $db->sql_fetchfield('forum_name'); + $db->sql_freeresult($result, 1800); // cache for 30 minutes + + return $forum_name; + } + + public function test_viewonline() + { + $this->create_user('viewonline-test-user1'); + + // Log in as test user + self::$client->restart(); + $this->login('viewonline-test-user1'); + $crawler = self::request('GET', 'posting.php?mode=reply&t=1&sid=' . $this->sid); + $this->assertContainsLang('POST_REPLY', $crawler->text()); + // Log in as another user + self::$client->restart(); + $this->login(); + // PHP goes faster than DBMS, make sure session data got written to the database + sleep(1); + $crawler = self::request('GET', 'viewonline.php?sid=' . $this->sid); + // Make sure posting reply page is in the list + $this->assertStringContainsString('viewonline-test-user1', $crawler->text()); + $this->assertStringContainsString($this->lang('REPLYING_MESSAGE', $this->get_forum_name_by_topic_id(1)), $crawler->text()); + + // Log in as test user + self::$client->restart(); + $this->login('viewonline-test-user1'); + $crawler = self::request('GET', 'posting.php?mode=post&f=2&sid=' . $this->sid); + $this->assertContainsLang('POST_TOPIC', $crawler->text()); + // Log in as another user + self::$client->restart(); + $this->login(); + // PHP goes faster than DBMS, make sure session data got written to the database + sleep(1); + $crawler = self::request('GET', 'viewonline.php?sid=' . $this->sid); + // Make sure posting message page is in the list + $this->assertStringContainsString('viewonline-test-user1', $crawler->text()); + $this->assertStringContainsString($this->lang('POSTING_MESSAGE', $this->get_forum_name_by_forum_id(2)), $crawler->text()); + + // Log in as test user + self::$client->restart(); + $this->login('viewonline-test-user1'); + self::request('GET', 'viewtopic.php?t=1&sid=' . $this->sid); + // Log in as another user + self::$client->restart(); + $this->login(); + // PHP goes faster than DBMS, make sure session data got written to the database + sleep(1); + $crawler = self::request('GET', 'viewonline.php?sid=' . $this->sid); + // Make sure reading topic page is in the list + $this->assertStringContainsString('viewonline-test-user1', $crawler->text()); + $this->assertStringContainsString($this->lang('READING_TOPIC', $this->get_forum_name_by_topic_id(1)), $crawler->text()); + + // Log in as test user + self::$client->restart(); + $this->login('viewonline-test-user1'); + self::request('GET', 'viewforum.php?f=2&sid=' . $this->sid); + // Log in as another user + self::$client->restart(); + $this->login(); + // PHP goes faster than DBMS, make sure session data got written to the database + sleep(1); + $crawler = self::request('GET', 'viewonline.php?sid=' . $this->sid); + // Make sure reading forum page is in the list + $this->assertStringContainsString('viewonline-test-user1', $crawler->text()); + $this->assertStringContainsString($this->lang('READING_FORUM', $this->get_forum_name_by_forum_id(2)), $crawler->text()); + } +} diff --git a/tests/viewonline/helper_test.php b/tests/viewonline/helper_test.php index 83b343f602..5d1eef3f85 100644 --- a/tests/viewonline/helper_test.php +++ b/tests/viewonline/helper_test.php @@ -19,7 +19,11 @@ class phpbb_viewonline_helper_test extends phpbb_test_case { parent::setUp(); - $this->viewonline_helper = new \phpbb\viewonline_helper(); + $db = $this->getMockBuilder('\phpbb\db\driver\mysqli') + ->disableOriginalConstructor() + ->getMock(); + + $this->viewonline_helper = new \phpbb\viewonline_helper($db); } public function session_pages_data()