[feature/attachment-management-no-reassignment] Fix minor flaws in the code.

Thanks to Oleg for inspection.

PHPBB3-9721
This commit is contained in:
rxu 2011-03-14 00:03:31 +07:00
parent 97864d69ee
commit 804a11074b

View file

@ -1137,9 +1137,9 @@ class acp_attachments
FROM ' . ATTACHMENTS_TABLE . ' a FROM ' . ATTACHMENTS_TABLE . ' a
LEFT JOIN ' . USERS_TABLE . ' u ON (u.user_id = a.poster_id) LEFT JOIN ' . USERS_TABLE . ' u ON (u.user_id = a.poster_id)
LEFT JOIN ' . TOPICS_TABLE . " t ON (a.topic_id = t.topic_id) LEFT JOIN ' . TOPICS_TABLE . " t ON (a.topic_id = t.topic_id)
WHERE a.is_orphan = 0 WHERE a.is_orphan = 0
$limit_filetime $limit_filetime
ORDER BY $sql_sort_order"; ORDER BY $sql_sort_order";
$result = $db->sql_query_limit($sql, $sql_limit, $sql_start); $result = $db->sql_query_limit($sql, $sql_limit, $sql_start);
$i = ($store_reverse) ? $sql_limit - 1 : 0; $i = ($store_reverse) ? $sql_limit - 1 : 0;
@ -1161,8 +1161,7 @@ class acp_attachments
'S_SORT_DIR' => $s_sort_dir) 'S_SORT_DIR' => $s_sort_dir)
); );
// Grab extensions // Grab extensions information
$extensions = array();
$extensions = $cache->obtain_attach_extensions(true); $extensions = $cache->obtain_attach_extensions(true);
for ($i = 0, $end = sizeof($attachments_list); $i < $end; ++$i) for ($i = 0, $end = sizeof($attachments_list); $i < $end; ++$i)