makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-25 19:38:53 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/11413] Use sql_insert_buffer

Browse source 
PHPBB3-11413
This commit is contained in:
Nathaniel Guse 2013-04-30 21:01:46 -05:00
parent 00ea297b61
commit 81b2ad158c
1 changed files with 8 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
phpBB/includes/db/migration/data/310/notifications2.php
View file

@ -108,7 +108,7 @@ class phpbb_db_migration_data_310_notifications2 extends phpbb_db_migration
FROM ' . USERS_TABLE; FROM ' . USERS_TABLE;
$result = $this->db->sql_query($sql); $result = $this->db->sql_query($sql);
$sql_insert_data = array(); $insert_buffer = new phpbb_db_sql_insert_buffer($this->db, $insert_table);
while ($row = $this->db->sql_fetchrow($result)) while ($row = $this->db->sql_fetchrow($result))
{ {
$notification_methods = array(); $notification_methods = array();
@ -129,8 +129,8 @@ class phpbb_db_migration_data_310_notifications2 extends phpbb_db_migration
// Notifications for posts // Notifications for posts
foreach (array('post', 'topic') as $item_type) foreach (array('post', 'topic') as $item_type)
{ {
$sql_insert_data = $this->add_method_rows( $this->add_method_rows(
$sql_insert_data, $insert_buffer,
$item_type, $item_type,
0, 0,
$row['user_id'], $row['user_id'],
@ -142,30 +142,21 @@ class phpbb_db_migration_data_310_notifications2 extends phpbb_db_migration
{ {
// Notifications for private messages // Notifications for private messages
// User either gets all methods or no method // User either gets all methods or no method
$sql_insert_data = $this->add_method_rows( $this->add_method_rows(
$sql_insert_data, $insert_buffer,
'pm', 'pm',
0, 0,
$row['user_id'], $row['user_id'],
$notification_methods $notification_methods
); );
} }
if (sizeof($sql_insert_data) > 500)
{
$this->db->sql_multi_insert($insert_table, $sql_insert_data);
$sql_insert_data = array();
}
} }
$this->db->sql_freeresult($result); $this->db->sql_freeresult($result);
if (!empty($sql_insert_data)) $insert_buffer->flush();
{
$this->db->sql_multi_insert($insert_table, $sql_insert_data);
}
} }
protected function add_method_rows(array $sql_insert_data, $item_type, $item_id, $user_id, array $methods) protected function add_method_rows(phpbb_db_sql_insert_buffer $insert_buffer, $item_type, $item_id, $user_id, array $methods)
{ {
$row_base = array( $row_base = array(
'item_type' => $item_type, 'item_type' => $item_type,
@ -176,9 +167,7 @@ class phpbb_db_migration_data_310_notifications2 extends phpbb_db_migration
foreach ($methods as $method) foreach ($methods as $method)
{ {
$row_base['method'] = $method; $row_base['method'] = $method;
$sql_insert_data[] = $row_base; $insert_buffer->insert($row_base);
} }
return $sql_insert_data;
} }
} }