From 82b4ae200fd4e4535f2c1a2338ce4fe48ff26bf4 Mon Sep 17 00:00:00 2001
From: "Paul S. Owen" <psotfx@users.sourceforge.net>
Date: Sun, 19 May 2002 15:11:17 +0000
Subject: [PATCH] More fixes

git-svn-id: file:///svn/phpbb/branches/phpBB-2_0_0@2600 89ea8834-ac86-4346-8a33-228a782c2dd0
---
 phpBB/memberlist.php |  4 ++--
 phpBB/posting.php    | 10 ++++------
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/phpBB/memberlist.php b/phpBB/memberlist.php
index 99b51bb36a..8a6caa322d 100644
--- a/phpBB/memberlist.php
+++ b/phpBB/memberlist.php
@@ -33,7 +33,7 @@ init_userprefs($userdata);
 // End session management
 //
 
-$start = ( isset($HTTP_GET_VARS['start']) ) ? $HTTP_GET_VARS['start'] : 0;
+$start = ( isset($HTTP_GET_VARS['start']) ) ? intval($HTTP_GET_VARS['start']) : 0;
 
 if(isset($HTTP_POST_VARS['order']))
 {
@@ -58,7 +58,7 @@ $select_sort_mode = '<select name="mode">';
 for($i = 0; $i < count($mode_types_text); $i++)
 {
 	$selected = ( $mode == $mode_types[$i] ) ? ' selected="selected"' : '';
-	$select_sort_mode .= "<option value=\"" . $mode_types[$i] . "\"$selected>" . $mode_types_text[$i] . "</option>";
+	$select_sort_mode .= '<option value="' . $mode_types[$i] . '"' . $selected . '>' . $mode_types_text[$i] . '</option>';
 }
 $select_sort_mode .= '</select>';
 
diff --git a/phpBB/posting.php b/phpBB/posting.php
index e52fdafa6c..3e9f28fb75 100644
--- a/phpBB/posting.php
+++ b/phpBB/posting.php
@@ -56,14 +56,12 @@ while( list($var, $param) = @each($params) )
 	}
 }
 
-
-
 $refresh = $preview || $poll_add || $poll_edit || $poll_delete;
 
 //
 // Set topic type
 //
-$topic_type = ( !empty($HTTP_POST_VARS['topictype']) ) ? $HTTP_POST_VARS['topictype'] : POST_NORMAL;
+$topic_type = ( !empty($HTTP_POST_VARS['topictype']) ) ? intval($HTTP_POST_VARS['topictype']) : POST_NORMAL;
 
 //
 // If the mode is set to topic review then output
@@ -358,7 +356,7 @@ if ( !$is_auth[$is_auth_type] )
 //
 // Set toggles for various options
 //
-if( !$board_config['allow_html'] )
+if ( !$board_config['allow_html'] )
 {
 	$html_on = 0;
 }
@@ -367,7 +365,7 @@ else
 	$html_on = ( $submit || $refresh ) ? ( ( !empty($HTTP_POST_VARS['disable_html']) ) ? 0 : TRUE ) : ( ( $userdata['user_id'] == ANONYMOUS ) ? $board_config['allow_html'] : $userdata['user_allowhtml'] );
 }
 
-if( !$board_config['allow_bbcode'] )
+if ( !$board_config['allow_bbcode'] )
 {
 	$bbcode_on = 0;
 }
@@ -376,7 +374,7 @@ else
 	$bbcode_on = ( $submit || $refresh ) ? ( ( !empty($HTTP_POST_VARS['disable_bbcode']) ) ? 0 : TRUE ) : ( ( $userdata['user_id'] == ANONYMOUS ) ? $board_config['allow_bbcode'] : $userdata['user_allowbbcode'] );
 }
 
-if( !$board_config['allow_smilies'] )
+if ( !$board_config['allow_smilies'] )
 {
 	$smilies_on = 0;
 }