makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-13 14:58:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2610 from brunoais/ticket/12699

Browse source 
[Ticket/12699] Remove magic numbers in the message textarea keydown callback

* brunoais/ticket/12699:
  [ticket/12699] Replace magic numbers for the TAB and for ENTER keydown
  [ticket/12699] Add tab key to keymap
This commit is contained in:
Andreas Fischer 2014-06-17 18:13:12 +02:00
commit 82cf239294
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
phpBB/assets/javascript/core.js
View file

@ -7,6 +7,7 @@ phpbb.alertTime = 100;
// define a couple constants for keydown functions. // define a couple constants for keydown functions.
var keymap = { var keymap = {
TAB: 9,
ENTER: 13, ENTER: 13,
ESC: 27 ESC: 27
}; };
@ -1201,10 +1202,10 @@ phpbb.applyCodeEditor = function(textarea) {
var key = event.keyCode || event.which; var key = event.keyCode || event.which;
// intercept tabs // intercept tabs
if (key == 9 && if (key == keymap.TAB &&
!event.ctrlKey && !event.ctrlKey &&
!event.shiftKey && !event.shiftKey &&
!event.altKey && !event.altKey &&
!event.metaKey) { !event.metaKey) {
if (inTag()) { if (inTag()) {
appendText("\t"); appendText("\t");
@ -1214,7 +1215,7 @@ phpbb.applyCodeEditor = function(textarea) {
} }
// intercept new line characters // intercept new line characters
if (key == 13) { if (key == keymap.ENTER) {
if (inTag()) { if (inTag()) {
var lastLine = getLastLine(true), var lastLine = getLastLine(true),
code = '' + /^\s*/g.exec(lastLine); code = '' + /^\s*/g.exec(lastLine);