makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 06:08:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/17399] Fix selected language in installer

Browse source 
This fixes a bug where a user could have other languages in the installer
but the language dropdown did not match the language shown.

PHPBB-17399
This commit is contained in:
battye 2025-06-14 14:35:18 +00:00
parent 8f8a93fa71
commit 8411da1819
3 changed files with 21 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
phpBB/adm/style/installer_header.html
View file

@ -19,7 +19,7 @@
<form method="post" action="#" id="language_selector"> <form method="post" action="#" id="language_selector">
<fieldset class="nobg"> <fieldset class="nobg">
<label for="language">{L_SELECT_LANG}{L_COLON}</label> <label for="language">{L_SELECT_LANG}{L_COLON}</label>
<select id="language" name="language"> <select id="language" name="language">
<!-- BEGIN language_select_item --> <!-- BEGIN language_select_item -->
<option value="{language_select_item.VALUE}"<!-- IF language_select_item.SELECTED --> selected="selected"<!-- ENDIF -->>{language_select_item.NAME}</option> <option value="{language_select_item.VALUE}"<!-- IF language_select_item.SELECTED --> selected="selected"<!-- ENDIF -->>{language_select_item.NAME}</option>
<!-- END language_select_item --> <!-- END language_select_item -->

8
phpBB/phpbb/install/controller/helper.php
View file

@ -339,6 +339,14 @@ class helper
protected function render_language_select($selected_language = null) protected function render_language_select($selected_language = null)
{ {
$langs = $this->lang_helper->get_available_languages(); $langs = $this->lang_helper->get_available_languages();
// The first language will be selected by default. Unless a user has consciously included
// other languages in the installation process, it will be British English anyway.
if ($selected_language === null && count($langs))
{
$selected_language = $langs[0]['iso'];
}
foreach ($langs as $lang) foreach ($langs as $lang)
{ {
$this->template->assign_block_vars('language_select_item', array( $this->template->assign_block_vars('language_select_item', array(

12
phpBB/phpbb/language/language_file_helper.php
View file

@ -67,6 +67,18 @@ class language_file_helper
); );
} }
usort($available_languages, [$this, 'sort_by_local_name']);
return $available_languages; return $available_languages;
} }
/**
* Sorts the languages by their name instead of iso code
*
* @return array
*/
private static function sort_by_local_name($a, $b)
{
return $a['local_name'] > $b['local_name'];
}
} }