makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-10 05:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/15495] Use transaction in ACP move_forum

Browse source 
Should prevent the forums table from getting messed up if an error or
concurrent execution happens.

PHPBB3-15495
This commit is contained in:
Daniel Sinn 2018-01-03 16:18:14 -05:00
parent 0ff5f9fa0e
commit 84ccb3aded
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
phpBB/includes/acp/acp_forums.php
View file

@ -1431,6 +1431,8 @@ class acp_forums
return $errors; return $errors;
} }
$db->sql_transaction('begin');
$moved_forums = get_forum_branch($from_id, 'children', 'descending'); $moved_forums = get_forum_branch($from_id, 'children', 'descending');
$from_data = $moved_forums[0]; $from_data = $moved_forums[0];
$diff = sizeof($moved_forums) * 2; $diff = sizeof($moved_forums) * 2;
@ -1502,6 +1504,8 @@ class acp_forums
WHERE " . $db->sql_in_set('forum_id', $moved_ids); WHERE " . $db->sql_in_set('forum_id', $moved_ids);
$db->sql_query($sql); $db->sql_query($sql);
$db->sql_transaction('commit');
return $errors; return $errors;
} }