makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-10 13:28:55 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/17100] Clean up code a bit based on code reviews

Browse source 
PHPBB3-17100
This commit is contained in:
Marc Alexander 2023-04-30 16:54:24 +02:00
parent d2e14f5d5d
commit 860598026b
No known key found for this signature in database
GPG key ID: 50E0D2423696F995
2 changed files with 2 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
phpBB/includes/acp/acp_board.php
View file

@ -48,12 +48,6 @@ class acp_board
global $config, $phpbb_root_path, $phpEx; global $config, $phpbb_root_path, $phpEx;
global $cache, $phpbb_container, $phpbb_dispatcher, $phpbb_log; global $cache, $phpbb_container, $phpbb_dispatcher, $phpbb_log;
if (!$language)
{
/** @var language $language Language object */
$language = $phpbb_container->get('language');
}
$this->config = $config; $this->config = $config;
$this->language = $language; $this->language = $language;
$this->user = $user; $this->user = $user;
@ -1071,9 +1065,7 @@ class acp_board
*/ */
function timezone_select($value, $key) function timezone_select($value, $key)
{ {
global $user; $timezone_select = phpbb_timezone_select($this->user, $value, true);
$timezone_select = phpbb_timezone_select($user, $value, true);
return [ return [
'tag' => 'select', 'tag' => 'select',

2
phpBB/includes/functions_acp.php
View file

@ -368,7 +368,7 @@ function phpbb_build_cfg_template(array $tpl_type, string $key, &$new_ary, $conf
case 'radio': case 'radio':
$tpl_type_cond = explode('_', $tpl_type[1]); $tpl_type_cond = explode('_', $tpl_type[1]);
$type_no = !(($tpl_type_cond[0] == 'disabled' || $tpl_type_cond[0] == 'enabled')); $type_no = $tpl_type_cond[0] != 'disabled' && $tpl_type_cond[0] != 'enabled';
$no_button = [ $no_button = [
'type' => 'radio', 'type' => 'radio',