makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-16 15:08:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/17524] Fix tests

Browse source 
PHPBB-17524
This commit is contained in:
rxu 2025-07-06 09:00:39 +07:00
parent 967a7349da
commit 868b5350f7
No known key found for this signature in database
GPG key ID: 955F0567380E586A
1 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
tests/dbal/migrator_test.php
View file

@ -57,11 +57,12 @@ class phpbb_dbal_migrator_test extends phpbb_database_test_case
parent::setUp();
$this->table_prefix = $table_prefix;
$this->db = $this->new_dbal();
$this->doctrine_db = $this->new_doctrine_dbal();
$factory = new \phpbb\db\tools\factory();
$this->db_tools = $factory->get($this->doctrine_db);
$this->db_tools->set_table_prefix($table_prefix);
$this->db_tools->set_table_prefix($this->table_prefix);
$this->config = new \phpbb\config\db($this->db, new phpbb_mock_cache, 'phpbb_config');
@ -412,21 +413,24 @@ class phpbb_dbal_migrator_test extends phpbb_database_test_case
$this->assertTrue($this->db_tools->sql_column_exists('phpbb_config', 'test_column1'));
$this->assertTrue($this->db_tools->sql_table_exists('phpbb_foobar'));
$short_table_name = \phpbb\db\doctrine\table_helper::generate_shortname('foobar');
$index_data_row = $this->db_tools->sql_get_table_index_data('phpbb_foobar');
$this->assertEquals(4, count($index_data_row));
$this->assertTrue(isset($index_data_row['i_simple']));
$this->assertTrue(isset($index_data_row['i_uniq']));
$this->assertTrue(isset($index_data_row['i_auth']));
$this->assertTrue(isset($index_data_row[$short_table_name . '_i_simple']));
$this->assertTrue(isset($index_data_row[$short_table_name . '_i_uniq']));
$this->assertTrue(isset($index_data_row[$short_table_name . '_i_auth']));
$is_mysql = $this->db->get_sql_layer() === 'mysqli'; // Key 'lengths' option only applies to MySQL indexes
// MSSQL primary index key has 'clustered' flag, 'nonclustered' otherwise
// See https://learn.microsoft.com/en-us/sql/relational-databases/indexes/clustered-and-nonclustered-indexes-described?view=sql-server-ver17#indexes-and-constraints
$is_mssql = in_array($this->db->get_sql_layer(), ['mssqlnative', 'mssql_odbc']);
foreach ($index_data_row as $index_name => $index_data)
{
switch ($index_name)
{
case 'i_simple':
case $short_table_name . '_i_simple':
$this->assertEquals(['user_id', 'endpoint'], $index_data['columns']);
$this->assertEquals($is_mssql ? ['nonclustered'] : [], $index_data['flags']);
$this->assertFalse($index_data['is_primary']);
@ -436,7 +440,7 @@ class phpbb_dbal_migrator_test extends phpbb_database_test_case
$this->assertEmpty($index_data['options']['lengths'][0]);
$this->assertEquals($is_mysql ? 191 : null, $index_data['options']['lengths'][1]);
break;
case 'i_uniq':
case $short_table_name . '_i_uniq':
$this->assertEquals(['expiration_time', 'p256dh'], $index_data['columns']);
$this->assertEquals($is_mssql ? ['nonclustered'] : [], $index_data['flags']);
$this->assertFalse($index_data['is_primary']);
@ -446,7 +450,7 @@ class phpbb_dbal_migrator_test extends phpbb_database_test_case
$this->assertEmpty($index_data['options']['lengths'][0]);
$this->assertEquals($is_mysql ? 100 : null, $index_data['options']['lengths'][1]);
break;
case 'i_auth':
case $short_table_name . '_i_auth':
$this->assertEquals(['auth'], $index_data['columns']);
$this->assertEquals($is_mssql ? ['nonclustered'] : [], $index_data['flags']);
$this->assertFalse($index_data['is_primary']);