[ticket/11538] Move group ID into abstract test class and add more test cases

The group ID is defined in the abstract class now and additional test cases
for hex colour values have been added.

PHPBB3-11538
This commit is contained in:
Marc Alexander 2013-05-19 11:44:26 +02:00
parent 373e26ca74
commit 8aea2b382d
3 changed files with 7 additions and 3 deletions

View file

@ -16,6 +16,6 @@ class phpbb_functional_acp_groups_test extends phpbb_functional_common_groups_te
{
protected function get_url()
{
return 'adm/index.php?i=groups&mode=manage&action=edit&g=5';
return 'adm/index.php?i=groups&mode=manage&action=edit';
}
}

View file

@ -20,6 +20,7 @@ abstract class phpbb_functional_common_groups_test extends phpbb_functional_test
array('#AA0000', 'WRONG_DATA_COLOUR'),
array('AA0000', 'GROUP_UPDATED'),
array('AA0000v', 'WRONG_DATA_COLOUR'),
array('AA00000', 'WRONG_DATA_COLOUR'),
array('vAA0000', 'WRONG_DATA_COLOUR'),
array('AAG000','WRONG_DATA_COLOUR'),
array('a00', 'GROUP_UPDATED'),
@ -28,6 +29,8 @@ abstract class phpbb_functional_common_groups_test extends phpbb_functional_test
array('AA0000 ', 'GROUP_UPDATED'),
array('AA0000 abf', 'WRONG_DATA_COLOUR'),
array('AA0000 AA0000', 'WRONG_DATA_COLOUR'),
array('000 ', 'GROUP_UPDATED'),
array('000000 ', 'GROUP_UPDATED'),
);
}
@ -40,7 +43,8 @@ abstract class phpbb_functional_common_groups_test extends phpbb_functional_test
$this->admin_login();
$this->add_lang(array('ucp', 'acp/groups'));
$crawler = $this->request('GET', $this->get_url() . '&sid=' . $this->sid);
// Manage Administrators group
$crawler = $this->request('GET', $this->get_url() . '&g=5&sid=' . $this->sid);
$this->assert_response_success();
$form = $crawler->selectButton($this->lang('SUBMIT'))->form();
$form['group_colour']->setValue($input);

View file

@ -16,6 +16,6 @@ class phpbb_functional_ucp_groups_test extends phpbb_functional_common_groups_te
{
protected function get_url()
{
return 'ucp.php?i=groups&mode=manage&action=edit&g=5';
return 'ucp.php?i=groups&mode=manage&action=edit';
}
}