makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 22:28:51 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/16078] Use while loop for visit retries

Browse source 
PHPBB3-16078
This commit is contained in:
Marc Alexander 2019-10-20 15:51:47 +02:00
parent 1ba0ae6e85
commit 8b6776eed2
No known key found for this signature in database
GPG key ID: 50E0D2423696F995
1 changed files with 10 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
tests/test_framework/phpbb_ui_test_case.php
View file

@ -159,20 +159,23 @@ class phpbb_ui_test_case extends phpbb_test_case
public function visit($path) public function visit($path)
{ {
// Retry three times on curl issues, e.g. timeout // Retry three times on curl issues, e.g. timeout
try $attempts = 0;
{ $retries = 3;
$this->getDriver()->get(self::$root_url . $path);
} while (true)
catch (Facebook\WebDriver\Exception\WebDriverCurlException $exception)
{ {
$attempts++;
try try
{ {
$this->getDriver()->get(self::$root_url . $path); $this->getDriver()->get(self::$root_url . $path);
break;
} }
catch (Facebook\WebDriver\Exception\WebDriverCurlException $exception) catch (Facebook\WebDriver\Exception\WebDriverCurlException $exception)
{ {
// Last try, throw exception after this one fails if ($attempts >= $retries)
$this->getDriver()->get(self::$root_url . $path); {
throw $exception;
}
} }
} }
} }