makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 22:28:51 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/10270] Recoded some potentially buggy code in phpbb.confirm.

Browse source 
The code before could have removed event handlers defined by other code.

PHPBB3-10270
This commit is contained in:
Callum Macrae 2011-11-17 17:09:09 +00:00 • committed by Igor Wiedler
parent 885c2914db
commit 8da463ac9e
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
phpBB/assets/javascript/core.js
View file

@ -124,21 +124,22 @@ phpbb.confirm = function(msg, callback, fadedark) {
e.stopPropagation(); e.stopPropagation();
return true; return true;
}); });
div.find('input[type="button"]').one('click', function() {
var click_handler = function() {
var res = this.className === 'button1'; var res = this.className === 'button1';
var fade = (typeof fadedark !== 'undefined' && !fadedark && res) ? div : dark; var fade = (typeof fadedark !== 'undefined' && !fadedark && res) ? div : dark;
fade.fadeOut(phpbb.alert_time, function() { fade.fadeOut(phpbb.alert_time, function() {
div.hide(); div.hide();
}); });
div.find('input[type="button"]').unbind('click'); div.find('input[type="button"]').unbind('click', click_handler);
callback(res); callback(res);
return false; return false;
}); };
div.find('input[type="button"]').one('click', click_handler);
dark.one('click', function(e) { dark.one('click', function(e) {
div.find('.alert_close').unbind('click'); div.find('.alert_close').unbind('click');
var fade = (typeof fadedark !== 'undefined' && !fadedark && res) ? div : dark; dark.fadeOut(phpbb.alert_time, function() {
fade.fadeOut(phpbb.alert_time, function() {
div.hide(); div.hide();
}); });
callback(false); callback(false);