makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 14:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/10605] Remove unnecessary array_keys calls on $delete_rows.

Browse source 
PHPBB3-10605
This commit is contained in:
Andreas Fischer 2012-03-27 01:35:01 +02:00
parent dbc7a69ad2
commit 9040f18d7c
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
phpBB/includes/functions_privmsgs.php
View file

@ -1123,7 +1123,7 @@ function phpbb_delete_user_pms($user_id)
} }
} }
$delete_rows[$row['msg_id']] = true; $delete_rows[(int) $row['msg_id']] = (int) $row['msg_id'];
} }
$db->sql_freeresult($result); $db->sql_freeresult($result);
@ -1154,13 +1154,13 @@ function phpbb_delete_user_pms($user_id)
// Delete private message data // Delete private message data
$sql = 'DELETE FROM ' . PRIVMSGS_TO_TABLE . " $sql = 'DELETE FROM ' . PRIVMSGS_TO_TABLE . "
WHERE user_id = $user_id WHERE user_id = $user_id
AND " . $db->sql_in_set('msg_id', array_keys($delete_rows)); AND " . $db->sql_in_set('msg_id', $delete_rows);
$db->sql_query($sql); $db->sql_query($sql);
// Now we have to check which messages we can delete completely // Now we have to check which messages we can delete completely
$sql = 'SELECT msg_id $sql = 'SELECT msg_id
FROM ' . PRIVMSGS_TO_TABLE . ' FROM ' . PRIVMSGS_TO_TABLE . '
WHERE ' . $db->sql_in_set('msg_id', array_keys($delete_rows)); WHERE ' . $db->sql_in_set('msg_id', $delete_rows);
$result = $db->sql_query($sql); $result = $db->sql_query($sql);
while ($row = $db->sql_fetchrow($result)) while ($row = $db->sql_fetchrow($result))