makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-07 20:08:53 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/15683] Better error message when commit message has CRLF

Browse source 
When someone tries to do a pull request with incorrect line breaks in the
commit message, the error message as given by Travis is "Unexpected EOF
encountered". The error message should be clearer that CR/LF was the
problem. This change adds a separate check for CRLF line endings.

PHPBB3-15683
This commit is contained in:
Anssi Johansson 2018-06-05 22:20:19 +03:00
parent b5a79d9a9d
commit 9068909051
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
git-tools/hooks/commit-msg
View file

@ -147,6 +147,15 @@ then
quit $ERR_LENGTH; quit $ERR_LENGTH;
fi fi
# Check for CR/LF line breaks
if grep -q $'\r$' "$1"
then
complain "The commit message uses CR/LF line breaks, which are not permitted." >&2
complain >&2
quit $ERR_EOF;
fi
lines=$(wc -l "$1" | awk '{ print $1; }'); lines=$(wc -l "$1" | awk '{ print $1; }');
expecting=header; expecting=header;
in_description=0; in_description=0;