makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 06:08:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/14492] Correctly check if extension was enabled during install

Browse source 
Also fixed some incorrectly generated log messages and improved the
regex.

PHPBB3-14492
This commit is contained in:
Marc Alexander 2016-02-04 09:45:32 +01:00
parent c07ecb060d
commit 90a5e22eb5
No known key found for this signature in database
GPG key ID: 50E0D2423696F995
1 changed files with 38 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
phpBB/phpbb/install/module/install_finish/task/install_extensions.php
View file

@ -49,6 +49,12 @@ class install_extensions extends \phpbb\install\task_base
/** @var \Symfony\Component\Finder\Finder */ /** @var \Symfony\Component\Finder\Finder */
protected $finder; protected $finder;
/** @var string Extension table */
protected $extension_table;
/** @var \phpbb\db\driver\driver_interface */
protected $db;
/** /**
* Constructor * Constructor
* *
@ -61,11 +67,13 @@ class install_extensions extends \phpbb\install\task_base
{ {
$this->install_config = $install_config; $this->install_config = $install_config;
$this->iohandler = $iohandler; $this->iohandler = $iohandler;
$this->extension_table = $container->get_parameter('tables.ext');
$this->log = $container->get('log'); $this->log = $container->get('log');
$this->user = $container->get('user'); $this->user = $container->get('user');
$this->extension_manager = $container->get('ext.manager'); $this->extension_manager = $container->get('ext.manager');
$this->config = $container->get('config'); $this->config = $container->get('config');
$this->db = $container->get('dbal.conn');
$this->finder = new \Symfony\Component\Finder\Finder(); $this->finder = new \Symfony\Component\Finder\Finder();
$this->finder->in($phpbb_root_path . 'ext/') $this->finder->in($phpbb_root_path . 'ext/')
->ignoreUnreadableDirs() ->ignoreUnreadableDirs()
@ -101,14 +109,14 @@ class install_extensions extends \phpbb\install\task_base
foreach ($this->finder as $file) foreach ($this->finder as $file)
{ {
/** @var \SplFileInfo $file */ /** @var \SplFileInfo $file */
$ext_name = preg_replace('#(.+ext[\\/\\\])#', '', dirname($file->getRealPath())); $ext_name = preg_replace('#(.+[\\/\\\]ext[\\/\\\])([^\\/\\\]+)[\\/\\\]([^\\/\\\]+)#', '$2/$3', dirname($file->getRealPath()));
if ($this->extension_manager->is_available($ext_name)) if ($this->extension_manager->is_available($ext_name))
{ {
$this->extension_manager->enable($ext_name); $this->extension_manager->enable($ext_name);
$this->extension_manager->load_extensions(); $extensions = $this->get_extensions();
if (!$this->extension_manager->is_enabled($ext_name)) if (isset($extensions[$ext_name]) && $extensions[$ext_name]['ext_active'])
{ {
// Create log // Create log
$this->log->add('admin', ANONYMOUS, '', 'LOG_EXT_ENABLE', time(), array($ext_name)); $this->log->add('admin', ANONYMOUS, '', 'LOG_EXT_ENABLE', time(), array($ext_name));
@ -116,7 +124,7 @@ class install_extensions extends \phpbb\install\task_base
} }
else else
{ {
$this->iohandler->add_log_message('CLI_EXTENSION_ENABLE_FAILURE', array($ext_name)); $this->iohandler->add_log_message(array('CLI_EXTENSION_ENABLE_FAILURE', $ext_name));
} }
} }
} }
@ -136,4 +144,30 @@ class install_extensions extends \phpbb\install\task_base
{ {
return 'TASK_INSTALL_EXTENSIONS'; return 'TASK_INSTALL_EXTENSIONS';
} }
/**
* Get extensions from database
*
* @return array List of extensions
*/
private function get_extensions()
{
$sql = 'SELECT *
FROM ' . $this->extension_table;
$result = $this->db->sql_query($sql);
$extensions_row = $this->db->sql_fetchrowset($result);
$this->db->sql_freeresult($result);
$extensions = array();
foreach ($extensions_row as $extension)
{
$extensions[$extension['ext_name']] = $extension;
}
ksort($extensions);
return $extensions;
}
} }