[ticket/14891] Don't rely on sys_get_temp_dir() being available

Or actually returning a path. It might also return an empty string
or null.

PHPBB3-14891
This commit is contained in:
Marc Alexander 2016-12-09 11:32:13 +01:00
parent 6a568719d0
commit 90b59bb547

View file

@ -47,8 +47,8 @@ class proxy_instantiator implements InstantiatorInterface
// restrictions being in effect // restrictions being in effect
$ini_wrapper = new IniGetWrapper(); $ini_wrapper = new IniGetWrapper();
$filesystem = new filesystem(); $filesystem = new filesystem();
$tmp_dir = sys_get_temp_dir(); $tmp_dir = (function_exists('sys_get_temp_dir')) ? sys_get_temp_dir() : '';
if ($ini_wrapper->getString('open_basedir') && if (empty($tmp_dir) || $ini_wrapper->getString('open_basedir') &&
(!$filesystem->exists($tmp_dir) || !$filesystem->is_writable($tmp_dir))) (!$filesystem->exists($tmp_dir) || !$filesystem->is_writable($tmp_dir)))
{ {
$config->setProxiesTargetDir($cache_dir); $config->setProxiesTargetDir($cache_dir);