makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-29 06:38:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/13809] Test each file individually

Browse source 
PHPBB3-13809
This commit is contained in:
Joas Schilling 2015-05-03 14:35:04 +02:00
parent b73b9f1dec
commit 923fdb0aa0
1 changed files with 28 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

49
tests/lint_test.php
View file

@ -38,31 +38,34 @@ class phpbb_lint_test extends phpbb_test_case
self::markTestSkipped(sprintf('Could not run PHP_BINARY %s. Output: %s', self::$php_binary, $output)); self::markTestSkipped(sprintf('Could not run PHP_BINARY %s. Output: %s', self::$php_binary, $output));
} }
} }
self::$exclude = array(
dirname(__FILE__) . '/../.git',
dirname(__FILE__) . '/../build/new_version',
dirname(__FILE__) . '/../build/old_versions',
dirname(__FILE__) . '/../phpBB/cache',
// PHP Fatal error: Cannot declare class Container because the name is already in use in /var/www/projects/phpbb3/tests/../phpBB/vendor/symfony/dependency-injection/Symfony/Component/DependencyInjection/Tests/Fixtures/php/services1-1.php on line 20
// https://gist.github.com/e003913ffd493da63cbc
dirname(__FILE__) . '/../phpBB/vendor',
);
} }
public function test_lint() /**
* @dataProvider lint_data
*/
public function test_lint($path)
{ {
if (version_compare(PHP_VERSION, '5.3.0', '<')) if (version_compare(PHP_VERSION, '5.3.0', '<'))
{ {
$this->markTestSkipped('phpBB uses PHP 5.3 syntax in some files, linting on PHP < 5.3 will fail'); $this->markTestSkipped('phpBB uses PHP 5.3 syntax in some files, linting on PHP < 5.3 will fail');
} }
$root = dirname(__FILE__) . '/..'; $cmd = sprintf('(%s -l %s) 2>&1', self::$php_binary, escapeshellarg($path));
$this->check($root); $output = array();
$status = 1;
exec($cmd, $output, $status);
$output = implode("\n", $output);
$this->assertEquals(0, $status, "PHP lint failed for $path:\n$output");
}
public function lint_data()
{
return $this->check(dirname(__FILE__) . '/..');
} }
protected function check($root) protected function check($root)
{ {
$files = array();
$dh = opendir($root); $dh = opendir($root);
while (($filename = readdir($dh)) !== false) while (($filename = readdir($dh)) !== false)
{ {
@ -76,19 +79,23 @@ class phpbb_lint_test extends phpbb_test_case
{ {
continue; continue;
} }
if (is_dir($path) && !in_array($path, self::$exclude)) if (is_dir($path) && !in_array($path, array(
dirname(__FILE__) . '/../.git',
dirname(__FILE__) . '/../build/new_version',
dirname(__FILE__) . '/../build/old_versions',
dirname(__FILE__) . '/../phpBB/cache',
// PHP Fatal error: Cannot declare class Container because the name is already in use in /var/www/projects/phpbb3/tests/../phpBB/vendor/symfony/dependency-injection/Symfony/Component/DependencyInjection/Tests/Fixtures/php/services1-1.php on line 20
// https://gist.github.com/e003913ffd493da63cbc
dirname(__FILE__) . '/../phpBB/vendor',
)))
{ {
$this->check($path); $files = array_merge($files, $this->check($path));
} }
else if (substr($filename, strlen($filename)-4) == '.php') else if (substr($filename, strlen($filename)-4) == '.php')
{ {
$cmd = sprintf('(%s -l %s) 2>&1', self::$php_binary, escapeshellarg($path)); $files[] = array($path);
$output = array();
$status = 1;
exec($cmd, $output, $status);
$output = implode("\n", $output);
$this->assertEquals(0, $status, "PHP lint failed for $path:\n$output");
} }
} }
return $files;
} }
} }