From 9363986f43aeb6ff6b5f9627eb42aee1ea2eaf57 Mon Sep 17 00:00:00 2001 From: Matt Friedman Date: Tue, 15 Oct 2013 10:27:00 -0700 Subject: [PATCH] [ticket/11921] Improve appearance of Notifications in linklist PHPBB3-11921 --- phpBB/language/en/common.php | 6 +----- phpBB/styles/prosilver/theme/bidi.css | 2 +- phpBB/styles/prosilver/theme/buttons.css | 4 ++-- phpBB/styles/prosilver/theme/colours.css | 1 + phpBB/styles/prosilver/theme/common.css | 14 -------------- .../prosilver/theme/images/icon_notification.gif | Bin 0 -> 614 bytes .../subsilver2/template/overall_header.html | 8 ++++---- .../theme/images/icon_mini_notification.gif | Bin 0 -> 321 bytes 8 files changed, 9 insertions(+), 26 deletions(-) create mode 100644 phpBB/styles/prosilver/theme/images/icon_notification.gif create mode 100644 phpBB/styles/subsilver2/theme/images/icon_mini_notification.gif diff --git a/phpBB/language/en/common.php b/phpBB/language/en/common.php index e5c0478d98..d04fe96d97 100644 --- a/phpBB/language/en/common.php +++ b/phpBB/language/en/common.php @@ -417,11 +417,7 @@ $lang = array_merge($lang, array( 'NOT_WATCHING_FORUM' => 'You are no longer subscribed to updates on this forum.', 'NOT_WATCHING_TOPIC' => 'You are no longer subscribed to this topic.', 'NOTIFICATIONS' => 'Notifications', - 'NOTIFICATIONS_COUNT' => array( - 0 => '%d Notifications', - 1 => '%d Notification', - 2 => '%d Notifications', - ), + 'NOTIFICATIONS_COUNT' => 'Notifications (%d)', 'NOTIFICATION_BOOKMARK' => '%1$s replied to the topic "%2$s" you have bookmarked.', 'NOTIFICATION_GROUP_REQUEST' => '%1$s is requesting to join the group %2$s.', 'NOTIFICATION_GROUP_REQUEST_APPROVED' => 'Your request to join the group %1$s has been approved.', diff --git a/phpBB/styles/prosilver/theme/bidi.css b/phpBB/styles/prosilver/theme/bidi.css index 41a9874a18..c5b72e913e 100644 --- a/phpBB/styles/prosilver/theme/bidi.css +++ b/phpBB/styles/prosilver/theme/bidi.css @@ -535,7 +535,7 @@ /* Icon images ---------------------------------------- */ .rtl .sitehome, .rtl .icon-faq, .rtl .icon-members, .rtl .icon-home, .rtl .icon-ucp, .rtl .icon-register, .rtl .icon-logout, -.rtl .icon-bookmark, .rtl .icon-bump, .rtl .icon-subscribe, .rtl .icon-unsubscribe, .rtl .icon-pages, .rtl .icon-search { +.rtl .icon-bookmark, .rtl .icon-bump, .rtl .icon-subscribe, .rtl .icon-unsubscribe, .rtl .icon-pages, .rtl .icon-search, .rtl .icon-notification { background-position: 100% 50%; padding: 1px 17px 0 0; } diff --git a/phpBB/styles/prosilver/theme/buttons.css b/phpBB/styles/prosilver/theme/buttons.css index 3860869501..d83fefcef3 100644 --- a/phpBB/styles/prosilver/theme/buttons.css +++ b/phpBB/styles/prosilver/theme/buttons.css @@ -91,14 +91,14 @@ a.sendemail { /* Icon images ---------------------------------------- */ .sitehome, .icon-faq, .icon-members, .icon-home, .icon-ucp, .icon-register, .icon-logout, -.icon-bookmark, .icon-bump, .icon-subscribe, .icon-unsubscribe, .icon-pages, .icon-search { +.icon-bookmark, .icon-bump, .icon-subscribe, .icon-unsubscribe, .icon-pages, .icon-search, .icon-notification { background-position: 0 50%; background-repeat: no-repeat; background-image: none; padding: 1px 0 0 17px; } -ul.linklist.bulletin li.icon-home:before, ul.linklist.bulletin li.icon-ucp:before, +ul.linklist.bulletin li.icon-home:before, ul.linklist.bulletin li.icon-ucp:before, ul.linklist.bulletin li.icon-notification:before, ul.linklist.bulletin li.icon-bookmark:before, ul.linklist.bulletin li.icon-bump:before, ul.linklist.bulletin li.icon-subscribe:before, ul.linklist.bulletin li.icon-unsubscribe:before { display: none; } diff --git a/phpBB/styles/prosilver/theme/colours.css b/phpBB/styles/prosilver/theme/colours.css index 08123fd9e8..40311f95fe 100644 --- a/phpBB/styles/prosilver/theme/colours.css +++ b/phpBB/styles/prosilver/theme/colours.css @@ -707,6 +707,7 @@ a.sendemail { .icon-unsubscribe { background-image: url("./images/icon_unsubscribe.gif"); } .icon-pages { background-image: url("./images/icon_pages.gif"); } .icon-search { background-image: url("./images/icon_search.gif"); } +.icon-notification { background-image: url("./images/icon_notification.gif"); } /* Profile & navigation icons */ .email-icon, .email-icon a { background-image: url("./images/icon_contact_email.gif"); } diff --git a/phpBB/styles/prosilver/theme/common.css b/phpBB/styles/prosilver/theme/common.css index 9021c157a3..4dbcc6f455 100644 --- a/phpBB/styles/prosilver/theme/common.css +++ b/phpBB/styles/prosilver/theme/common.css @@ -378,20 +378,6 @@ ul.linklist.bulletin li.no-bulletin:before { display: none; } -.icon-notification:before, ul.linklist.bulletin li.icon-notification:before, .icon-notification:after { - display: inline; - font: inherit; -} - -.icon-notification:before, ul.linklist.bulletin li.icon-notification:before { - content: '['; - padding-right: 0; -} - -.icon-notification:after { - content: ']'; -} - /* Table styles ----------------------------------------*/ table.table1 { diff --git a/phpBB/styles/prosilver/theme/images/icon_notification.gif b/phpBB/styles/prosilver/theme/images/icon_notification.gif new file mode 100644 index 0000000000000000000000000000000000000000..0eca47843d18a16ccfb9bbc7f5d6b4ad02701527 GIT binary patch literal 614 zcmZ?wbhEHb6ky7?od(L#KkRp4(~W|edFOvtF|57c;w2Y*^9Ow zyK?&aqt~B)oVfaM-S&NpHtySf?q12lgKxk5IDGN$*PnmR-~agf)3@zMFYG*YV(FIs z?Q2h*zxjCUo|Aw6{-3ku%#Iy9b{@a{_u@7H=-F^A-)3;xf<}I7L?c9GbU>LGM@h1x-1A`-j4#)?fIALHv+~6psF3zUO zCNJN{Cax~!=xD%WZEb5iW!e-Tg9#GaW_*I|i`fPF%(NvYh{-Z=FxhXkXX0Rx6`LR` zy>7#%Eez74j;0FAmWo=N?6njvl@&}iO!QbStxj24vg(;=2pBp%yk_;p@}YyFfC#sZ zjRh<7M`l)wx7;F(4sR_~Isb90zWT@@bbxsRyOGL+83&q^2j(XIyp#`)o0pyCF^^+mVz34PuOihy literal 0 HcmV?d00001 diff --git a/phpBB/styles/subsilver2/template/overall_header.html b/phpBB/styles/subsilver2/template/overall_header.html index 7bfb85017a..1693b8424f 100644 --- a/phpBB/styles/subsilver2/template/overall_header.html +++ b/phpBB/styles/subsilver2/template/overall_header.html @@ -152,7 +152,7 @@ function marklist(id, name, state) - [ {NOTIFICATIONS_COUNT} ]  + * {NOTIFICATIONS_COUNT} 
{L_NOTIFICATIONS} @@ -191,15 +191,15 @@ function marklist(id, name, state)
- * {L_LOGIN_LOGOUT}  -  * {L_RESTORE_PERMISSIONS} -  {L_BOARD_DISABLED}  * {PRIVATE_MESSAGE_INFO}, {PRIVATE_MESSAGE_INFO_UNREAD}  * {L_REGISTER} +  * {L_LOGIN_LOGOUT}  +  * {L_RESTORE_PERMISSIONS} +  {L_BOARD_DISABLED} * {L_FAQ} diff --git a/phpBB/styles/subsilver2/theme/images/icon_mini_notification.gif b/phpBB/styles/subsilver2/theme/images/icon_mini_notification.gif new file mode 100644 index 0000000000000000000000000000000000000000..8ff818325aca80e1d781722cc6ae77a982cb289b GIT binary patch literal 321 zcmZ?wbhEHbC>l4yUuB+_b2zSee>?UQbJeZ%q{Kf4&Q$ICV%?oA3uJ4 z|M}Y_cXHX>?G^L3&)sqA