makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-08 04:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/12612] Prefix check_ids() with phpbb_

Browse source 
PHPBB3-12612
This commit is contained in:
Joas Schilling 2014-06-23 23:01:52 +02:00
parent 4ac43856f7
commit 952b4de231
6 changed files with 17 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
phpBB/includes/functions_mcp.php
View file

@ -594,7 +594,7 @@ function phpbb_mcp_sorting($mode, &$sort_days, &$sort_key, &$sort_dir, &$sort_by
* Additionally, this value can be the forum_id assigned if $single_forum was set. * Additionally, this value can be the forum_id assigned if $single_forum was set.
* Therefore checking the result for with !== false is the best method. * Therefore checking the result for with !== false is the best method.
*/ */
function check_ids(&$ids, $table, $sql_id, $acl_list = false, $single_forum = false) function phpbb_check_ids(&$ids, $table, $sql_id, $acl_list = false, $single_forum = false)
{ {
global $db, $auth; global $db, $auth;

4
phpBB/includes/mcp/mcp_forum.php
View file

@ -328,7 +328,7 @@ function mcp_resync_topics($topic_ids)
trigger_error('NO_TOPIC_SELECTED'); trigger_error('NO_TOPIC_SELECTED');
} }
if (!check_ids($topic_ids, TOPICS_TABLE, 'topic_id', array('m_'))) if (!phpbb_check_ids($topic_ids, TOPICS_TABLE, 'topic_id', array('m_')))
{ {
return; return;
} }
@ -420,7 +420,7 @@ function merge_topics($forum_id, $topic_ids, $to_topic_id)
return; return;
} }
if (!check_ids($post_id_list, POSTS_TABLE, 'post_id', array('m_merge'))) if (!phpbb_check_ids($post_id_list, POSTS_TABLE, 'post_id', array('m_merge')))
{ {
return; return;
} }

16
phpBB/includes/mcp/mcp_main.php
View file

@ -252,7 +252,7 @@ function lock_unlock($action, $ids)
$orig_ids = $ids; $orig_ids = $ids;
if (!check_ids($ids, $table, $sql_id, array('m_lock'))) if (!phpbb_check_ids($ids, $table, $sql_id, array('m_lock')))
{ {
// Make sure that for f_user_lock only the lock action is triggered. // Make sure that for f_user_lock only the lock action is triggered.
if ($action != 'lock') if ($action != 'lock')
@ -262,7 +262,7 @@ function lock_unlock($action, $ids)
$ids = $orig_ids; $ids = $orig_ids;
if (!check_ids($ids, $table, $sql_id, array('f_user_lock'))) if (!phpbb_check_ids($ids, $table, $sql_id, array('f_user_lock')))
{ {
return; return;
} }
@ -346,7 +346,7 @@ function change_topic_type($action, $topic_ids)
break; break;
} }
$forum_id = check_ids($topic_ids, TOPICS_TABLE, 'topic_id', $check_acl, true); $forum_id = phpbb_check_ids($topic_ids, TOPICS_TABLE, 'topic_id', $check_acl, true);
if ($forum_id === false) if ($forum_id === false)
{ {
@ -422,7 +422,7 @@ function mcp_move_topic($topic_ids)
global $phpEx, $phpbb_root_path; global $phpEx, $phpbb_root_path;
// Here we limit the operation to one forum only // Here we limit the operation to one forum only
$forum_id = check_ids($topic_ids, TOPICS_TABLE, 'topic_id', array('m_move'), true); $forum_id = phpbb_check_ids($topic_ids, TOPICS_TABLE, 'topic_id', array('m_move'), true);
if ($forum_id === false) if ($forum_id === false)
{ {
@ -677,7 +677,7 @@ function mcp_restore_topic($topic_ids)
{ {
global $auth, $user, $db, $phpEx, $phpbb_root_path, $request, $phpbb_container; global $auth, $user, $db, $phpEx, $phpbb_root_path, $request, $phpbb_container;
if (!check_ids($topic_ids, TOPICS_TABLE, 'topic_id', array('m_approve'))) if (!phpbb_check_ids($topic_ids, TOPICS_TABLE, 'topic_id', array('m_approve')))
{ {
return; return;
} }
@ -750,7 +750,7 @@ function mcp_delete_topic($topic_ids, $is_soft = false, $soft_delete_reason = ''
{ {
global $auth, $user, $db, $phpEx, $phpbb_root_path, $request, $phpbb_container; global $auth, $user, $db, $phpEx, $phpbb_root_path, $request, $phpbb_container;
if (!check_ids($topic_ids, TOPICS_TABLE, 'topic_id', array('m_delete'))) if (!phpbb_check_ids($topic_ids, TOPICS_TABLE, 'topic_id', array('m_delete')))
{ {
return; return;
} }
@ -878,7 +878,7 @@ function mcp_delete_post($post_ids, $is_soft = false, $soft_delete_reason = '',
{ {
global $auth, $user, $db, $phpEx, $phpbb_root_path, $request, $phpbb_container; global $auth, $user, $db, $phpEx, $phpbb_root_path, $request, $phpbb_container;
if (!check_ids($post_ids, POSTS_TABLE, 'post_id', array('m_softdelete'))) if (!phpbb_check_ids($post_ids, POSTS_TABLE, 'post_id', array('m_softdelete')))
{ {
return; return;
} }
@ -1105,7 +1105,7 @@ function mcp_fork_topic($topic_ids)
global $auth, $user, $db, $template, $config; global $auth, $user, $db, $template, $config;
global $phpEx, $phpbb_root_path; global $phpEx, $phpbb_root_path;
if (!check_ids($topic_ids, TOPICS_TABLE, 'topic_id', array('m_'))) if (!phpbb_check_ids($topic_ids, TOPICS_TABLE, 'topic_id', array('m_')))
{ {
return; return;
} }

6
phpBB/includes/mcp/mcp_queue.php
View file

@ -572,7 +572,7 @@ class mcp_queue
global $db, $template, $user, $config, $request, $phpbb_container; global $db, $template, $user, $config, $request, $phpbb_container;
global $phpEx, $phpbb_root_path; global $phpEx, $phpbb_root_path;
if (!check_ids($post_id_list, POSTS_TABLE, 'post_id', array('m_approve'))) if (!phpbb_check_ids($post_id_list, POSTS_TABLE, 'post_id', array('m_approve')))
{ {
trigger_error('NOT_AUTHORISED'); trigger_error('NOT_AUTHORISED');
} }
@ -795,7 +795,7 @@ class mcp_queue
global $db, $template, $user, $config; global $db, $template, $user, $config;
global $phpEx, $phpbb_root_path, $request, $phpbb_container; global $phpEx, $phpbb_root_path, $request, $phpbb_container;
if (!check_ids($topic_id_list, TOPICS_TABLE, 'topic_id', array('m_approve'))) if (!phpbb_check_ids($topic_id_list, TOPICS_TABLE, 'topic_id', array('m_approve')))
{ {
trigger_error('NOT_AUTHORISED'); trigger_error('NOT_AUTHORISED');
} }
@ -964,7 +964,7 @@ class mcp_queue
global $db, $template, $user, $config, $phpbb_container; global $db, $template, $user, $config, $phpbb_container;
global $phpEx, $phpbb_root_path, $request; global $phpEx, $phpbb_root_path, $request;
if (!check_ids($post_id_list, POSTS_TABLE, 'post_id', array('m_approve'))) if (!phpbb_check_ids($post_id_list, POSTS_TABLE, 'post_id', array('m_approve')))
{ {
trigger_error('NOT_AUTHORISED'); trigger_error('NOT_AUTHORISED');
} }

2
phpBB/includes/mcp/mcp_reports.php
View file

@ -479,7 +479,7 @@ function close_report($report_id_list, $mode, $action, $pm = false)
} }
else else
{ {
if (!check_ids($post_id_list, POSTS_TABLE, 'post_id', array('m_report'))) if (!phpbb_check_ids($post_id_list, POSTS_TABLE, 'post_id', array('m_report')))
{ {
trigger_error('NOT_AUTHORISED'); trigger_error('NOT_AUTHORISED');
} }

4
phpBB/includes/mcp/mcp_topic.php
View file

@ -368,7 +368,7 @@ function split_topic($action, $topic_id, $to_forum_id, $subject)
return; return;
} }
if (!check_ids($post_id_list, POSTS_TABLE, 'post_id', array('m_split'))) if (!phpbb_check_ids($post_id_list, POSTS_TABLE, 'post_id', array('m_split')))
{ {
return; return;
} }
@ -619,7 +619,7 @@ function merge_posts($topic_id, $to_topic_id)
return; return;
} }
if (!check_ids($post_id_list, POSTS_TABLE, 'post_id', array('m_merge'))) if (!phpbb_check_ids($post_id_list, POSTS_TABLE, 'post_id', array('m_merge')))
{ {
return; return;
} }