From 6801e36defcd9628a7feeebd01c6f34366b70542 Mon Sep 17 00:00:00 2001
From: Nathan Guse <nathaniel.guse@gmail.com>
Date: Thu, 25 Apr 2013 14:13:21 -0500
Subject: [PATCH 1/3] [ticket/11435] Fix comments in events test

PHPBB3-11435
---
 tests/template/template_events_test.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/template/template_events_test.php b/tests/template/template_events_test.php
index 6cea9b92e3..0ac50c7f2b 100644
--- a/tests/template/template_events_test.php
+++ b/tests/template/template_events_test.php
@@ -16,9 +16,10 @@ class phpbb_template_template_events_test extends phpbb_template_template_test_c
 		return array(
 			/*
 			array(
-				'', // file
+				'', // Description
 				'', // dataset
 				array(), // style names
+				'', // file
 				array(), // vars
 				array(), // block vars
 				array(), // destroy

From ab87fe7982b185e9c08a3fd7248214004b23a58b Mon Sep 17 00:00:00 2001
From: Nathan Guse <nathaniel.guse@gmail.com>
Date: Thu, 25 Apr 2013 14:15:04 -0500
Subject: [PATCH 2/3] [ticket/11435] Create test to make sure template/event
 output is equal

PHPBB3-11435
---
 .../styles/all/template/variable_spacing.html |  6 ++
 .../silver/template/variable_spacing.html     |  1 +
 tests/template/template_spacing_test.php      | 87 +++++++++++++++++++
 .../template/templates/variable_spacing.html  |  6 ++
 4 files changed, 100 insertions(+)
 create mode 100644 tests/template/datasets/ext_trivial/ext/trivial/styles/all/template/variable_spacing.html
 create mode 100644 tests/template/datasets/ext_trivial/styles/silver/template/variable_spacing.html
 create mode 100644 tests/template/template_spacing_test.php
 create mode 100644 tests/template/templates/variable_spacing.html

diff --git a/tests/template/datasets/ext_trivial/ext/trivial/styles/all/template/variable_spacing.html b/tests/template/datasets/ext_trivial/ext/trivial/styles/all/template/variable_spacing.html
new file mode 100644
index 0000000000..2909e1c136
--- /dev/null
+++ b/tests/template/datasets/ext_trivial/ext/trivial/styles/all/template/variable_spacing.html
@@ -0,0 +1,6 @@
+|{VARIABLE}|
+{VARIABLE}|{VARIABLE}|
+
+|{VARIABLE}
+
+<div class="{VARIABLE}">test</div>
\ No newline at end of file
diff --git a/tests/template/datasets/ext_trivial/styles/silver/template/variable_spacing.html b/tests/template/datasets/ext_trivial/styles/silver/template/variable_spacing.html
new file mode 100644
index 0000000000..c11ae9cb40
--- /dev/null
+++ b/tests/template/datasets/ext_trivial/styles/silver/template/variable_spacing.html
@@ -0,0 +1 @@
+<!-- EVENT variable_spacing -->
\ No newline at end of file
diff --git a/tests/template/template_spacing_test.php b/tests/template/template_spacing_test.php
new file mode 100644
index 0000000000..83f8711b38
--- /dev/null
+++ b/tests/template/template_spacing_test.php
@@ -0,0 +1,87 @@
+<?php
+/**
+*
+* @package testing
+* @copyright (c) 2013 phpBB Group
+* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+*
+*/
+
+require_once dirname(__FILE__) . '/template_test_case.php';
+
+class phpbb_template_template_spacing_test extends phpbb_template_template_test_case
+{
+	public function template_data()
+	{
+		return array(
+			/*
+			array(
+				'', // Description
+				'', // dataset
+				array(), // style names
+				'', // file
+				array(), // vars
+				array(), // block vars
+				array(), // destroy
+				'', // expected result
+			),
+			*/
+			array(
+				'Spacing in templates',
+				'ext_trivial',
+				array(),
+				'variable_spacing.html',
+				array(
+					'VARIABLE'	=> '{}',
+				),
+				array(),
+				array(),
+				'|{}|
+{}|{}|
+|{}
+<div class="{}">test</div>',
+			),
+		);
+	}
+
+	/**
+	* @dataProvider template_data
+	*/
+	public function test_template($desc, $dataset, $style_names, $file, array $vars, array $block_vars, array $destroy, $expected)
+	{
+		// Run test
+		$cache_file = $this->template->cachepath . str_replace('/', '.', $file) . '.php';
+		$this->run_template($file, $vars, $block_vars, $destroy, $expected, $cache_file);
+	}
+
+	/**
+	* @dataProvider template_data
+	*/
+	public function test_event($desc, $dataset, $style_names, $file, array $vars, array $block_vars, array $destroy, $expected)
+	{
+		// Reset the engine state
+		$this->setup_engine_for_events($dataset, $style_names);
+
+		// Run test
+		$cache_file = $this->template->cachepath . str_replace('/', '.', $file) . '.php';
+		$this->run_template($file, $vars, $block_vars, $destroy, $expected, $cache_file);
+	}
+
+	protected function setup_engine_for_events($dataset, $style_names, array $new_config = array())
+	{
+		global $phpbb_root_path, $phpEx, $user;
+
+		$defaults = $this->config_defaults();
+		$config = new phpbb_config(array_merge($defaults, $new_config));
+
+		$this->template_path = dirname(__FILE__) . "/datasets/$dataset/styles/silver/template";
+		$this->style_resource_locator = new phpbb_style_resource_locator();
+		$this->extension_manager = new phpbb_mock_filesystem_extension_manager(
+			dirname(__FILE__) . "/datasets/$dataset/"
+		);
+		$this->template = new phpbb_template($phpbb_root_path, $phpEx, $config, $user, $this->style_resource_locator, new phpbb_template_context, $this->extension_manager);
+		$this->style_provider = new phpbb_style_path_provider();
+		$this->style = new phpbb_style($phpbb_root_path, $phpEx, $config, $user, $this->style_resource_locator, $this->style_provider, $this->template);
+		$this->style->set_custom_style('silver', array($this->template_path), $style_names, '');
+	}
+}
diff --git a/tests/template/templates/variable_spacing.html b/tests/template/templates/variable_spacing.html
new file mode 100644
index 0000000000..2909e1c136
--- /dev/null
+++ b/tests/template/templates/variable_spacing.html
@@ -0,0 +1,6 @@
+|{VARIABLE}|
+{VARIABLE}|{VARIABLE}|
+
+|{VARIABLE}
+
+<div class="{VARIABLE}">test</div>
\ No newline at end of file

From 356bc00a293300a777304a3c2d442868d4491344 Mon Sep 17 00:00:00 2001
From: Nathaniel Guse <nathaniel.guse@gmail.com>
Date: Tue, 30 Apr 2013 23:21:50 -0500
Subject: [PATCH 3/3] [ticket/11435] Mark extension spacing test as incomplete

This test fails until 11435 is fixed

Add newlines at EOF

PHPBB3-11435
---
 .../ext/trivial/styles/all/template/variable_spacing.html     | 2 +-
 .../ext_trivial/styles/silver/template/variable_spacing.html  | 2 +-
 tests/template/template_spacing_test.php                      | 4 ++++
 tests/template/templates/variable_spacing.html                | 2 +-
 4 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/tests/template/datasets/ext_trivial/ext/trivial/styles/all/template/variable_spacing.html b/tests/template/datasets/ext_trivial/ext/trivial/styles/all/template/variable_spacing.html
index 2909e1c136..028f8aa0d1 100644
--- a/tests/template/datasets/ext_trivial/ext/trivial/styles/all/template/variable_spacing.html
+++ b/tests/template/datasets/ext_trivial/ext/trivial/styles/all/template/variable_spacing.html
@@ -3,4 +3,4 @@
 
 |{VARIABLE}
 
-<div class="{VARIABLE}">test</div>
\ No newline at end of file
+<div class="{VARIABLE}">test</div>
diff --git a/tests/template/datasets/ext_trivial/styles/silver/template/variable_spacing.html b/tests/template/datasets/ext_trivial/styles/silver/template/variable_spacing.html
index c11ae9cb40..ad05e6f661 100644
--- a/tests/template/datasets/ext_trivial/styles/silver/template/variable_spacing.html
+++ b/tests/template/datasets/ext_trivial/styles/silver/template/variable_spacing.html
@@ -1 +1 @@
-<!-- EVENT variable_spacing -->
\ No newline at end of file
+<!-- EVENT variable_spacing -->
diff --git a/tests/template/template_spacing_test.php b/tests/template/template_spacing_test.php
index 83f8711b38..fb4161066a 100644
--- a/tests/template/template_spacing_test.php
+++ b/tests/template/template_spacing_test.php
@@ -59,6 +59,10 @@ class phpbb_template_template_spacing_test extends phpbb_template_template_test_
 	*/
 	public function test_event($desc, $dataset, $style_names, $file, array $vars, array $block_vars, array $destroy, $expected)
 	{
+		$this->markTestIncomplete(
+			'This test will fail until PHPBB3-11435 is fixed'
+		);
+
 		// Reset the engine state
 		$this->setup_engine_for_events($dataset, $style_names);
 
diff --git a/tests/template/templates/variable_spacing.html b/tests/template/templates/variable_spacing.html
index 2909e1c136..028f8aa0d1 100644
--- a/tests/template/templates/variable_spacing.html
+++ b/tests/template/templates/variable_spacing.html
@@ -3,4 +3,4 @@
 
 |{VARIABLE}
 
-<div class="{VARIABLE}">test</div>
\ No newline at end of file
+<div class="{VARIABLE}">test</div>