mirror of
https://github.com/phpbb/phpbb.git
synced 2025-07-25 03:18:52 +00:00
Merge pull request #1401 from marc1706/ticket/11531
[ticket/11531] Add basic set of functional tests for new avatar system
This commit is contained in:
Nathan Guse
commit
960c3bb4fb
5 changed files with 353 additions and 0 deletions
63
tests/functional/avatar_acp_groups_test.php
Normal file
63
tests/functional/avatar_acp_groups_test.php
Normal file
|
|
@ -0,0 +1,63 @@
|
|||
<?php
|
||||
/**
|
||||
*
|
||||
* @package testing
|
||||
* @copyright (c) 2013 phpBB Group
|
||||
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
|
||||
*
|
||||
*/
|
||||
|
||||
require_once dirname(__FILE__) . '/common_avatar_test.php';
|
||||
|
||||
/**
|
||||
* @group functional
|
||||
*/
|
||||
class phpbb_functional_avatar_acp_groups_test extends phpbb_functional_common_avatar_test
|
||||
{
|
||||
public function get_url()
|
||||
{
|
||||
return 'adm/index.php?i=acp_groups&mode=manage&action=edit&g=5';
|
||||
}
|
||||
|
||||
public function avatar_acp_groups_data()
|
||||
{
|
||||
return array(
|
||||
// Correct Gravatar
|
||||
array(
|
||||
'GROUP_UPDATED',
|
||||
'avatar_driver_gravatar',
|
||||
array(
|
||||
'avatar_gravatar_email' => 'test@example.com',
|
||||
'avatar_gravatar_width' => 80,
|
||||
'avatar_gravatar_height' => 80,
|
||||
),
|
||||
),
|
||||
// Gravatar with incorrect size
|
||||
array(
|
||||
'The submitted avatar is 120 wide and 120 high. Avatars must be at least 20 wide and 20 high, but no larger than 90 wide and 90 high.',
|
||||
'avatar_driver_gravatar',
|
||||
array(
|
||||
'avatar_gravatar_email' => 'test@example.com',
|
||||
'avatar_gravatar_width' => 120,
|
||||
'avatar_gravatar_height' => 120,
|
||||
),
|
||||
),
|
||||
// Delete avatar image to reset group settings
|
||||
array(
|
||||
'GROUP_UPDATED',
|
||||
'avatar_driver_gravatar',
|
||||
array(
|
||||
'avatar_delete' => array('tick', ''),
|
||||
),
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @dataProvider avatar_acp_groups_data
|
||||
*/
|
||||
public function test_avatar_acp_groups($expected, $avatar_type, $data)
|
||||
{
|
||||
$this->assert_avatar_submit($expected, $avatar_type, $data);
|
||||
}
|
||||
}
|
||||
61
tests/functional/avatar_acp_users_test.php
Normal file
61
tests/functional/avatar_acp_users_test.php
Normal file
|
|
@ -0,0 +1,61 @@
|
|||
<?php
|
||||
/**
|
||||
*
|
||||
* @package testing
|
||||
* @copyright (c) 2013 phpBB Group
|
||||
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
|
||||
*
|
||||
*/
|
||||
|
||||
require_once dirname(__FILE__) . '/common_avatar_test.php';
|
||||
|
||||
/**
|
||||
* @group functional
|
||||
*/
|
||||
class phpbb_functional_avatar_acp_users_test extends phpbb_functional_common_avatar_test
|
||||
{
|
||||
public function get_url()
|
||||
{
|
||||
return 'adm/index.php?i=acp_users&u=2&mode=avatar';
|
||||
}
|
||||
|
||||
public function avatar_acp_users_data()
|
||||
{
|
||||
return array(
|
||||
// Gravatar with incorrect email
|
||||
array(
|
||||
'EMAIL_INVALID_EMAIL',
|
||||
'avatar_driver_gravatar',
|
||||
array(
|
||||
'avatar_gravatar_email' => 'test.example.com',
|
||||
'avatar_gravatar_width' => 80,
|
||||
'avatar_gravatar_height' => 80,
|
||||
),
|
||||
),
|
||||
// Remote avatar with correct link
|
||||
array(
|
||||
'USER_AVATAR_UPDATED',
|
||||
'avatar_driver_upload',
|
||||
array(
|
||||
'avatar_upload_url' => 'https://secure.gravatar.com/avatar/55502f40dc8b7c769880b10874abc9d0.jpg',
|
||||
),
|
||||
),
|
||||
// Reset avatar settings
|
||||
array(
|
||||
'USER_AVATAR_UPDATED',
|
||||
'avatar_driver_gravatar',
|
||||
array(
|
||||
'avatar_delete' => array('tick', ''),
|
||||
),
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @dataProvider avatar_acp_users_data
|
||||
*/
|
||||
public function test_avatar_acp_users($expected, $avatar_type, $data)
|
||||
{
|
||||
$this->assert_avatar_submit($expected, $avatar_type, $data);
|
||||
}
|
||||
}
|
||||
71
tests/functional/avatar_ucp_groups_test.php
Normal file
71
tests/functional/avatar_ucp_groups_test.php
Normal file
|
|
@ -0,0 +1,71 @@
|
|||
<?php
|
||||
/**
|
||||
*
|
||||
* @package testing
|
||||
* @copyright (c) 2013 phpBB Group
|
||||
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
|
||||
*
|
||||
*/
|
||||
|
||||
require_once dirname(__FILE__) . '/common_avatar_test.php';
|
||||
|
||||
/**
|
||||
* @group functional
|
||||
*/
|
||||
class phpbb_functional_avatar_ucp_groups_test extends phpbb_functional_common_avatar_test
|
||||
{
|
||||
public function get_url()
|
||||
{
|
||||
return 'ucp.php?i=ucp_groups&mode=manage&action=edit&g=5';
|
||||
}
|
||||
|
||||
public function avatar_ucp_groups_data()
|
||||
{
|
||||
return array(
|
||||
// Incorrect URL
|
||||
array(
|
||||
'AVATAR_URL_INVALID',
|
||||
'avatar_driver_upload',
|
||||
array(
|
||||
'avatar_upload_url' => 'https://secure.gravatar.com/avatar/55502f40dc8b7c769880b10874abc9d0?s=80',
|
||||
),
|
||||
),
|
||||
/*
|
||||
// Does not work due to DomCrawler issue
|
||||
// Valid file upload
|
||||
array(
|
||||
'GROUP_UPDATED',
|
||||
'avatar_driver_upload',
|
||||
array(
|
||||
'avatar_upload_file' => array('upload', $this->path . 'valid.jpg'),
|
||||
),
|
||||
),
|
||||
*/
|
||||
// Correct remote avatar
|
||||
array(
|
||||
'GROUP_UPDATED',
|
||||
'avatar_driver_remote',
|
||||
array(
|
||||
'avatar_remote_url' => 'https://secure.gravatar.com/avatar/55502f40dc8b7c769880b10874abc9d0.jpg',
|
||||
'avatar_remote_width' => 80,
|
||||
'avatar_remote_height' => 80,
|
||||
),
|
||||
),
|
||||
array(
|
||||
'GROUP_UPDATED',
|
||||
'avatar_driver_gravatar',
|
||||
array(
|
||||
'avatar_delete' => array('tick', ''),
|
||||
),
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @dataProvider avatar_ucp_groups_data
|
||||
*/
|
||||
public function test_avatar_ucp_groups($expected, $avatar_type, $data)
|
||||
{
|
||||
$this->assert_avatar_submit($expected, $avatar_type, $data);
|
||||
}
|
||||
}
|
||||
78
tests/functional/avatar_ucp_users_test.php
Normal file
78
tests/functional/avatar_ucp_users_test.php
Normal file
|
|
@ -0,0 +1,78 @@
|
|||
<?php
|
||||
/**
|
||||
*
|
||||
* @package testing
|
||||
* @copyright (c) 2013 phpBB Group
|
||||
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
|
||||
*
|
||||
*/
|
||||
|
||||
require_once dirname(__FILE__) . '/common_avatar_test.php';
|
||||
|
||||
/**
|
||||
* @group functional
|
||||
*/
|
||||
class phpbb_functional_avatar_ucp_users_test extends phpbb_functional_common_avatar_test
|
||||
{
|
||||
public function get_url()
|
||||
{
|
||||
return 'ucp.php?i=ucp_profile&mode=avatar';
|
||||
}
|
||||
|
||||
public function avatar_ucp_groups_data()
|
||||
{
|
||||
return array(
|
||||
// Gravatar with correct settings
|
||||
array(
|
||||
'PROFILE_UPDATED',
|
||||
'avatar_driver_gravatar',
|
||||
array(
|
||||
'avatar_gravatar_email' => 'test@example.com',
|
||||
'avatar_gravatar_width' => 80,
|
||||
'avatar_gravatar_height' => 80,
|
||||
),
|
||||
),
|
||||
// Wrong driver selected
|
||||
array(
|
||||
'NO_AVATAR_SELECTED',
|
||||
'avatar_driver_upload',
|
||||
array(
|
||||
'avatar_remote_url' => 'https://secure.gravatar.com/avatar/55502f40dc8b7c769880b10874abc9d0.jpg',
|
||||
'avatar_remote_width' => 80,
|
||||
'avatar_remote_height' => 80,
|
||||
),
|
||||
),
|
||||
array(
|
||||
'PROFILE_UPDATED',
|
||||
'avatar_driver_gravatar',
|
||||
array(
|
||||
'avatar_delete' => array('tick', ''),
|
||||
),
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @dataProvider avatar_ucp_groups_data
|
||||
*/
|
||||
public function test_avatar_ucp_groups($expected, $avatar_type, $data)
|
||||
{
|
||||
$this->assert_avatar_submit($expected, $avatar_type, $data);
|
||||
}
|
||||
|
||||
public function test_display_upload_avatar()
|
||||
{
|
||||
$this->assert_avatar_submit('PROFILE_UPDATED',
|
||||
'avatar_driver_upload',
|
||||
array(
|
||||
'avatar_upload_url' => 'https://secure.gravatar.com/avatar/55502f40dc8b7c769880b10874abc9d0.jpg',
|
||||
)
|
||||
);
|
||||
|
||||
$crawler = self::request('GET', $this->get_url() . '&sid=' . $this->sid);
|
||||
$avatar_link = $crawler->filter('img')->attr('src');
|
||||
$crawler = self::request('GET', $avatar_link . '&sid=' . $this->sid, array(), false);
|
||||
$content = self::$client->getResponse()->getContent();
|
||||
self::assertEquals(false, stripos(trim($content), 'debug'), 'Output contains debug message');
|
||||
}
|
||||
}
|
||||
80
tests/functional/common_avatar_test.php
Normal file
80
tests/functional/common_avatar_test.php
Normal file
|
|
@ -0,0 +1,80 @@
|
|||
<?php
|
||||
/**
|
||||
*
|
||||
* @package testing
|
||||
* @copyright (c) 2013 phpBB Group
|
||||
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
|
||||
*
|
||||
*/
|
||||
|
||||
/**
|
||||
* @group functional
|
||||
*/
|
||||
abstract class phpbb_functional_common_avatar_test extends phpbb_functional_test_case
|
||||
{
|
||||
private $path;
|
||||
private $form_content;
|
||||
|
||||
abstract function get_url();
|
||||
|
||||
public function setUp()
|
||||
{
|
||||
parent::setUp();
|
||||
$this->path = __DIR__ . '/fixtures/files/';
|
||||
$this->login();
|
||||
$this->admin_login();
|
||||
$this->add_lang(array('acp/board', 'ucp', 'acp/users', 'acp/groups'));
|
||||
$this->set_acp_settings();
|
||||
}
|
||||
|
||||
private function set_acp_settings()
|
||||
{
|
||||
$crawler = self::request('GET', 'adm/index.php?i=acp_board&mode=avatar&sid=' . $this->sid);
|
||||
// Check the default entries we should have
|
||||
$this->assertContainsLang('ALLOW_GRAVATAR', $crawler->text());
|
||||
$this->assertContainsLang('ALLOW_REMOTE', $crawler->text());
|
||||
$this->assertContainsLang('ALLOW_AVATARS', $crawler->text());
|
||||
$this->assertContainsLang('ALLOW_LOCAL', $crawler->text());
|
||||
|
||||
// Now start setting the needed settings
|
||||
$form = $crawler->selectButton($this->lang('SUBMIT'))->form();
|
||||
$form['config[allow_avatar_local]']->select(1);
|
||||
$form['config[allow_avatar_gravatar]']->select(1);
|
||||
$form['config[allow_avatar_remote]']->select(1);
|
||||
$form['config[allow_avatar_remote_upload]']->select(1);
|
||||
$crawler = self::submit($form);
|
||||
$this->assertContainsLang('CONFIG_UPDATED', $crawler->text());
|
||||
}
|
||||
|
||||
public function assert_avatar_submit($expected, $type, $data, $button_text = 'SUBMIT')
|
||||
{
|
||||
$crawler = self::request('GET', $this->get_url() . '&sid=' . $this->sid);
|
||||
|
||||
// Test if setting a gravatar avatar properly works
|
||||
$form = $crawler->selectButton($this->lang($button_text))->form();
|
||||
$form['avatar_driver']->select($type);
|
||||
|
||||
foreach ($data as $key => $value)
|
||||
{
|
||||
if (is_array($value))
|
||||
{
|
||||
$form[$key]->$value[0]($value[1]);
|
||||
}
|
||||
else
|
||||
{
|
||||
$form[$key]->setValue($value);
|
||||
}
|
||||
}
|
||||
|
||||
$crawler = self::submit($form);
|
||||
|
||||
try
|
||||
{
|
||||
$this->assertContainsLang($expected, $crawler->text());
|
||||
}
|
||||
catch (Exception $e)
|
||||
{
|
||||
$this->assertContains($expected, $crawler->text());
|
||||
}
|
||||
}
|
||||
}
|
||||
Loading…
Add table
Reference in a new issue