makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 06:08:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/12710] Correctly fetch unique and normal indexes only in MSSQL

Browse source 
PHPBB3-12710
This commit is contained in:
Joas Schilling 2014-08-07 19:56:31 +02:00
parent b39305b9f6
commit 96fc29eecc
1 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
phpBB/phpbb/db/tools.php
View file

@ -1816,7 +1816,8 @@ class tools
$old_return_statements = $this->return_statements; $old_return_statements = $this->return_statements;
$this->return_statements = true; $this->return_statements = true;
$indexes = $this->mssql_get_existing_indexes($table_name, $column_name); $indexes = $this->get_existing_indexes($table_name, $column_name);
$indexes = array_merge($indexes, $this->get_existing_indexes($table_name, $column_name, true));
// Drop any indexes // Drop any indexes
$recreate_indexes = array(); $recreate_indexes = array();
@ -2615,12 +2616,6 @@ class tools
{ {
case 'mssql': case 'mssql':
case 'mssqlnative': case 'mssqlnative':
if ($unique)
{
// TODO fix me
throw new \Exception('FIX ME mssql treats unique and normal indexes the same');
}
if ($this->mssql_is_sql_server_2000()) if ($this->mssql_is_sql_server_2000())
{ {
// http://msdn.microsoft.com/en-us/library/aa175912%28v=sql.80%29.aspx // http://msdn.microsoft.com/en-us/library/aa175912%28v=sql.80%29.aspx
@ -2634,7 +2629,8 @@ class tools
ON cols.colid = ixc.colid ON cols.colid = ixc.colid
AND cols.id = ix.id AND cols.id = ix.id
WHERE ix.id = object_id('{$table_name}') WHERE ix.id = object_id('{$table_name}')
AND cols.name = '{$column_name}'"; AND cols.name = '{$column_name}'
AND INDEXPROPERTY(ix.id, ix.name, 'IsUnique') = " . ($unique) ? '1' : '0';
} }
else else
{ {
@ -2647,7 +2643,8 @@ class tools
ON cols.column_id = ixc.column_id ON cols.column_id = ixc.column_id
AND cols.object_id = ix.object_id AND cols.object_id = ix.object_id
WHERE ix.object_id = object_id('{$table_name}') WHERE ix.object_id = object_id('{$table_name}')
AND cols.name = '{$column_name}'"; AND cols.name = '{$column_name}'
AND ix.is_unique = " . ($unique) ? '1' : '0';
} }
break; break;