From 9b596faa3976fb17c13eb4c8d604c9e388f47209 Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Wed, 10 Mar 2010 01:37:35 +0100 Subject: [PATCH] [feature/unapproved-posts-in-feed] Increase performance of is_moderator_approve_forum() as per bantu --- phpBB/feed.php | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/phpBB/feed.php b/phpBB/feed.php index 575e937330..4eb70c76c8 100644 --- a/phpBB/feed.php +++ b/phpBB/feed.php @@ -543,15 +543,20 @@ class phpbb_feed_base function is_moderator_approve_forum($forum_id) { - $forum_ids = $this->get_moderator_approve_forums(); + static $forum_ids; + + if (!isset($forum_ids)) + { + $forum_ids = array_flip($this->get_moderator_approve_forums()); + } if (!$forum_id) { // Global announcement, your a moderator in any forum than it's okay. - return (sizeof($forum_ids) > 0) ? true : false; + return (!empty($forum_ids)) ? true : false; } - return (in_array($forum_id, $forum_ids)) ? true : false; + return (isset($forum_ids[$forum_id])) ? true : false; } function get_excluded_forums()